Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: storage: fileUtils: drop redundant warning
..


storage: fileUtils: drop redundant warning

The usage of warnings.warn in the fileUtils
looks redundant, since we log the same information
in the line before.
So this patch just drops it.

Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Related-To: https://bugzilla.redhat.com/1364149
Bug-Url: https://bugzilla.redhat.com/1369822
Backport-To: 4.0
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/62208
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64514
---
M lib/vdsm/storage/fileUtils.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1: Verified+1

verified on-branch the same way as master; it is a trivial removal, I did some 
basic virt flows, as well as explicit SPM selection, without issues.

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1369822::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Hello Nir Soffer,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64514

to review the following change.

Change subject: storage: fileUtils: drop redundant warning
..

storage: fileUtils: drop redundant warning

The usage of warnings.warn in the fileUtils
looks redundant, since we log the same information
in the line before.
So this patch just drops it.

Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Related-To: https://bugzilla.redhat.com/1364149
Bug-Url: https://bugzilla.redhat.com/1369822
Backport-To: 4.0
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/62208
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/vdsm/storage/fileUtils.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/64514/1

diff --git a/lib/vdsm/storage/fileUtils.py b/lib/vdsm/storage/fileUtils.py
index 0fa4901..00c64fa 100644
--- a/lib/vdsm/storage/fileUtils.py
+++ b/lib/vdsm/storage/fileUtils.py
@@ -35,7 +35,6 @@
 import subprocess
 import sys
 import types
-import warnings
 
 from contextlib import closing
 from contextlib import contextmanager
@@ -217,7 +216,6 @@
 if not stat.S_ISDIR(statinfo.st_mode):
 raise OSError(errno.ENOTDIR, "Not a directory %s" % dirPath)
 log.debug("Using existing directory: %s", dirPath)
-warnings.warn("Using existing direcotory: %s" % dirPath, stacklevel=2)
 if mode is not None:
 curMode = stat.S_IMODE(statinfo.st_mode)
 if curMode != mode:


-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org