Change in vdsm[master]: dump the core of a domain

2012-08-20 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a domain .. Patch Set 1: VIR_DUMP_MEMORY_ONLY was support recently buy libvirt and qemu. So to test DUMP_MEMORY_ONLY, should update libvirt

Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7323 To

Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

2012-08-20 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: vdsm: generating uuid for libvirt configuration (#842115) .. vdsm: generating uuid for libvirt configuration (#842115) during migration we found that if both

Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 5: Verified just verified that you can now remove a network defined with an MTU. -- To

Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. BZ#848299 - Fix delete VLANed network with custom MTU Change-Id:

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 1: (1 inline comment) File Makefile.am Line 139:

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. Patch Set 4: Build Successful

Change in vdsm[master]: Use quiesce only if qgaEnable is enabled

2012-08-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: why should we attempt live snapshot with no guest agent support? The question was: why

Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: generating uuid for libvirt configuration (#842115) .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/532/ :

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. Patch Set 4: (6 inline comments) partial review. Please break to smaller

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. Patch Set 4: I would prefer that you didn't submit this -- To view, visit

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/533/ : SUCCESS -- To

Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: generating uuid for libvirt configuration (#842115) .. Patch Set 1: I would prefer that you didn't submit this (4 inline comments) minor comments. I

Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: generating uuid for libvirt configuration (#842115) .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/534/

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7295 To unsubscribe, visit

Change in vdsm[master]: wip - vdsm: improve message when trying to attach import dom...

2012-08-20 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: wip - vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 1: I've put WIP, as I'm still validating it.

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7295 To

Change in vdsm[master]: wip - vdsm: improve message when trying to attach import dom...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: wip - vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 1: Build Successful

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/536/ :

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

2012-08-20 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: infra: adding debug log to vdsm daemon init script .. infra: adding debug log to vdsm daemon init script Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd

Change in vdsm[master]: Use quiesce only if qgaEnable is enabled

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7143 To

Change in vdsm[master]: wip - vdsm: improve message when trying to attach import dom...

2012-08-20 Thread abaron
Ayal Baron has posted comments on this change. Change subject: wip - vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 1: Looks good to me, but someone else must approve

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...

2012-08-20 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 2: Verified Verified. Only changed commit message

Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 2: Build Successful

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

2012-08-20 Thread lvroyce
Royce Lv has uploaded a new change for review. Change subject: avoid redundant domain produce() in createStoragePool .. avoid redundant domain produce() in createStoragePool Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/538/ :

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

2012-08-20 Thread shuming
Shu Ming has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool .. Patch Set 1: I would prefer that you didn't submit this I don't think this patch is in right direction. The

Change in vdsm[master]: vdsm: improve message when trying to attach import domain wi...

2012-08-20 Thread shuming
Shu Ming has posted comments on this change. Change subject: vdsm: improve message when trying to attach import domain with wrong permissions (#842146) .. Patch Set 2: I would prefer that you didn't submit this (1 inline

Change in vdsm[master]: BZ#842115 - Generating uuid for libvirt configuration

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#842115 - Generating uuid for libvirt configuration .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/539/ :

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: Add eclipse and PyDev project files to .gitignore .. Add eclipse and PyDev project files to .gitignore PyDev as eclipse plugin is commonly used for developing

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: BZ#811807 Enable network filtering .. BZ#811807 Enable network filtering The VM network ineterface might recieve a list of rules to control the VM traffic by

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: BZ#811807 Define network filter on libvirt .. BZ#811807 Define network filter on libvirt The patch defines custom network filter on libvirt in order to control

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/540/ : SUCCESS -- To

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

2012-08-20 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#833425 Change cpu topology source to /sys. .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add eclipse and PyDev project files to .gitignore .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/541/ :

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread lpeer
Livnat Peer has posted comments on this change. Change subject: Add eclipse and PyDev project files to .gitignore .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7352

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/543/ : SUCCESS --

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: Verified; I would prefer that you didn't submit this Postponing, I had an idea on how to improve

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 2: No score -- To view, visit http://gerrit.ovirt.org/7295 To unsubscribe, visit

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 1: (1 inline comment) Dan asked to put it in tools, isn't he?

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread Ryan Harper
Ryan Harper has uploaded a new change for review. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Fix vdsm-faqemu VM launch failure on hosts with newer libvirt Since January 2012, libvirt now

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread Ryan Harper
Ryan Harper has abandoned this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Abandoned resubmitted under another topic (accident): See http://gerrit.ovirt.org/7359 --

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Verified Updated this patch to replace exec of touch. Also added a check to only

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-20 Thread ilvovsky
Igor Lvovsky has uploaded a new change for review. Change subject: configNetwork: use MTU as int in setNewMtu .. configNetwork: use MTU as int in setNewMtu Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Signed-off-by:

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread masayag
Moti Asayag has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 1: (1 inline comment) Tools isn't good enough since it fails to establish the libvirt connection. In

Change in vdsm[master]: Optimize _getConfigValue to return multiple values

2012-08-20 Thread ilvovsky
Igor Lvovsky has abandoned this change. Change subject: Optimize _getConfigValue to return multiple values .. Patch Set 4: Abandoned -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Build Successful

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/545/ : SUCCESS --

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 5: Build Successful

Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 2: Build Successful

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-20 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 6: (1 inline comment) File

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add eclipse and PyDev project files to .gitignore .. Patch Set 1: Verified; Looks good to me, approved works for me. -- To view, visit

Change in vdsm[master]: Add eclipse and PyDev project files to .gitignore

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add eclipse and PyDev project files to .gitignore .. Add eclipse and PyDev project files to .gitignore PyDev as eclipse plugin is commonly used for

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6867 To unsubscribe, visit

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/548/ : SUCCESS --

Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 6: Build Successful

Change in vdsm[master]: Restore previous MTU on bond when VLAN with bigger MTU remov...

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restore previous MTU on bond when VLAN with bigger MTU removed .. Patch Set 3: Build Successful

Change in vdsm[master]: BZ#846004 - IP on nic/bond should be preserved when VLAN add...

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Looks good to me, approved goodness gracious. this has never ever worked. thanks for fixing this

Change in vdsm[master]: BZ#811807 Libvirt service engagement workaround

2012-08-20 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: BZ#811807 Libvirt service engagement workaround .. BZ#811807 Libvirt service engagement workaround The patch intended to bypass a false report of libvirt service

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread masayag
Moti Asayag has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line 960:

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#811807 Libvirt service engagement workaround

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Libvirt service engagement workaround .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/551/ : SUCCESS

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/552/ : SUCCESS --

Change in vdsm[master]: BZ#811807 Enable network filtering

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/553/ : SUCCESS -- To view,

Change in vdsm[master]: engine.py: fix nodeCleanup() call

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine.py: fix nodeCleanup() call .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/554/ : SUCCESS -- To view,

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-20 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit

Change in vdsm[master]: Enable fake_kvm_support on hosts without hardware VT support...

2012-08-20 Thread wudxw
Mark Wu has abandoned this change. Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

2012-08-20 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool .. Patch Set 1: Ming, my consideration is not the case dom can be find and validate case. The first lookup and

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Remove 'skipLibvirt' from NetworkOptions The option 'skipLibvirt' was removed in commit ccb07ae. So it

Change in vdsm[master]: faqemu: use domain type 'qemu' instead of the emulator wrapp...

2012-08-20 Thread wudxw
Mark Wu has abandoned this change. Change subject: faqemu: use domain type 'qemu' instead of the emulator wrapper .. Patch Set 1: Abandoned It's resolved in http://gerrit.ovirt.org/#/c/7359/ -- To view, visit

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/555/ :

Change in vdsm[master]: Use quiesce only if qgaEnable is enabled

2012-08-20 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, but someone else must approve There's an availability checking for guest agent in libvirt,

Change in vdsm[master]: BZ#811807 Define network filter on libvirt

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Define network filter on libvirt .. Patch Set 2: I would prefer that you didn't submit this (9 inline comments)

Change in vdsm[master]: BZ#811807 Libvirt service engagement workaround

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Libvirt service engagement workaround .. Patch Set 1: (3 inline comments) arghh, that's ugly - but not your fault, and I have no better idea.

Change in vdsm[master]: dump the core of a domain

2012-08-20 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: dump the core of a domain .. dump the core of a domain libvirt support an API to dump the core of a domain on a given file for analysis when guest OS crash.

Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

2012-08-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with custom MTU .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe,

Change in vdsm[master]: dump the core of a domain

2012-08-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: dump the core of a domain .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/527/ : SUCCESS -- To view, visit

Change in vdsm[master]: vdsm: libvirt service was restarted everytime vdsm was resta...

2012-08-20 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) .. vdsm: libvirt service was restarted everytime vdsm was restarted (#734847) This