Kiril Nesenko has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/25861
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/2/vdsm_api/vdsmapi-schema.json
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6729/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Add the host uptime in seconds to host stats
..
Patch Set 2: Code-Review-1
replaced by http://gerrit.ovirt.org/#/c/25877/2 . please continue the review
there
Alon Bar-Lev has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25861
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6730/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6731/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
(2 comments)
just a couple of nits. I'm really looking forward to have this merged!
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6732/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 1:
I like the concept, I'll give it a try. At first glance it should be feasible
with a few more
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(1 comment)
Nir, a big thank you for the very detailed and in-depth review. You raised very
Tal Nisan has abandoned this change.
Change subject: Add the host uptime in seconds to host stats
..
Abandoned
Abandoned due to a similar patch pushed
--
To view, visit http://gerrit.ovirt.org/25835
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 2: Verified+1
Verified with creating an NFS ISO domain and getting the correct file stats (in
order to make
Kiril Nesenko has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2:
(6 comments)
http://gerrit.ovirt.org/#/c/25912/2/init/vdsmd_init_common.sh.in
File
Martin Peřina has uploaded a new change for review.
Change subject: caps: Collect kdump status
..
caps: Collect kdump status
Adds kdump configuration status to caps module. The status will be
reported to engine in xml response
Federico Simoncelli has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 7: Code-Review+2
(1 comment)
Fine by me even though having two patches would have been better.
Dima Kuznetsov has uploaded a new change for review.
Change subject: hooks: Add hook for fake VM stats
..
hooks: Add hook for fake VM stats
Added hook to generate random VmStats for fake (or real) VMs.
Added before and after
Martin Peřina has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 1: Code-Review-1
Please ignore now, I misplaced it, kdump status should be in sampling
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Allow getFileStats for non NFS ISO domains
..
Allow getFileStats for non NFS ISO domains
getFileStats only allowed file stats to be gathered from NFS
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 2: Code-Review-1
(5 comments)
http://gerrit.ovirt.org/#/c/25927/2/vdsm.spec.in
File vdsm.spec.in:
Line 431:
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/2/vdsm_hooks/fakevmstats/after_vm_stats.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/2/vdsm_hooks/fakevmstats/after_vm_stats.py
File
Tal Nisan has uploaded a new change for review.
Change subject: Allow getFileStats for non NFS ISO domains
..
Allow getFileStats for non NFS ISO domains
getFileStats only allowed file stats to be gathered from NFS ISO domains.
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1:
does it fix a bug in 3.4 ? why do we need it in stable branch?
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/25928
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6733/ : FAILURE
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1:
Yes, a bug in 3.4 which is a regression, but you could have just click on the
bug link in the message
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Use the correct configuration value for ovirt-3.3
..
Use the correct configuration value for ovirt-3.3
During the backport the name of the configuration
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/389/ :
FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/2/vdsm_hooks/fakevmstats/after_vm_stats.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: Use the correct configuration value for ovirt-3.3
..
Patch Set 3: Verified+1
Verified by lsvaty and me. The migration now correctly gets aborted when the
Vinzenz Feenstra has posted comments on this change.
Change subject: Use the correct configuration value for ovirt-3.3
..
Patch Set 3:
Please note that there's no commits for master or ovirt-3.4 required since this
a bug
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/390/ :
FAILURE
Martin Peřina has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6736/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6737/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add contrib directory to the tarball
..
Add contrib directory to the tarball
- Added contrib directory to the tarball
- Moved vdsm/ut/ivdsm.py to
Dan Kenigsberg has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 5:
Please add to the commit message some numbers: how faster does it make your
concurrent statup benchmark?
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Use the correct configuration value for ovirt-3.3
..
Use the correct configuration value for ovirt-3.3
During the backport in
Dan Kenigsberg has posted comments on this change.
Change subject: Use the correct configuration value for ovirt-3.3
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25929
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Use the correct configuration value for ovirt-3.3
..
Patch Set 3:
Escalating score, and merging due to the urgency of this matter.
--
To view, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py
File vdsm/vmCommands.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: setupNetworks: Fix incorrect mtu overriding when adding
multiple networks
..
Patch Set 2: Code-Review+2
(1 comment)
Francesco Romani has posted comments on this change.
Change subject: Use the correct configuration value for ovirt-3.3
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25929
To unsubscribe, visit
Frank Kobzik has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 5: Code-Review-1
please don't review so far.
--
To view, visit http://gerrit.ovirt.org/23555
To
Hello Alon Bar-Lev, Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25934
to review the following change.
Change subject: Add contrib directory to the tarball
..
Add contrib
Kiril Nesenko has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25934
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25934
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Add contrib directory to the tarball
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25934
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Add contrib directory to the tarball
..
Add contrib directory to the tarball
- Added contrib directory to the tarball
- Moved vdsm/ut/ivdsm.py to
Martin Sivák has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/17694/10/vdsm/vm.py
File vdsm/vm.py:
Line 461: class
Yaniv Bronhaim has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25926/2//COMMIT_MSG
Commit Message:
Line 7: sampling: Collect kdump
Yaniv Bronhaim has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 2: Code-Review-1
just fix the commit msg
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 2: Code-Review+2
thanks. please verify
--
To view, visit http://gerrit.ovirt.org/25928
To
Allon Mureinik has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25928
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25912/2/init/vdsmd_init_common.sh.in
File
Yaniv Bronhaim has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25912/2//COMMIT_MSG
Commit Message:
Line 10: user
please explain
Yaniv Bronhaim has posted comments on this change.
Change subject: test: ssl reactor not tested in jsonrpc tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24624
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/391/ :
Martin Peřina has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25926/2//COMMIT_MSG
Commit Message:
Line 7: sampling: Collect kdump
Martin Peřina has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6740/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/392/ :
FAILURE
Douglas Schilling Landgraf has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 2:
(1 comment)
I like the new module names, it could be nice if the test names were also
reordered under
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6741/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6743/ :
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 2:
(8 comments)
http://gerrit.ovirt.org/#/c/25912/2//COMMIT_MSG
Commit Message:
Line 6:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 13: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6745/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6746/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: LiveMerge: Add Image.getVolumeChain API
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6747/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: jsonrpc: StoragePool connect missing default value
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24641
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6748/ :
Tal Nisan has posted comments on this change.
Change subject: Allow getFileStats for non NFS ISO domains
..
Patch Set 2: Verified+1
Verified with creating an NFS ISO domain and getting the correct file stats (in
order to make
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Allow getFileStats for non NFS ISO domains
..
Allow getFileStats for non NFS ISO domains
getFileStats only allowed file stats to be gathered from NFS
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 485:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
..
Patch Set 12:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
..
Patch Set 13:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13: Code-Review-1
(8 comments)
This is a very nice patch, but it needs some more work.
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25912/4/init/vdsmd_init_common.sh.in
File
Dan Kenigsberg has uploaded a new change for review.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sample
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm iface stats: fix arithmetic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6752/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
vnic QoS: Fix specParams to XML definition conversion
VDSM API specifies specParams input and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
PEP8
--
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
Build Successful
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25912/4/init/vdsmd_init_common.sh.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6755/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6756/ : To avoid
97 matches
Mail list logo
