Change in vdsm[master]: vm: devices: replace Watchdog device info

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: replace Watchdog device info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: devices: watchdog: use 'continue'

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: devices: watchdog: use 'continue' .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: devices: smartcard: warn if missing address

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: devices: smartcard: warn if missing address .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: devices: sound: reorganize getUnderlying

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: devices: sound: reorganize getUnderlying .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: devices: replace Video device info

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: replace Video device info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: devices: video: reorganize getUnderlying

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: devices: video: reorganize getUnderlying .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: devices: memory: reorganize getUnderlying

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: devices: memory: reorganize getUnderlying .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (4 comments) We need a functional test for this. It is easy to do. just make sure (by playing

Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add documentation for setupNetworks rollback mechanism. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vm: add generic getUnderlyingDeviceInfo

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add generic getUnderlyingDeviceInfo .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: devices: replace Sound device info

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: replace Sound device info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: devices: replace Smartcard device info

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: replace Smartcard device info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: devices: replace Memory device info

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: replace Memory device info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: add documentation for setupNetworks rollback mechanism. .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50261/1/lib/vdsm/network/api.py File

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py File

Change in vdsm[ovirt-3.6]: config: Resolve crash when IPv6 disabled in kernel

2015-12-17 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: config: Resolve crash when IPv6 disabled in kernel .. config: Resolve crash when IPv6 disabled in kernel The configuration for creating the

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

2015-12-17 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: p3test: add few modules that currently pass on Python 3 .. p3test: add few modules that currently pass on Python 3 Change-Id:

Change in vdsm[ovirt-3.6]: config: Resolve crash when IPv6 disabled in kernel

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: config: Resolve crash when IPv6 disabled in kernel .. Patch Set 2: * #1277204::Update tracker: OK * Set MODIFIED::bug 1277204#1277204OK -- To view,

Change in vdsm[ovirt-3.6]: config: Resolve crash when IPv6 disabled in kernel

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: config: Resolve crash when IPv6 disabled in kernel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50457 To unsubscribe, visit

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: p3test: add few modules that currently pass on Python 3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: Mapping bonding option value names to numerics

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 25: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py

Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50507 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 2: * #1275539::Update tracker: OK * Set MODIFIED::bug 1275539#1275539IGNORE, not oVirt classification

Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute

2015-12-17 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: Add support for vgamem attribute .. virt: Add support for vgamem attribute SPICE/QXL video RAM sizes are currently specified in domain XML

Change in vdsm[ovirt-3.6]: vm: fix misleading XML log

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: fix misleading XML log .. Patch Set 4: * #1292371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1292371::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-12-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 20: Verified+1 -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Code-Review+1 Partial ACK. do we need to wait for Engine to support this feature, or

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49579 To unsubscribe, visit

Change in vdsm[master]: v2v: refactor get_external_vms

2015-12-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: refactor get_external_vms .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/49636 To unsubscribe, visit

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

2015-12-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova .. Patch Set 7: Verified importing ova file and VM from esxi 5.5 -- To view, visit

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

2015-12-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/49951 To unsubscribe, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: a. IMO we can insert this w/o waiting for engine. it breaks nothing since engine currently

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. net: support hot(un)plugNic for SRIOV network devices. The missing behavior was to

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

2015-12-17 Thread aaviram
Amit Aviram has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44045 To unsubscribe,

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

2015-12-17 Thread aaviram
Amit Aviram has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50339 To unsubscribe,

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Rename storageConstants.py to constants.py .. Patch Set 2: Adam, did you test this code with your new patches? Is it ready for merge? -- To view, visit

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

2015-12-17 Thread aaviram
Amit Aviram has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50631 To unsubscribe, visit

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50657/1//COMMIT_MSG Commit Message: Line 6: Line 7: net:

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

2015-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: p3test: add few modules that currently pass on Python 3 .. Patch Set 1: Verified+1 domainDescriptorTests.DevicesHashTests test_different_devices

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

2015-12-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Rename storageConstants.py to constants.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50633 To unsubscribe, visit

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-17 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 1: Code-Review-1 (2 comments) nice patch, just a nit. do we have something similar for vlans?

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-17 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50657 To unsubscribe, visit

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50657 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: * #1276445::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1276445::OK, public bug * Check

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-17 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 7: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 6 -- To

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 12: * #1290997::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1290997::OK, public bug *

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: executor: Fix the task-callable mismtach .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50228 To unsubscribe, visit

Change in vdsm[master]: executor: Streamline __repr__

2015-12-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: executor: Streamline __repr__ .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50627 To unsubscribe, visit

Change in vdsm[master]: Remove koji build flag and use specific one for vhostmd

2015-12-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Remove koji build flag and use specific one for vhostmd .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49427 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 6: * #1276445::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1276445::OK, public bug * Check

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 12: > Build Failed > > http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1557/ > :

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-17 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/49580/5//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: Always propagate bonding mode to engine

2015-12-17 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/kernelconfig.py File

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

2015-12-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Rename storageConstants.py to constants.py .. Patch Set 2: Verified+1 Tested by running running a VM and doing a LSM and snapshot merge. -- To view,

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 12: Verified+1 Following verification performed while glusterfs-cli is not installed: 1. Added a 3.5 host,

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

2015-12-17 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: Rename storageConstants.py to constants.py .. storage: Rename storageConstants.py to constants.py The SDM work is beginning an effort to

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Rename storageConstants.py to constants.py .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: virt: Fix @staticmethod usage in guest agent

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Fix @staticmethod usage in guest agent .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50656/1/vdsm/virt/guestagent.py File

Change in vdsm[master]: fileSD: Do not try to remove non-existent lease file

2015-12-17 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: fileSD: Do not try to remove non-existent lease file .. fileSD: Do not try to remove non-existent lease file The volume.lease file exists only if a domain

Change in vdsm[master]: fileSD: Do not try to remove non-existent lease file

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileSD: Do not try to remove non-existent lease file .. Patch Set 2: * #1291207::Update tracker: OK * Set MODIFIED::bug 1291207#1291207FAILED, illegal

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Marking testFakeNics as broken .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50580 To unsubscribe, visit

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

2015-12-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: fileVolume: define file extension for volume artifacts metadata .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

2015-12-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: fileVolume: refactor _putMetadata to support volume artifacts .. Patch Set 7: Ok. Moved code to VolumeArtifacts. -- To view, visit

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 3: * #1279052::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279052::OK, public bug * Check

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

2015-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Marking testFakeNics as broken .. Patch Set 3: Continuous-Integration+1 unrelated broken test 12:40:04 ERROR: testTogglePromisc (tcTests.TestQdisc)

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileVolume: define file extension for volume artifacts metadata .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py

Change in vdsm[master]: Introduce VolumeArtifacts

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: storage: add getHostId to DomainMonitor

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: constants: Define temporary volume indicators

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: constants: Define temporary volume indicators .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: add getHostId to DomainMonitor

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 6: Code-Review-1 Unanswered questions -- To view, visit https://gerrit.ovirt.org/50340 To unsubscribe, visit

Change in vdsm[master]: constants: Define temporary volume indicators

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: constants: Define temporary volume indicators .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/49544/7/vdsm/storage/constants.py File

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-12-17 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: VolumeMetadata: move validateDelete .. VolumeMetadata: move validateDelete Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2 Signed-off-by: Adam Litke

Change in vdsm[master]: sdm: add SDM.create_volume API stub

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: add SDM.create_volume API stub .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: XXX: All outstanding VolumeMetadata changes squashed .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Move VOLUME_PERMISSIONS to storage constants .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: sdm: Add create_volume job

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: XXX: Add _getDeletedImagePath until patch merged .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: constants: Define temporary volume indicators

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: constants: Define temporary volume indicators .. Patch Set 7: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/49544 To unsubscribe, visit

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Introduce VolumeArtifacts

2015-12-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 11: (14 comments) https://gerrit.ovirt.org/#/c/48097/11/vdsm/storage/sdm/volume_artifacts.py File

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 2: Adam, can you answer the questions in patchset 2?

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 3: We still don't have this build for qemu-kvm-ev. Sandro is working on it, and Daniel should be able to

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-12-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/50363 To unsubscribe, visit

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 13: * #1290997::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1290997::OK, public bug *

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 12: > (1 comment) > > Looks good, just minor issue in test name. Done -- To view, visit

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

2015-12-17 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package .. Patch Set 6: (1 comment) Sorry - i'd thought i had commented on this - but it was stuck in drafts!

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-12-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 26: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-12-17 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: VolumeMetadata: move newMetadata .. VolumeMetadata: move newMetadata Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764 Signed-off-by: Adam Litke

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-12-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 3: Sandro? -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit

  1   2   >