Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Improve logging when receiving signals
..
logging: Improve logging when receiving signals
Log INFO message when receiving signals, explaining
gerrit-hooks has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3:
(2 comments)
What we see in the patch look mostly ok, not sure if we need more changes in
other files.
Nir Soffer has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1:
Whos is approving this?
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sd: Remove unused variable and evil thread
..
sd: Remove unused variable and evil thread
If storage domain had a non-null start instance variable, we
Nir Soffer has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63636/2/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Draft for showing client address in rpc logs
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/61437
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 3: Code-Review+2
should have been gone with 75ddec022648ec1a01bc8185e3f7541f9e6dbf4f
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add mount.isMounted() timing tests
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has uploaded a new change for review.
Change subject: net test: test_ip_info - Wait for IP settingi with address
..
net test: test_ip_info - Wait for IP settingi with address
This is a second attempt to handle the
gerrit-hooks has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Code-Review+1
Looks ok, but need testing with 3.6.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net test: test_ip_info - Wait for IP settingi with address
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Edward Haas has uploaded a new change for review.
Change subject: build tests: Disable the builtin check target.
..
build tests: Disable the builtin check target.
There is no need to recursively check the tests/ folder for
gerrit-hooks has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: Proving that error_code job is useless
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61056
To
Nir Soffer has abandoned this change.
Change subject: build: Proving that error_code job is useless
..
Abandoned
Not needed now
--
To view, visit https://gerrit.ovirt.org/61056
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Jenkins CI has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited
Allon Mureinik has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3:
(2 comments)
Thanks for the review!
Regarding the general comment, the change at constants.py.in is
Edward Haas has uploaded a new change for review.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
util: NoIntrPoll - replace time() with monotonic_time()
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Jenkins CI has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited
Edward Haas has uploaded a new change for review.
Change subject: build net tests: Create a test target for networking tests.
..
build net tests: Create a test target for networking tests.
It is usefull to run only the
gerrit-hooks has posted comments on this change.
Change subject: tests: Run mount tests multiple times
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove unneeded freeloop=True usage
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove pointless force=True usage
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 2:
This is the 1st attempt: https://gerrit.ovirt.org/#/c/63516
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Disable special OVS handling for exteranal network
..
Patch Set 1: Code-Review-1
(1 comment)
Yaniv Bronhaim has posted comments on this change.
Change subject: lib: vdscli: switch to the new devel_warn helper
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: lib: logUtils: add devel_warn function
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
Line
Nir Soffer has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4: Continuous-Integration+1
CI failures not relevant.
--
To view, visit https://gerrit.ovirt.org/63521
To
Nir Soffer has restored this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Restored
Still needed
--
To view, visit https://gerrit.ovirt.org/40896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: vm: use the new response handling
..
Restored
Still needed
--
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 1: Code-Review+1
Looks fine, but please rebase on https://gerrit.ovirt.org/61261, that patch
must be merged before
gerrit-hooks has posted comments on this change.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Edward Haas has posted comments on this change.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit
Edward Haas has uploaded a new change for review.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
build tests: Require NOSE 1.3.7 and up for running tests
On RHEL7/Centos7 the provided NOSE version
gerrit-hooks has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/63636/2//COMMIT_MSG
Commit Message:
Line 19:
Nir Soffer has posted comments on this change.
Change subject: lib: vdscli: switch to the new devel_warn helper
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 2: Code-Review+1
We need to clean also testrunner.
--
To view, visit https://gerrit.ovirt.org/62212
To
Edward Haas has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit
Edward Haas has uploaded a new change for review.
Change subject: build: Allow tox to run all checkers in one shot.
..
build: Allow tox to run all checkers in one shot.
tox has been called for each checker (pep8, pyflakes),
gerrit-hooks has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Hello Nir Soffer, Ala Hino,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63634
to review the following change.
Change subject: Live Merge: Refresh base volume before live merge
..
Live Merge:
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Verified-1
* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK,
Nir Soffer has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63521/3//COMMIT_MSG
Commit Message:
Line 6:
Line 7: misc: Rename
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 2: Verified-1
Will upload another verified patch soon
--
To view, visit https://gerrit.ovirt.org/63547
To
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63636
to review the following change.
Change subject: storage: add more info to NFS SD getInfo
..
storage: add more info to NFS
gerrit-hooks has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 1:
* #1373930::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373930::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: lib: logUtils: add devel_warn function
..
Patch Set 2: Code-Review-1
(2 comments)
I think we should use the standard logging configuration.
- Add devel logger in
Nir Soffer has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/62208/2/lib/vdsm/storage/fileUtils.py
File
Roy Golan has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 1:
(1 comment)
- can this reveal secure info of some sort?
- Thinking on the client side, the engine should
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: fileUtils: drop redundant warning
..
Patch Set 2: Code-Review+1
We need to remove also the redundant warning in outOfProcess:
warn("Renaming a
gerrit-hooks has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 2:
* #1373930::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373930::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: api: use the new devel_warn helper
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/62210/2/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 44
Line 45
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3: Verified+1
Verified upgrade storage pool with NFS and iSCSI.
Version format in the metadata changed to 4
Freddy Rolland has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63521/3//COMMIT_MSG
Commit Message:
PS3, Line
Freddy Rolland has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63529
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sos: change getConnectedStoragePoolsList result key
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Freddy Rolland has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63523
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63522
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63526
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63525
To unsubscribe, visit https://gerrit.ovirt.org/settings
1 - 100 of 115 matches
Mail list logo