Dan Kenigsberg has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build tests: Disable the builtin check target.
..
build tests: Disable the builtin check target.
There is no need to recursively check the tests/
gerrit-hooks has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: Unify stoage logger name
..
storage: Unify stoage logger name
We had both "Storage" and "storage" loggers, but configuration was only
for
Nir Soffer has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4:
I agree with Dan, we don't expect to improve the current code, just remove the
usage of
gerrit-hooks has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Verified+1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61459/13//COMMIT_MSG
Commit Message:
Line 9: This patch:
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4: Code-Review-1
Thanks for this much needed cleanup.
At the very least, you can split
Dan Kenigsberg has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 1:
* #1374988::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374988::OK, public
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build net tests: Create a test target for networking tests.
..
build net tests: Create a test target for networking tests.
It is usefull to run only
Nir Soffer has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1:
ping?
--
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: introducting broken_on_ci decorator
..
tests: introducting broken_on_ci decorator
With this decorator we skip failed test only when it was
gerrit-hooks has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 2:
* #1374328::Update tracker: OK
* Set MODIFIED::bug 1374328#1374328IGNORE, not all related
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix testGetBondingOptions
..
tests: fix testGetBondingOptions
Bonding options are reported only if they differ from defaults.
Bond 'mode' is
gerrit-hooks has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 2:
* #1374328::Update tracker: OK
* Set MODIFIED::bug 1374328#1374328IGNORE, not all related patches are
Edward Haas has posted comments on this change.
Change subject: net: reconfigure bond detached from bridges
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File
Adam Litke has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line
Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:
Line 10: is no real reason to
Nir Soffer has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 2: Code-Review+1
Looks good, waiting for more reviews.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 7: Code-Review+1
Looks good, waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/62002/7/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 117
Line 118
Line 119
Line 120
Nir Soffer has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63711/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 2:
(2 comments)
Partial review
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Nir Soffer has posted comments on this change.
Change subject: mount: Remove unneeded freeloop=True usage
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mount: Remove pointless force=True usage
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 4:
(1 comment)
Please run "make pep8 pyflakes" before uploading patches.
Nir Soffer has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add missing test for deleted mounts
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56547
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for un-escaping spaces
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56549
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add mount.isMounted() timing tests
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56565
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove pointless force=True usage
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove unneeded freeloop=True usage
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Run mount tests multiple times
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 154
Line
gerrit-hooks has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 6:
Rebae and remove conflict introduced by the latest logging cleanup.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add mount.isMounted() timing tests
..
tests: Add mount.isMounted() timing tests
Add timing tests to understand how much time it takes to check
Nir Soffer has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: formatConverter: Use module logger
..
formatConverter: Use module logger
Make formatConverter to use module logger.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 5: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/63630/4/vdsm/storage/imageRepository/formatConverter.py
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Add mount.isMounted() timing tests
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4:
Sure, no problem Nir. I can split the patch and try to test all of it. I
Edward Haas has posted comments on this change.
Change subject: storage: fix disconnecting multiple iSCSI sessions
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55578/2//COMMIT_MSG
Commit Message:
PS2, Line 12:
Tomas Golembiovsky has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: api: use the new devel_warn helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62210/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Piotr Kliczewski has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63711/1/lib/vdsm/exception.py
File
gerrit-hooks has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: migration: introduce virt subloggers
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: migration: coalesce join() into stop()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: dhclient: shorten name of the thread
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: ifup: shorten name of the thread
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3:
Yes Nir, I really don't understand your concern, we remove here the status
field to avoid
Piotr Kliczewski has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63712/1/lib/vdsm/jobs.py
File
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 21:
(7 comments)
https://gerrit.ovirt.org/#/c/62831/22/lib/vdsm/network/link/setup.py
File
Edward Haas has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Piotr Kliczewski has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Freddy Rolland has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has abandoned this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Abandoned
squashed in already-merged patch
--
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61462
To
Freddy Rolland has posted comments on this change.
Change subject: mount: Fix un-escaping of spaces
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: mount: Simplify deleted suffix stripping
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit
Irit Goihman has uploaded a new change for review.
Change subject: sos: remove jsonrpcvdscli.connect parameters
..
sos: remove jsonrpcvdscli.connect parameters
patch https://gerrit.ovirt.org/#/c/62730/ added default value to
Piotr Kliczewski has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 4:
(1 comment)
What about fileUtils? There is warnings module used there as well.
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
gerrit-hooks has posted comments on this change.
Change subject: net: reconfigure bond detached from bridges
..
Patch Set 1:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: tests: bootstrap the livemerge tests
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Freddy Rolland has posted comments on this change.
Change subject: mount: Remove EL 6 /etc/mtab support
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: WIP vm: add utility to get sublogger
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/61992
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61992
To
gerrit-hooks has posted comments on this change.
Change subject: sos: remove jsonrpcvdscli.connect parameters
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Irit Goihman has posted comments on this change.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in
File
Irit Goihman has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 13: Verified+1
trivial patch, verified running vdsm for a short while. If deeper verification
is needed,
1 - 100 of 152 matches
Mail list logo
