gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 6:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Milan Zamazal has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 3: Verified+1
Just a documentation change, I checked build works. Jenkins test failures on
Fedora
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 2:
(1 comment)
Nice, needs more time to review the tests.
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2: Verified+1
(1 comment)
I verified that migration still works and that the
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
(5 comments)
Partial review.
https://gerrit.ovirt.org/#/c/64222/6/tests/qemuimg_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64468/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in
File vdsm.spec.in:
Line 187:
Nir Soffer has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 1:
Code cannot be simpler and more elegant, need time to review the tests.
--
To view, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 8:
Lets add the implementation of this first, and update the api only after we
have a working (maybe merged)
Nir Soffer has posted comments on this change.
Change subject: core: Introduce new Volume.getWatermarks verb
..
Patch Set 1:
Lets wait with the apis, we don't know yet if we can implement them.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 1:
(1 comment)
Partial review
Piotr Kliczewski has posted comments on this change.
Change subject: py3: remove capsTests from blacklist
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64363
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/64222/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 186:
Nir Soffer has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: tests: SDM.copy_data test for abort while copying
..
tests: SDM.copy_data test for abort while copying
When a copy operation is aborted the final job status
Adam Litke has uploaded a new change for review.
Change subject: Use Volume.operation in SDM.copy_data
..
Use Volume.operation in SDM.copy_data
Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Signed-off-by: Adam Litke
Adam Litke has uploaded a new change for review.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
tests: Remove TODO for SDM.copy_data abort before copy test
The abort before copy test is meant to
Francesco Romani has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 8:
(3 comments)
partial review
https://gerrit.ovirt.org/#/c/62873/8/vdsm.spec.in
File
Liron Aravot has abandoned this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.datapath_session
..
Patch Set 1:
(8 comments)
https://gerrit.ovirt.org/#/c/64362/1//COMMIT_MSG
Commit Message:
Line 17:
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.move_domain_device API
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Andrej Krejcir has uploaded a new change for review.
Change subject: Correct API schema to align with runtime schema
..
Correct API schema to align with runtime schema
Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Francesco Romani has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File
Liron Aravot has restored this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Restored
--
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 2:
* update_tracker: OK
--
To view, visit https://gerrit.ovirt.org/64433
To
Maor Lipchuk has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/64244/11/tests/sdm_indirection_tests.py
File
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 6:
I will add the desired tests in the next patchset
--
To view, visit https://gerrit.ovirt.org/64373
To
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 19:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 13:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: storage: Add support for generation id to VolumeMetadata
..
storage: Add support for generation id to VolumeMetadata
We would like to add support for a new
Adam Litke has uploaded a new change for review.
Change subject: storage: Validate generation id in volume.operation context
..
storage: Validate generation id in volume.operation context
When the optional requested_gen_id
Adam Litke has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64479/1/tests/storage_sdm_copy_data_test.py
File
Adam Litke has uploaded a new change for review.
Change subject: storage: Increment generation id when completing operation
..
storage: Increment generation id when completing operation
Before successful exit of a
Adam Litke has uploaded a new change for review.
Change subject: storage: Report generation id in volume.getInfo
..
storage: Report generation id in volume.getInfo
Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
gerrit-hooks has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Add support for generation id to VolumeMetadata
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: storage: Support generation id in sdm.copy_data
..
storage: Support generation id in sdm.copy_data
Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
gerrit-hooks has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Support generation id in sdm.copy_data
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 6:
I will add the desired tests in the next patchset
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 20:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367378::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
net: Fix reference to CONFFILE_HEADER_BASE which was moved
CONFFILE_HEADER_BASE has been
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64442
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64438
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64442
To unsubscribe,
Hello Petr Horáček, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64447
to review the following change.
Change subject: net test: shared nic between bond and network
..
net test:
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
Hello Petr Horáček, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64446
to review the following change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
gerrit-hooks has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - add refresh method to update bond config
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
*
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 17:
Found the issue, it is not related to a whitespace but a failing space, next
upload should be with
gerrit-hooks has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1022961::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64438
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 1: Verified+1
All unit and functional tests passed.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 10: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py
File
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 18:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 6:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
1 - 100 of 241 matches
Mail list logo