Nir Soffer has uploaded a new change for review.
Change subject: procwatch: Rename closed property to watching
..
procwatch: Rename closed property to watching
Closed is good term for a stream, but this class is not a stream.
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Specify stdin, stdout, and stderr
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Rename closed property to watching
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Rename closed property to watching
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59708/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1:
> This is "just" about polishing the code or you hit a bug caused by this?
I wanted to
Adam Litke has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2:
(2 comments)
-1 for visibility of comments.
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Don't crash in migration progress on compression bytes
..
virt: Don't crash in migration progress on compression bytes
If compression is not
Francesco Romani has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64186/2//COMMIT_MSG
Adam Litke has posted comments on this change.
Change subject: yml: return type fixes for Task.getStatus
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: net: Ignore missing graphics from VM conf on target host
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py
File
Adam Litke has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59702/2/lib/api/vdsm-api.yml
File
Adam Litke has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
..
Patch Set 2: Code-Review-1
-1 for visibility
--
To view, visit https://gerrit.ovirt.org/59701
Francesco Romani has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64186/2//COMMIT_MSG
gerrit-hooks has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 2:
* #1365640::Update tracker: OK
* Set MODIFIED::bug 1303550#1303550OK
--
To view, visit
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
spec: Require selinux-policy-targeted for CephFS
RHEL bug https://bugzilla.redhat.com/1365640
Francesco Romani has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Code-Review+2
it seems indeed the packages are available since quite some time.
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2: Code-Review-1
After discussions and looking at the code, I'm
Francesco Romani has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64186/2//COMMIT_MSG
gerrit-hooks has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 6:
* #1348255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1348255::OK, public bug
*
Francesco Romani has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64499
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 3:
* #64468::Update tracker: OK
* #1380822::Update tracker: OK
* #64499::Update
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Verified+1
Verified that with this change and "minimal downtime" migration policy
Adam Litke has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getSpmStatus
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65058
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4: Code-Review-1
I don't think we want to have plugins of plugins. What for? Why not build it
into
Nir Soffer has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65007/1/vdsm/virt/migration.py
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/65007/1/vdsm/virt/migration.py
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Use one package per line
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Use one package per line
..
dockerfile: Use one package per line
Having one package per line make it easier to add and remove packages
and review
Nir Soffer has uploaded a new change for review.
Change subject: travis: Fix build using new docker image
..
travis: Fix build using new docker image
- Use the new image built from updated dockerfile
- Remove unneeded true
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install developer tools using pip
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: net: Ignore missing graphics from VM conf on target host
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py
File
Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Add missing packages
..
dockerfile: Add missing packages
Add packages added recently as build requirement on master
(python-decorator, PyYaml,
Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Install developer tools using pip
..
dockerfile: Install developer tools using pip
- Remove python-nose which is too old on CentOS, and install
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has abandoned this change.
Change subject: tests: Run mount tests multiple times
..
Abandoned
Not needed now.
--
To view, visit https://gerrit.ovirt.org/56545
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Run mount tests multiple times
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/56545
To
Nir Soffer has posted comments on this change.
Change subject: resourcemanager: Use new module api
..
Patch Set 4: Continuous-Integration+1
Copied from previous version, no code change.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 4:
* #2::Update tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.reduceSize verb
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.getWatermarks verb
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: resourcemanager: Use new module api
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Get rid of getInstance
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Add module api
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: resourcemanager: Use new module api
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: cleanup: Remove dead code from storageServer.py
..
cleanup: Remove dead code from storageServer.py
While reviewing some schema fixes I noticed that we have a lot
gerrit-hooks has posted comments on this change.
Change subject: cleanup: Remove dead code from storageServer.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Add module api
..
Patch Set 4:
* #65034::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.reduceSize verb
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.getWatermarks verb
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 380:
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positinal args calling convention
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 2:
* #2::Update tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Make ResourceMananger private
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Make ResourceMananger private
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Get rid of getInstance
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: service: Add vdsm-tool-configure service
..
Patch Set 3:
* #1373389::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/64904
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65040
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Add module api
..
Patch Set 3: Continuous-Integration+1
Copied from previous version, no code change.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has submitted this change and it was merged.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
yml: parameter type fixes for StoragePool.spmStart
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
1 - 100 of 225 matches
Mail list logo