gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: mas
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
Patch Set 5:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
virt: Minor typo fixes in Vm.getStats docstring
Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Edward Haas has posted comments on this change.
Change subject: build: Run the tests with tox
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit https://gerrit.ovirt.org/settin
Edward Haas has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2: Code-Review+1
Ah, I got confused between py3 (only) code and py2 code compatible with py3.
--
To vie
Edward Haas has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 6: Code-Review+1
We need to run functional tests on this.
--
To view, visit https://gerrit.ovirt.org
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65452
to review the following change.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoade
gerrit-hooks has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1:
* Update Tracker::#1381899::OK, status: POST
* Check Bug-Url::OK
* Check Public Bug::#1381899::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/9/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_d
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Fix abort semantics
..
jobs: Fix abort semantics
Prior to this commit jobs.abort was treated as an synchronous operation
and if it returned successfu
Nir Soffer has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65452
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 24:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Pu
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 26:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Pu
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 36:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 47:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: m
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 54:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+2
as part of verification, please make sure yaml.Cloader is available by default
(e.g. we don't need
gerrit-hooks has posted comments on this change.
Change subject: WIP: docs: add tutorial
..
Patch Set 3:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 20:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: mast
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 21:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Continuous-Integration+1
run CI tests locally.
--
To view, visit https://gerrit.ovirt.org/65452
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1:
discard my last comment. I assume this check has already been done.
--
To view, visit https://gerrit.ovirt.org/
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Verified+1
trivial change, same code as master and ovirt-4.0
--
To view, visit https://gerrit.ovirt.org/65452
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: static: move vdsm bonding defaults under static
..
static: move vdsm bonding defaults under static
Part of the move of static files to new directory. T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: static: move man under static
..
static: move man under static
Part of the move of static files to new directory. The files are
moved to corresponding
gerrit-hooks has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 2:
* Update Tracker::#1381899::OK, status: MERGED
* Set MODIFIED::bug 1381899#1381899IGNORE, not all related pat
Dan Kenigsberg has submitted this change and it was merged.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 27:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Pu
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 25:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Pu
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 55:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 21:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: mast
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 48:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: m
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 22:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 34:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 37:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch:
gerrit-hooks has posted comments on this change.
Change subject: WIP: docs: add tutorial
..
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::
gerrit-hooks has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 5:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
*
gerrit-hooks has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 2:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check
Francesco Romani has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 2: Verified+1
if jenkins is happy, so we are
--
To view, visit https://gerrit.ovirt.org/65417
To unsubscri
Francesco Romani has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 1:
thanks, silly mistake. Should be fixed now.
--
To view, visit https://gerrit.ovirt.org/65417
To unsubsc
Nir Soffer has uploaded a new change for review.
Change subject: virt.vmdevices.core: Add Lease device
..
virt.vmdevices.core: Add Lease device
Previously virt.vmdevices.storage.Drive was creating lease device xml
for a drive. W
gerrit-hooks has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 1:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Chec
Nir Soffer has submitted this change and it was merged.
Change subject: tests: use assertXMLEqual in vmTests
..
tests: use assertXMLEqual in vmTests
switch to assertXMLEqual to have better error messages.
Change-Id: I651640454
gerrit-hooks has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 2:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Chec
Nir Soffer has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65417
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: tests: use assertXMLEqual in vmTests
..
Patch Set 3:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
gerrit-hooks has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 3:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Chec
gerrit-hooks has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Chec
Milan Zamazal has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 4:
Looks fine to me so far.
--
To view, visit https://gerrit.ovirt.org/65465
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 11:
* Update Tracker::#1354343::OK, status: POST
* Check Bug-Url::IGNORE, not relevant for branch: mast
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 11:
We are now more careful with POSTCOPY migration flag.
--
To view, visit https://gerrit.ovirt.org
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Destroy VM after post-copy migration failure
..
virt: Destroy VM after post-copy migration failure
As explained in the source code comment, we don't have
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
virt: Start all VM related stuff after switching to post-copy migration
On the migra
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
virt: Fetch only minimum VM stats during post-copy migration
When a migration switches to post-c
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
virt: Distinguish between switching to and entering post-copy migration
Switching to
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Report paused VM status in post-copy
..
virt: Report paused VM status in post-copy
When a migration enters a post-copy mode, it gets paused. While we are
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
virt: Prevent monitoring of VMs in post-copy
Migrating VMs in post-copy mode on the source end are paused. It m
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Stop guest agent before switching to post-copy
..
virt: Stop guest agent before switching to post-copy
Post-copy migration pauses the VM on the source. W
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Inform Engine about switching to post-copy
..
virt: Inform Engine about switching to post-copy
Engine must be informed when a migration switches to post-c
Dan Kenigsberg has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65058
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: fix ovs_test:test_dry_run
..
net test: fix ovs_test:test_dry_run
The test was using NetsAdditionSetup.add() as a standard function
although i
gerrit-hooks has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 2:
* Update Tracker::#1379115::OK, status: MERGED
* Set MODIFIED::bug 1379115#1379115::IGNORE, skipping for b
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
net tests: separate ifcfg and libvirt unit tests
Change-Id: Ieca34a3f361586346d76ec22b11554c4a7c6e8
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: minor libvirt_tests style refactoring
..
net tests: minor libvirt_tests style refactoring
Change-Id: I64dedb9859d204082a1516574e9b8650a3e4ff
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 7:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
71 matches
Mail list logo