Change in vdsm[master]: vdsm: log proper tag for messages coming from vdsm-logrotate

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: log proper tag for messages coming from vdsm-logrotate .. Patch Set 2: Code-Review+1 I also can assist. acked

Change in vdsm[master]: API: explicit log around createVm

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: explicit log around createVm .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/66417 To

Change in vdsm[master]: API: explicit log around createVm

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: explicit log around createVm .. Patch Set 5: I can live with this - since getting this logged by default is

Change in vdsm[master]: virt: drop remains of vm-level nicModel

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: virt: drop remains of vm-level nicModel .. virt: drop remains of vm-level nicModel Commit c264b600 has dropped the

Change in vdsm[master]: rpc: dynamic declaration of the api

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpc: dynamic declaration of the api .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/66982/3//COMMIT_MSG

Change in vdsm[master]: virt: enable migration hook only when asked to

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: enable migration hook only when asked to .. Patch Set 5: Code-Review+2 -- To view, visit

Change in vdsm[master]: sos: migrate to new jsonrpc client

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: migrate to new jsonrpc client .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/66940

Change in vdsm[master]: tests: containers: add testsuite

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: containers: add testsuite .. tests: containers: add testsuite Change-Id:

Change in vdsm[master]: vdsm: daemon: ensure the container state dir exists

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: daemon: ensure the container state dir exists .. vdsm: daemon: ensure the container state dir exists

Change in vdsm[master]: build: create the container rpm only if requested

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: build: create the container rpm only if requested .. build: create the container rpm only if requested We

Change in vdsm[master]: vdsm: daemon: ensure the container state dir exists

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm: daemon: ensure the container state dir exists .. Patch Set 12: Continuous-Integration+1 unrelated environment

Change in vdsm[master]: API: move vmParams validation in a method

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: move vmParams validation in a method .. Patch Set 5: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-3.6]: protocoldetector: Handle socket.error in handle_accept

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: protocoldetector: Handle socket.error in handle_accept .. Patch Set 2: Continuous-Integration+1 errors are not

Change in vdsm[ovirt-3.6]: protocoldetector: Handle socket.error in handle_accept

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: protocoldetector: Handle socket.error in handle_accept .. protocoldetector: Handle socket.error in

Change in vdsm[master]: arm: handle cpuinfo

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: arm: handle cpuinfo .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66326 To unsubscribe,

Change in vdsm[master]: tests: add tests for API.VM.create()

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: add tests for API.VM.create() .. Patch Set 3: Code-Review-1 (3 comments)

Change in vdsm[master]: API: move vm parameters fixup in a method

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: move vm parameters fixup in a method .. Patch Set 5: Code-Review+2 -- To view, visit

Change in vdsm[master]: client: add default value for port parameter

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: client: add default value for port parameter .. Patch Set 5: Code-Review+1 -- To view, visit

Change in vdsm[master]: arm: add aarch64 as supported arch

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: arm: add aarch64 as supported arch .. Patch Set 1: Code-Review+2 I can live with the short commit message -- To

Change in vdsm[master]: arm: add aarch64 as supported arch

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: arm: add aarch64 as supported arch .. arm: add aarch64 as supported arch Change-Id:

Change in vdsm[master]: API: pack params fixup together

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: pack params fixup together .. Patch Set 4: Code-Review+2 don't mind -- To view, visit

Change in vdsm[master]: stomp: reroute messages to different process

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: reroute messages to different process .. Patch Set 5: (1 comment)

Change in vdsm[ovirt-4.0]: protocoldetector: Handle socket.error in handle_accept

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: protocoldetector: Handle socket.error in handle_accept .. Patch Set 2: Code-Review+2 -- To view, visit

Change in vdsm[master]: API: get hibernation params in a submethod

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: get hibernation params in a submethod .. Patch Set 5: Code-Review+2 -- To view, visit

Change in vdsm[master]: core: containers: add the container support module

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: core: containers: add the container support module .. core: containers: add the container support module Add

Change in vdsm[ovirt-3.6]: protocoldetector: Handle socket.error in handle_accept

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: protocoldetector: Handle socket.error in handle_accept .. Patch Set 2: Code-Review+2 -- To view, visit

Change in vdsm[master]: domain_descriptor: correctly check if element is present

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: domain_descriptor: correctly check if element is present .. domain_descriptor: correctly check if element is

Change in vdsm[master]: API: use exceptions in the VM.create flow

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: use exceptions in the VM.create flow .. Patch Set 4: Code-Review+2 -- To view, visit

Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Distinguish between switching to and entering post-copy migration .. virt: Distinguish between

Change in vdsm[master]: virt: Stop guest agent before switching to post-copy

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Stop guest agent before switching to post-copy .. virt: Stop guest agent before switching to post-copy

Change in vdsm[master]: virt: Log post-copy migration cancellation failure

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Log post-copy migration cancellation failure .. virt: Log post-copy migration cancellation failure A

Change in vdsm[master]: virt: Report paused VM status in post-copy

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Report paused VM status in post-copy .. virt: Report paused VM status in post-copy When a migration

Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Use a variable for self._vm in MonitorThread action handling .. virt: Use a variable for self._vm in

Change in vdsm[master]: virt: Move migration.py to lib/vdsm/

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move migration.py to lib/vdsm/ .. virt: Move migration.py to lib/vdsm/ We need this change for a

Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Start all VM related stuff after switching to post-copy migration .. virt: Start all VM related stuff

Change in vdsm[master]: virt: Fetch only minimum VM stats during post-copy migration

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Fetch only minimum VM stats during post-copy migration .. virt: Fetch only minimum VM stats during

Change in vdsm[master]: virt: Prevent monitoring of VMs in post-copy

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Prevent monitoring of VMs in post-copy .. virt: Prevent monitoring of VMs in post-copy Migrating VMs

Change in vdsm[master]: virt: Cleanup of _waitForUnderlyingMigration call

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Cleanup of _waitForUnderlyingMigration call .. virt: Cleanup of _waitForUnderlyingMigration call We

Change in vdsm[master]: virt: Report downtime after a post-copy migration

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Report downtime after a post-copy migration .. virt: Report downtime after a post-copy migration There

Change in vdsm[master]: virt: Inform Engine about switching to post-copy

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Inform Engine about switching to post-copy .. virt: Inform Engine about switching to post-copy Engine

Change in vdsm[master]: virt: Send migration status events

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Send migration status events .. virt: Send migration status events Migration progress is currently

Change in vdsm[master]: virt: Initial support for post-copy migration

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Initial support for post-copy migration .. virt: Initial support for post-copy migration This patch

Change in vdsm[master]: shell_helper: allow nondefault rpmdir

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: shell_helper: allow nondefault rpmdir .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/67191 To

Change in vdsm[master]: remove unused graphics property disableTicketing

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: remove unused graphics property disableTicketing .. remove unused graphics property disableTicketing This

Change in vdsm[master]: shell_helper: allow nondefault rpmdir

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: shell_helper: allow nondefault rpmdir .. shell_helper: allow nondefault rpmdir Change-Id:

Change in vdsm[master]: stomp: Introducing redirect in stomp protocol header

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: Introducing redirect in stomp protocol header .. Patch Set 6: Code-Review+1 -- To view, visit

Change in vdsm[master]: virt: drop remains of vm-level nicModel

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: drop remains of vm-level nicModel .. Patch Set 1: Piotr, as far as I understand the Engine code, all 3 sited

Change in vdsm[master]: Configure mom restart rules

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Configure mom restart rules .. Patch Set 3: Code-Review+1 Sounds ok if verified properly both over f24 and centos7

Change in vdsm[ovirt-4.0]: protocoldetector: Handle socket.error in handle_accept

2016-11-22 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: protocoldetector: Handle socket.error in handle_accept .. protocoldetector: Handle socket.error in

Change in vdsm[master]: arm: handle cpuinfo

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: arm: handle cpuinfo .. arm: handle cpuinfo Change-Id: I290ff95f110edb4cca9eaf8dbd0e06f631c55ed7

Change in vdsm[master]: arm: add to faqemu

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: arm: add to faqemu .. arm: add to faqemu Change-Id: I0512395df7462937143681b70d67ed35a6db83f6 Signed-off-by:

Change in vdsm[master]: virt: enable migration hook only when asked to

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: enable migration hook only when asked to .. virt: enable migration hook only when asked to OVS is not

Change in vdsm[master]: virt: enable migration hook only when asked to

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: enable migration hook only when asked to .. Patch Set 5: Verified+1 legacy-legacy migration still works -- To

Change in vdsm[master]: build: create the container rpm only if requested

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: create the container rpm only if requested .. Patch Set 13: Continuous-Integration+1 unrelated failure, I

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: sos: replace dumpStorageTable with dump_volume_chains .. sos: replace dumpStorageTable with

Change in vdsm[master]: sos: migrate to new jsonrpc client

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: sos: migrate to new jsonrpc client .. sos: migrate to new jsonrpc client remove jsonrpcvdscli commands and

Change in vdsm[master]: client: add default value for port parameter

2016-11-22 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: client: add default value for port parameter .. client: add default value for port parameter most of the