Change in vdsm[master]: RPC: Add missing return statement when handling messages

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement when handling messages .. Patch Set 13: Code-Review+1 ready for merge -- To view, visit https://gerri

Change in vdsm[master]: RPC: Add missing return statement

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement .. Patch Set 13: ready for merge -- To view, visit https://gerrit.ovirt.org/79328 To unsubscribe, vis

Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: JsonRpcClient supports multiple subscriptions .. Patch Set 51: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78656 To un

Change in vdsm[master]: RPC: Add some unit tests for JsonRpcClient

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add some unit tests for JsonRpcClient .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/80048/2//COMMIT_MSG Co

Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 46: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/7

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/79694/10/tests/common/cmdutils_test.py

Change in vdsm[master]: move hooks to common

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/79695/12/lib/vdsm/common/hook/hooking.py File lib/vdsm/co

Change in vdsm[master]: tool: list/clear networks configured by VDSM

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool: list/clear networks configured by VDSM .. Patch Set 7: Eddy, what's the remaining problem? Why did you not grant +2? -- To view,

Change in vdsm[master]: net build: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net build: Unify module collection on the network dir .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80014 To

Change in vdsm[master]: net build: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80014 ) Change subject: net build: Unify module collection on the network dir .. net build: Unify module collection o

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/80177 ) Change subject: Revert "net build: Unify module collection on the network dir" .. Uploaded patch set 1. -- To view, visit https

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Hello Jenkins CI, gerrit-hooks, Petr Horáček, Leon Goldberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/80177 to review the following change. Change subject: Revert "net build: Unify module collection on the network dir"

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "net build: Unify module collection on the network dir" .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80177 ) Change subject: Revert "net build: Unify module collection on the network dir" .. Revert "net build: Unify mo

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "net build: Unify module collection on the network dir" .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit

Change in vdsm[master]: net build, take 2: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Hello Jenkins CI, gerrit-hooks, Petr Horáček, Leon Goldberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/80178 to review the following change. Change subject: net build, take 2: Unify module collection on the network dir

Change in vdsm[master]: net build, take 2: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/80178 ) Change subject: net build, take 2: Unify module collection on the network dir .. Uploaded patch set 1. -- To view, visit https

Change in vdsm[master]: net: Enable LLDP on NICs

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79824 ) Change subject: net: Enable LLDP on NICs .. net: Enable LLDP on NICs lldpad has to be configured to provide

Change in vdsm[master]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78117 ) Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. net: Introduce the LLDPAD driver w

Change in vdsm[master]: net: Report lldp through new getLldp command

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79093 ) Change subject: net: Report lldp through new getLldp command .. net: Report lldp through new getLldp command

Change in vdsm[master]: net: Add info lldp to lldp

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79405 ) Change subject: net: Add info lldp to lldp .. net: Add info lldp to lldp lldp is extended to provide informa

Change in vdsm[master]: net: Raise a meaningful exception for multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Raise a meaningful exception for multiple sb nics .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79625 To

Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Allow QoS caps to ignore nets with multiple sb nics .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79621

Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79621 ) Change subject: net: Allow QoS caps to ignore nets with multiple sb nics .. net: Allow QoS caps to ignore net

Change in vdsm[master]: net: Raise a meaningful exception for multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79625 ) Change subject: net: Raise a meaningful exception for multiple sb nics .. net: Raise a meaningful exception f