Change in vdsm[master]: BZ#811807 Enable network filtering
Igor Lvovsky has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#811807 Enable network filtering .. BZ#811807 Enable network filtering The VM network interface might receive a rule/filter to control the VM traffic by using libvirt network filtering. A vnic might get a single filter. In order to provide a filter which isn't delivered by libvirt, a custom filter should be defined. Once the filter is defined, its name could be used by the vnic to control its traffic. Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Signed-off-by: Moti Asayag masa...@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Moti Asayag has posted comments on this change.
Change subject: BZ#811807 Enable network filtering
..
Patch Set 2: (1 inline comment)
File vdsm/libvirtvm.py
Line 963: if hasattr(self, 'filters'):
Line 964: for filterName in self.filters:
Line 965: m = doc.createElement('filterref')
Line 966: m.setAttribute('filter', filterName)
Line 967: iface.appendChild(m)
Indeed. The thought was to support list of filters per vnic in the API between
engine-vdsm in order not to change this api in the future if libvirt will
support
multiple filters.
Since the entire patch-set series (except this one) relies on a single filter
per nic, I'll modify engine-VDSM to support a single filter per vnic.
Line 968: if hasattr(self, 'bootOrder'):
Line 969: bootOrder = doc.createElement('boot')
Line 970: bootOrder.setAttribute('order', self.bootOrder)
Line 971: iface.appendChild(bootOrder)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/567/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Dan Kenigsberg has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Moti Asayag has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Moti Asayag has uploaded a new change for review.
Change subject: BZ#811807 Enable network filtering
..
BZ#811807 Enable network filtering
The VM network ineterface might recieve a list of rules to control the
VM traffic by using libvirt network filtering.
Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Signed-off-by: Moti Asayag masa...@redhat.com
---
M vdsm/libvirtvm.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/7353/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 3b7cfc5..35da707 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -945,6 +945,7 @@
mac address=aa:bb:dd:dd:aa:bb/
model type=virtio/
source bridge=engine/
+[filterref filter='filter name'/]
[tunesndbuf0/sndbuf/tune]
/interface
@@ -959,6 +960,12 @@
m = doc.createElement('source')
m.setAttribute('bridge', self.network)
iface.appendChild(m)
+if hasattr(self, 'filters'):
+filters = getattr(self, 'filters')
+for filterName in filters:
+m = doc.createElement('filterref')
+m.setAttribute('filter', filterName)
+iface.appendChild(m)
if hasattr(self, 'bootOrder'):
bootOrder = doc.createElement('boot')
bootOrder.setAttribute('order', self.bootOrder)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Igor Lvovsky has posted comments on this change.
Change subject: BZ#811807 Enable network filtering
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
File vdsm/libvirtvm.py
Line 960: m = doc.createElement('source')
Line 961: m.setAttribute('bridge', self.network)
Line 962: iface.appendChild(m)
Line 963: if hasattr(self, 'filters'):
Line 964: filters = getattr(self, 'filters')
you don't need it.
If hasattr return True, you can use simple
self.filters
Line 965: for filterName in filters:
Line 966: m = doc.createElement('filterref')
Line 967: m.setAttribute('filter', filterName)
Line 968: iface.appendChild(m)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Moti Asayag has posted comments on this change.
Change subject: BZ#811807 Enable network filtering
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line 960: m = doc.createElement('source')
Line 961: m.setAttribute('bridge', self.network)
Line 962: iface.appendChild(m)
Line 963: if hasattr(self, 'filters'):
Line 964: filters = getattr(self, 'filters')
Done
Line 965: for filterName in filters:
Line 966: m = doc.createElement('filterref')
Line 967: m.setAttribute('filter', filterName)
Line 968: iface.appendChild(m)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#811807 Enable network filtering
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
File vdsm/libvirtvm.py
Line 963: if hasattr(self, 'filters'):
Line 964: for filterName in self.filters:
Line 965: m = doc.createElement('filterref')
Line 966: m.setAttribute('filter', filterName)
Line 967: iface.appendChild(m)
I'm pretty sure we've seen that libvirt (currently?) supports only one
filterref per nic, so at the moment the api is misleading.
Either change the API to accept only one, or open an RFE for libvirt to support
more. Either way, this issue should be documented in the commit message.
PS I am not sure what would the semantics of multiple filterrefs be - OR? AND?
Priority? I'm not sure it is going to fly so easily.
Line 968: if hasattr(self, 'bootOrder'):
Line 969: bootOrder = doc.createElement('boot')
Line 970: bootOrder.setAttribute('order', self.bootOrder)
Line 971: iface.appendChild(bootOrder)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#811807 Enable network filtering
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#811807 Enable network filtering .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
