Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-09-18 12:08:32 +0300
Line 4: Commit: Maor Lipchuk 
Line 5: CommitDate: 2016-09-18 13:47:09 +0300
Line 6: 
Line 7: formatConverter: Adding comment for format converter class.
Add moulde docstring
Line 8: 
Line 9: Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread mlipchuk 
Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread mlipchuk 
Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 366: # a 4.1 Data Center should be supported only with V4 storage domains.
Line 367: #
Line 368: # Version 4 should eventualy reflect support for old and new
Line 369: # qcow formats, 0.10 and 1.1.
Line 370: #
> We need a module docstring - just bellow the copyright notice.
Done
Line 371: class FormatConverter(object):
Line 372: def __init__(self, conversionTable):
Line 373: self._convTable = conversionTable
Line 374: 


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 366: # a 4.1 Data Center should be supported only with V4 storage domains.
Line 367: #
Line 368: # Version 4 should eventualy reflect support for old and new
Line 369: # qcow formats, 0.10 and 1.1.
Line 370: #
We need a module docstring - just bellow the copyright notice.

Please use this format:

"""
module name - short description

Few lines about this module...

Supported storage formats - don't waste time on formats 0, 2, and 3.

How format 4 is different from older formats...
"""
Line 371: class FormatConverter(object):
Line 372: def __init__(self, conversionTable):
Line 373: self._convTable = conversionTable
Line 374: 


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

2016-09-18 Thread mlipchuk 
Maor Lipchuk has uploaded a new change for review.

Change subject: formatConverter: Adding comment for format converter class.
..

formatConverter: Adding comment for format converter class.

Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/64098/1

diff --git a/vdsm/storage/imageRepository/formatConverter.py 
b/vdsm/storage/imageRepository/formatConverter.py
index 6d4c319..80741a0 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -356,6 +356,18 @@
 }
 
 
+# The format converter is responsible for the storage domains'
+# version maintenancy.
+#
+# A storage domain's version reflects its meta data compatibility,
+# for example, data storage domain should be supported for version 3 and 4.
+#
+# The FormatConverter is mainly being used on upgrade process, for example
+# a 4.1 Data Center should be supported only with V4 storage domains.
+#
+# Version 4 should eventualy reflect support for old and new
+# qcow formats, 0.10 and 1.1.
+#
 class FormatConverter(object):
 def __init__(self, conversionTable):
 self._convTable = conversionTable


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org