Change in vdsm[master]: ngn: provide release according with os-release

2017-02-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 2: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ngn: provide release according with os-release

2017-02-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/72829/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 82: NORMAL = 0
Line 83: HIGH = 19
Line 84: 
Line 85: 
Line 86: def isNextGenNode():
is there any need to place it outside of osversion module?

I prefer to keep things private, unless they are universally needed.

please use pep8-compliate function_names for new functions.
Line 87: """
Line 88: Return:
Line 89: True if it's oVirt Node Next or RHV Node
Line 90: """


-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ngn: provide release according with os-release

2017-02-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/72829/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: ngn: provide release according with os-release
Line 8: 
Line 9: Previously in ngn nodes we grab the release based on rpm.
Line 10: Now, we will provide release field to engine from /etc/os-release
please add a bz#
Line 11: 
Line 12: Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a


-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org