Change in vdsm[master]: v2v: Support for ova exported from AWS
Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: Support for ova exported from AWS .. v2v: Support for ova exported from AWS When exporting VM from AWS as VMWare OVA file it doesn't export tag for the VM. The Name is not Mandatory for the ovf format - using ova filename instead. Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Bug-Url: https://bugzilla.redhat.com/1371843 Signed-off-by: Shahar Havivi Reviewed-on: https://gerrit.ovirt.org/63517 Tested-by: Shahar Havivi Reviewed-by: Tomas Golembiovsky Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M lib/vdsm/v2v.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Tomas Golembiovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
gerrit-hooks has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 4: * #1371843::Update tracker: OK * Set MODIFIED::bug 1371843#1371843::IGNORE, skipping for branch 'master' -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Francesco Romani has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Francesco Romani has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3:
CI failure not relevant:
DEBUG util.py:421:
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/ed17eec77fadea996cb650b9acc2e7634d69860a4e6b82196acfaca4958fabdb-primary.sqlite.xz:
[Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:421: Trying other mirror.
DEBUG util.py:421: One of the configured repositories failed ("Custom epel"),
DEBUG util.py:421: and yum doesn't have enough cached data to continue. At
this point the only
DEBUG util.py:421: safe thing yum can do is fail. There are a few ways to
work "fix" this:
DEBUG util.py:421: 1. Contact the upstream for the repository and get
them to fix the problem.
DEBUG util.py:421: 2. Reconfigure the baseurl/etc. for the repository, to
point to a working
DEBUG util.py:421: upstream. This is most often useful if you are
using a newer
DEBUG util.py:421: distribution release than is supported by the
repository (and the
DEBUG util.py:421: packages for the previous distribution release
still work).
DEBUG util.py:421: 3. Disable the repository, so yum won't use it by
default. Yum will then
DEBUG util.py:421: just ignore the repository until you permanently
enable it again or use
DEBUG util.py:421: --enablerepo for temporary usage:
DEBUG util.py:421: yum-config-manager --disable epel
DEBUG util.py:421: 4. Configure the failing repository to be skipped, if
it is unavailable.
DEBUG util.py:421: Note that yum will try to contact the repo. when it
runs most commands,
DEBUG util.py:421: so will have to try and fail each time (and thus.
yum will be be much
DEBUG util.py:421: slower). If it is a very temporary problem though,
this is often a nice
DEBUG util.py:421: compromise:
DEBUG util.py:421: yum-config-manager --save
--setopt=epel.skip_if_unavailable=true
DEBUG util.py:421: failure:
repodata/ed17eec77fadea996cb650b9acc2e7634d69860a4e6b82196acfaca4958fabdb-primary.sqlite.xz
from epel: [Errno 256] No more mirrors to try.
DEBUG util.py:421:
http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/ed17eec77fadea996cb650b9acc2e7634d69860a4e6b82196acfaca4958fabdb-primary.sqlite.xz:
[Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:546: Child return code was: 1
DEBUG util.py:180: kill orphans
Let's retrigger
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Francesco Romani has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188: if vmName is not None:
Line 1189: vm['vmName'] = vmName.text
Line 1190: else:
Line 1191: vm['vmName'] =
os.path.splitext(os.path.basename(ova_path))[0]
> IMO it's safe.
OK, we do almost like the same thing above in the flow, ao this is not worse.
Line 1192:
Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194: 'rasd:VirtualQuantity' %
_OVF_RESOURCE_MEMORY, ns)
Line 1195: if memSize is not None:
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188: if vmName is not None:
Line 1189: vm['vmName'] = vmName.text
Line 1190: else:
Line 1191: vm['vmName'] =
os.path.splitext(os.path.basename(ova_path))[0]
> nice idea. This could not raise, right?
IMO it's safe.
Line 1192:
Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194: 'rasd:VirtualQuantity' %
_OVF_RESOURCE_MEMORY, ns)
Line 1195: if memSize is not None:
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3:
> (1 comment)
no, it works without extension as well:
print os.path.splitext(os.path.basename("/a/b/c"))[0]
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Francesco Romani has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63517/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188: if vmName is not None:
Line 1189: vm['vmName'] = vmName.text
Line 1190: else:
Line 1191: vm['vmName'] =
os.path.splitext(os.path.basename(ova_path))[0]
nice idea. This could not raise, right?
Line 1192:
Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194: 'rasd:VirtualQuantity' %
_OVF_RESOURCE_MEMORY, ns)
Line 1195: if memSize is not None:
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
gerrit-hooks has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: * #1371843::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371843::OK, public bug * Check Product::#1371843::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188: if vmName is not None:
Line 1189: vm['vmName'] = vmName.text
Line 1190: else:
Line 1191: vm['vmName'] = 'default'
> perhaps the id? vm-id?
we don't have an id...
we can use the ova file name as a name...
Line 1192:
Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194: 'rasd:VirtualQuantity' %
_OVF_RESOURCE_MEMORY, ns)
Line 1195: if memSize is not None:
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Francesco Romani has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 1187: vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188: if vmName is not None:
Line 1189: vm['vmName'] = vmName.text
Line 1190: else:
Line 1191: vm['vmName'] = 'default'
perhaps the id? vm-id?
not sure if this is better or not, so your call, I'm fine anyway. It's just
that it may be confusing to see a bunch of VMs each named 'default'
Line 1192:
Line 1193: memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194: 'rasd:VirtualQuantity' %
_OVF_RESOURCE_MEMORY, ns)
Line 1195: if memSize is not None:
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
gerrit-hooks has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 2: * #1371843::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371843::OK, public bug * Check Product::#1371843::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63517/1//COMMIT_MSG Commit Message: Line 8: Line 9: When exporting VM from AWS as VMWare OVA file it doesn't export Line 10: tag for the VM. Line 11: The Name is not Mandatory for the ovf format - using default as a name Line 12: AWS the name tag is not mandatory - using default as a name. > This line seems superfluous or the wording of the sentence is confusing. right it is Line 13: Line 14: The Name is not relevant from the engine point of view since the user Line 15: can change it while importing the OVA. Line 16: -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63517/1//COMMIT_MSG Commit Message: Line 8: Line 9: When exporting VM from AWS as VMWare OVA file it doesn't export Line 10: tag for the VM. Line 11: The Name is not Mandatory for the ovf format - using default as a name Line 12: AWS the name tag is not mandatory - using default as a name. This line seems superfluous or the wording of the sentence is confusing. Line 13: Line 14: The Name is not relevant from the engine point of view since the user Line 15: can change it while importing the OVA. Line 16: -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
gerrit-hooks has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 1: * #1371843::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371843::OK, public bug * Check Product::#1371843::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Support for ova exported from AWS
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: Support for ova exported from AWS
..
v2v: Support for ova exported from AWS
When exporting VM from AWS as VMWare OVA file it doesn't export
tag for the VM.
The Name is not Mandatory for the ovf format - using default as a name
AWS the name tag is not mandatory - using default as a name.
The Name is not relevant from the engine point of view since the user
can change it while importing the OVA.
Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Bug-Url: https://bugzilla.redhat.com/1371843
Signed-off-by: Shahar Havivi
---
M lib/vdsm/v2v.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/63517/1
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index 4c052da..b6453fc 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -1188,7 +1188,7 @@
if vmName is not None:
vm['vmName'] = vmName.text
else:
-raise V2VError('Error parsing ovf information: no ovf:Name')
+vm['vmName'] = 'default'
memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
'rasd:VirtualQuantity' % _OVF_RESOURCE_MEMORY, ns)
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
