Change in vdsm[master]: v2v: add try/except to get_external_vms

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: v2v: add try/except to get_external_vms
..


v2v: add try/except to get_external_vms

Single domain error causes get_external_vms to fail.

Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/49507
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Tested-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 6:

looks good, please verify

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 5: Code-Review+1

(1 comment)

+1 and not +2 because of a question. Looks good to me, however.

https://gerrit.ovirt.org/#/c/49507/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 165: continue
Line 166: try:
Line 167: root = ET.fromstring(xml)
Line 168: except ET.ParseError as e:
Line 169: logging.error('error parsing domain xml')
do you want to use exception here? Your call, I'm fine both ways
Line 170: continue
Line 171: try:
Line 172: _add_general_info(root, params)
Line 173: except InvalidVMConfiguration as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.error("error getting domain infomation: %s", 
e)
> Maybe adding vm.name() to the log message could be useful?
The vm.name() can be the exception.
usually the libvirt exception logs the domain id
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.error("error getting domain infomation: %s", 
e)
> typo: should be infoRmation.
Done
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


Line 165: continue
Line 166: try:
Line 167: root = ET.fromstring(xml)
Line 168: except ET.ParseError as e:
Line 169: logging.error('error parsing domain xml: %s', e)
> same as my previous comment about exception()
Done
Line 170: continue
Line 171: try:
Line 172: _add_general_info(root, params)
Line 173: except InvalidVMConfiguration as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Code-Review-1

(1 comment)

thanks, almost there, but exception() is not yet used correctly.

https://gerrit.ovirt.org/#/c/49507/4/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.exception("error getting domain information: 
%s", e)
if we use exception, we don't need to explictely log the exception object, it 
is done automatically by the method.
So, we can just write:

  logging.exception("error getting domain information')

for details, see
https://docs.python.org/2/library/logging.html#logging.Logger.exception
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.error("error getting domain infomation: %s", 
e)
> The vm.name() can be the exception.
I see, thanks for clarification.
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3:

(2 comments)

part of Milan's comment was unanswered, and I'm reposting it :)
Besides that, looks better, thanks!

https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.error("error getting domain infomation: %s", 
e)
> I see, thanks for clarification.
typo: should be infoRmation.
Also, if you want to log the exception (and I think we should), please use 
something like

  logging.exception("some helpful message")
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


Line 165: continue
Line 166: try:
Line 167: root = ET.fromstring(xml)
Line 168: except ET.ParseError as e:
Line 169: logging.error('error parsing domain xml: %s', e)
> The same.
same as my previous comment about exception()
Line 170: continue
Line 171: try:
Line 172: _add_general_info(root, params)
Line 173: except InvalidVMConfiguration as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 154: params = {}
Line 155: try:
Line 156: _add_vm_info(vm, params)
Line 157: except libvirt.libvirtError as e:
Line 158: logging.error("error getting domain infomation: %s", 
e)
Maybe adding vm.name() to the log message could be useful?
Should we use logging.error or logging.exception here (i.e. do we want to have 
traceback in the log)?
Line 159: continue
Line 160: try:
Line 161: xml = vm.XMLDesc(0)
Line 162: except libvirt.libvirtError as e:


Line 165: continue
Line 166: try:
Line 167: root = ET.fromstring(xml)
Line 168: except ET.ParseError as e:
Line 169: logging.error('error parsing domain xml: %s', e)
The same.
Line 170: continue
Line 171: try:
Line 172: _add_general_info(root, params)
Line 173: except InvalidVMConfiguration as e:


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 175:   e.message, vm.XMLDesc(0))
Line 176: continue
Line 177: try:
Line 178: _add_networks(root, params)
Line 179: except libvirt.libvirtError as e:
> My point is that libvirtError is never raised inside _add_networks or _add_
sorry good point!
it should be ParseError...
Line 180: logging.error('error reading network configuration: 
%s', e)
Line 181: continue
Line 182: try:
Line 183: _add_disks(root, params)


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 175:   e.message, vm.XMLDesc(0))
Line 176: continue
Line 177: try:
Line 178: _add_networks(root, params)
Line 179: except libvirt.libvirtError as e:
Can this be raised here? It seems to me that _add_networks just processes 
parsed DOM data.
Line 180: logging.error('error reading network configuration: 
%s', e)
Line 181: continue
Line 182: try:
Line 183: _add_disks(root, params)


Line 180: logging.error('error reading network configuration: 
%s', e)
Line 181: continue
Line 182: try:
Line 183: _add_disks(root, params)
Line 184: except libvirt.libvirtError as e:
The same.
Line 185: logging.error('error reading disks configuration: 
%s', e)
Line 186: continue
Line 187: for disk in params['disks']:
Line 188: _add_disk_info(conn, disk)


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 175:   e.message, vm.XMLDesc(0))
Line 176: continue
Line 177: try:
Line 178: _add_networks(root, params)
Line 179: except libvirt.libvirtError as e:
> Can this be raised here? It seems to me that _add_networks just processes p
if we raise here we will not present the user any VMs for one rouge VM.
Line 180: logging.error('error reading network configuration: 
%s', e)
Line 181: continue
Line 182: try:
Line 183: _add_disks(root, params)


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: for disk in params['disks']:
Line 173: _add_disk_info(conn, disk)
Line 174: vms.append(params)
Line 175: except InvalidVMConfiguration as e:
Line 176: logging.error('error parsing domain: %s', e)
> XMLDec is one,
ok, but then we need to add more except clauses, don't we?
Now we have these unguarded (outside try/except blocks) statements:

  _add_vm_info

  root = ET.fromstring(xml)

  _add_networks(root, params)
  _add_disks(root, params)
  for disk in params['disks']:
_add_disk_info(conn, disk)
  vms.append(params)

it seems to me none of them could raise InvalidVMConfiguration. If so this 
patch adds nothing to the robustness of this method.
I think we should need to catch more exceptions.
Line 177: return {'status': doneCode, 'vmList': vms}
Line 178: 
Line 179: 
Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 175:   e.message, vm.XMLDesc(0))
Line 176: continue
Line 177: try:
Line 178: _add_networks(root, params)
Line 179: except libvirt.libvirtError as e:
> if we raise here we will not present the user any VMs for one rouge VM.
My point is that libvirtError is never raised inside _add_networks or 
_add_disks (unless I miss something) so this except clause doesn't make sense.
Line 180: logging.error('error reading network configuration: 
%s', e)
Line 181: continue
Line 182: try:
Line 183: _add_disks(root, params)


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ecd222dc3805a084be62f05260c80e16d61b8e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: v2v: add try/except to get_external_vms
..

v2v: add try/except to get_external_vms

Single domain error causes get_external_vms to fail.

Change-Id: I8ecd222dc3805a084be62f05260c80e16d61b8e0
Signed-off-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 20 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/49557/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index ab657d0..fc5528c 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -152,22 +152,38 @@
 vms = []
 for vm in conn.listAllDomains():
 params = {}
-_add_vm_info(vm, params)
+try:
+_add_vm_info(vm, params)
+except libvirt.libvirtError as e:
+logging.error("error getting domain infomation: %s", e)
+continue
 try:
 xml = vm.XMLDesc(0)
 except libvirt.libvirtError as e:
 logging.error("error getting domain xml for vm %r: %s",
   vm.name(), e)
 continue
-root = ET.fromstring(xml)
+try:
+root = ET.fromstring(xml)
+except ET.ParseError as e:
+logging.error('error parsing domain xml: %s', e)
+continue
 try:
 _add_general_info(root, params)
 except InvalidVMConfiguration as e:
 logging.error('error parsing domain xml, msg: %s  xml: %s',
   e.message, vm.XMLDesc(0))
 continue
-_add_networks(root, params)
-_add_disks(root, params)
+try:
+_add_networks(root, params)
+except libvirt.libvirtError as e:
+logging.error('error reading network configuration: %s', e)
+continue
+try:
+_add_disks(root, params)
+except libvirt.libvirtError as e:
+logging.error('error reading disks configuration: %s', e)
+continue
 for disk in params['disks']:
 _add_disk_info(conn, disk)
 vms.append(params)


-- 
To view, visit https://gerrit.ovirt.org/49557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ecd222dc3805a084be62f05260c80e16d61b8e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/49557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ecd222dc3805a084be62f05260c80e16d61b8e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has abandoned this change.

Change subject: v2v: add try/except to get_external_vms
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/49557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8ecd222dc3805a084be62f05260c80e16d61b8e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1: Code-Review-1

(1 comment)

I'm  totally fine with the concept, not sure how this patch achieves that.

https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: for disk in params['disks']:
Line 173: _add_disk_info(conn, disk)
Line 174: vms.append(params)
Line 175: except InvalidVMConfiguration as e:
Line 176: logging.error('error parsing domain: %s', e)
which function/method can raise InvalidVMConfiguration?
I mean: _add_general_info could, and indeed we have try/except guard. What 
besides that?
Line 177: return {'status': doneCode, 'vmList': vms}
Line 178: 
Line 179: 
Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > I'm  totally fine with the concept, not sure how this patch
 > achieves that.
_add_vm is a part of a loop that collect VMs from external provider,
if there is unexpected error in one of the VMs we still able to return the VMs 
that we can import to the user for review.

https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: for disk in params['disks']:
Line 173: _add_disk_info(conn, disk)
Line 174: vms.append(params)
Line 175: except InvalidVMConfiguration as e:
Line 176: logging.error('error parsing domain: %s', e)
> which function/method can raise InvalidVMConfiguration?
XMLDec is one,
and we encounter in state (ie status).
We don't know if we will encounter more methods in the future and we don't want 
to fail the verb for one bad vm
Line 177: return {'status': doneCode, 'vmList': vms}
Line 178: 
Line 179: 
Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: v2v: add try/except to get_external_vms
..

v2v: add try/except to get_external_vms

Single domain error causes get_external_vms to fail.

Bug-Url: https://bugzilla.redhat.com/1284412
Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Signed-off-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 20 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/49507/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index ab657d0..c227296 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -152,25 +152,28 @@
 vms = []
 for vm in conn.listAllDomains():
 params = {}
-_add_vm_info(vm, params)
 try:
-xml = vm.XMLDesc(0)
-except libvirt.libvirtError as e:
-logging.error("error getting domain xml for vm %r: %s",
-  vm.name(), e)
-continue
-root = ET.fromstring(xml)
-try:
-_add_general_info(root, params)
+_add_vm_info(vm, params)
+try:
+xml = vm.XMLDesc(0)
+except libvirt.libvirtError as e:
+logging.error("error getting domain xml for vm %r: %s",
+  vm.name(), e)
+continue
+root = ET.fromstring(xml)
+try:
+_add_general_info(root, params)
+except InvalidVMConfiguration as e:
+logging.error('error parsing domain xml, msg: %s  xml: %s',
+  e.message, vm.XMLDesc(0))
+continue
+_add_networks(root, params)
+_add_disks(root, params)
+for disk in params['disks']:
+_add_disk_info(conn, disk)
+vms.append(params)
 except InvalidVMConfiguration as e:
-logging.error('error parsing domain xml, msg: %s  xml: %s',
-  e.message, vm.XMLDesc(0))
-continue
-_add_networks(root, params)
-_add_disks(root, params)
-for disk in params['disks']:
-_add_disk_info(conn, disk)
-vms.append(params)
+logging.error('error parsing domain: %s', e)
 return {'status': doneCode, 'vmList': vms}
 
 


-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1:

* #1284412::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284412::OK, public bug
* Check Product::#1284412::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches