Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Kazunobu Kuriyama
Hello, Thilo and those who have been actively discussed the runtime file issue. On May 18, 2012, at 6:37 AM, Thilo Six wrote: snip Then we have decided that we change current maintenance model of runtimefiles to be a collaboration one and we use 'vim-dev' for future coordination. As a

RE: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie John Beckett
Kazunobu Kuriyama wrote: As a maintainer of a few runtime files, I have something to make sure of: Are there any changes for the current maintainers in what they observe--policy, obligations, or something similar to those, to maintain the runtime files they are in charge of? Nothing is

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Dominique Pellé
John Beckett johnb.beck...@gmail.com wrote: Kazunobu Kuriyama wrote: As a maintainer of a few runtime files, I have something to make sure of: Are there any changes for the current maintainers in what they observe--policy, obligations, or something similar to those, to maintain the runtime

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Thilo Six
Hello Dominique, Excerpt from Dominique Pellé: John Beckett johnb.beck...@gmail.com wrote: Kazunobu Kuriyama wrote: As a maintainer of a few runtime files, I have something to make sure of: Are there any changes for the current maintainers in what they observe--policy, obligations, or

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Thilo Six
Hello Kazunobu and John, Excerpt from John Beckett: Kazunobu Kuriyama wrote: As a maintainer of a few runtime files, I have something to make sure of: Are there any changes for the current maintainers in what they observe--policy, obligations, or something similar to those, to maintain the

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Dominique Pellé
Thilo Six t@gmx.de wrote: I would like to be able to comment on checkins in a more formal way than emails. How exactly would that work? An image is worth a 1000 words. So here is a screenshot illustrating how code reviews happen in Crucible:

Patch 7.3.516

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.516 Problem:extend(o, o) may crash Vim. Solution: Fix crash and add test. (Thinca and Hirohito Higashi) Files: src/eval.c, src/testdir/test55.in, src/testdir/test55.ok *** ../vim-7.3.515/src/eval.c 2012-04-30 17:35:44.0 +0200 --- src/eval.c 2012-05-18

Patch 7.3.517

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.517 Problem:Crash when using vipvv. (Alexandre Provencio) Solution: Don't let the text length become negative. Files: src/ops.c *** ../vim-7.3.516/src/ops.c2012-04-20 13:46:02.0 +0200 --- src/ops.c 2012-05-18 12:28:09.0 +0200 *** ***

Make tabs in conceal mode work like there is no concealing

2012-05-18 Fir de Conversatie Bram Moolenaar
Currently there is the problem that if characters are concealed before a Tab then the position of the text after the Tab may change, depending on whether the gap that the Tab covers goes over the tab size. This is most noticeable at :help index. We already have code to keep line wrapping in the

Re: Make tabs in conceal mode work like there is no concealing

2012-05-18 Fir de Conversatie Dominique Pellé
Bram Moolenaar b...@moolenaar.net wrote: Currently there is the problem that if characters are concealed before a Tab then the position of the text after the Tab may change, depending on whether the gap that the Tab covers goes over the tab size. This is most noticeable at :help index. We

Re: Make tabs in conceal mode work like there is no concealing

2012-05-18 Fir de Conversatie Bram Moolenaar
Dominique Pelle wrote: Bram Moolenaar b...@moolenaar.net wrote: Currently there is the problem that if characters are concealed before a Tab then the position of the text after the Tab may change, depending on whether the gap that the Tab covers goes over the tab size. This is most

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Jan Larres
Dominique Pellé dominique.pe...@gmail.com: Thilo Six t@gmx.de wrote: I would like to be able to comment on checkins in a more formal way than emails. How exactly would that work? An image is worth a 1000 words. So here is a screenshot illustrating how code reviews happen in Crucible:

vim msi

2012-05-18 Fir de Conversatie pek
Hello, I wrote simple vim msi installer. Package create shortcut on desktop and in start menu. Also add install directory to %PATH% enviroment variable so you can run vim from command line. https://github.com/petrkle/vim-msi/ Petr -- You received this message from the vim_dev maillist. Do not

Patch 7.3.518

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.518 Problem:When 'encoding' is a double-byte encoding :helptags may not find tags correctly. Solution: Use vim_strbyte() instead of vim_strchr(). (Yasuhiro Matsumoto) Files: src/ex_cmds.c *** ../vim-7.3.517/src/ex_cmds.c2012-04-25 17:32:14.0

Patch 7.3.519

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.519 Problem:When completefunction returns it cannot indicate end of completion mode. Solution: Recognize completefunction returning -3. (Mtsushita Shougo) Files: src/edit.c *** ../vim-7.3.518/src/edit.c 2012-04-30 18:18:43.0 +0200 --- src/edit.c

Re: Spell correction ignores certain characters

2012-05-18 Fir de Conversatie Axel
Will this get fixed in some official patch? -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php

Re: home_replace() does not work with short path name on windows.

2012-05-18 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: On Friday, April 20, 2012 11:13:40 PM UTC+9, Bram Moolenaar wrote: Why use the GetLongPathName function? It's not used anywhere in Vim. Can we use vim_FullName() with the force argument set to TRUE? I suppose this is only needed for MS-Windows. Since

Patch 7.3.520

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.520 Problem:Gvim starts up slow on Unbuntu 12.04. Solution: Move the call to gui_mch_init_check() to after fork(). (Yasuhiro Matsumoto) Do check $DISPLAY being set. Files: src/gui.c, src/gui_gtk_x11.c, src/proto/gui_gtk_x11.pro *** ../vim-7.3.519/src/gui.c

runtime/ftplugin/zimbu.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Bram, i have a question regarding 'runtime/ftplugin/zimbu.vim'. I see 'b:undo_ftplugin' undoes somes things. But isn't 'efm tw et sts sw' missing? What about functions? Shouldn't we 'delf' them, too? -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F

[patch] runtime/indent/zimbu.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Bram, 'runtime/indent/zimbu.vim' uses line-continuation without cpo handling. This patch adds that. Though i am not exactly sure i did it right. Line-continuation happens inside a function with several 'return's surrounding. Please review. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0

Re: Spell correction ignores certain characters

2012-05-18 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: When using the spell correction feature (set spelllang=de_de spell) a word containing a german ß (0xDF) is displayed incorrectly if it is found to be misspelled: Wir wohnen nicht in der Georgenkirchstraße, sondern in der Hauptstraße. In this

Re: [patch] runtime/indent/zimbu.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Bram, -- snip -- 'runtime/indent/zimbu.vim' uses line-continuation without cpo handling. This patch adds that. Though i am not exactly sure i did it right. Line-continuation happens inside a function with several 'return's surrounding. Please review. Additionally i think

Re: Patch 7.3.519

2012-05-18 Fir de Conversatie Yasuhiro MATSUMOTO
His name is Matsushita Shougo. :) On 5/18/12, Bram Moolenaar b...@moolenaar.net wrote: Patch 7.3.519 Problem:When completefunction returns it cannot indicate end of completion mode. Solution: Recognize completefunction returning -3. (Mtsushita Shougo) Files:

Re: Spell correction ignores certain characters

2012-05-18 Fir de Conversatie Dominique Pellé
Bram Moolenaar b...@moolenaar.net wrote: Christian Brabandt wrote: When using the spell correction feature (set spelllang=de_de spell) a word containing a german ß (0xDF) is displayed incorrectly if it is found to be misspelled: Wir wohnen nicht in der Georgenkirchstraße,

Patch 7.3.521

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.521 Problem:Using z= on a multi-byte character may cause a crash. Solution: Don't use strlen() on an int pointer. Files: src/spell.c *** ../vim-7.3.520/src/spell.c 2012-01-10 22:26:12.0 +0100 --- src/spell.c 2012-05-18 18:01:58.0 +0200 *** ***

Re: Spell correction ignores certain characters

2012-05-18 Fir de Conversatie Bram Moolenaar
Dominique Pelle wrote: Bram Moolenaar b...@moolenaar.net wrote: Christian Brabandt wrote: When using the spell correction feature (set spelllang=de_de spell) a word containing a german ß (0xDF) is displayed incorrectly if it is found to be misspelled: Wir wohnen

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Ben Fritz
On Friday, May 18, 2012 2:45:16 AM UTC-5, JohnBeckett wrote: Kazunobu Kuriyama wrote: As a maintainer of a few runtime files, I have something to make sure of: Are there any changes for the current maintainers in what they observe--policy, obligations, or something similar to those, to

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Ben Fritz
On Friday, May 18, 2012 12:54:56 AM UTC-5, Gary Johnson wrote: On 2012-05-17, Thilo Six wrote: I would require that we gain at least 7 individuals with commit access. This is to somewhat grant that always someone is around who can do the job. Anyone who is interested to volunteer for

Patch 7.3.522

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.522 Problem:Crash in vim_realloc() when using MEM_PROFILE. Solution: Avoid using a NULL argument. (Dominique Pelle) Files: src/eval.c *** ../vim-7.3.521/src/eval.c 2012-05-18 12:06:58.0 +0200 --- src/eval.c 2012-05-18 18:19:25.0 +0200 *** ***

Re: Does it still make sense to have per-file/-type maintainers? [Was: Re: Added support for spell checking in runtime/syntax/ocaml.vim]

2012-05-18 Fir de Conversatie Charles E Campbell Jr
Ben Fritz wrote: On Thursday, May 17, 2012 1:07:52 PM UTC-5, Thilo Six wrote: To me absolutely yes. Obviously we will need to discuss and decide some more details/workflows but i think the consensus is broad enough to start getting it productive. Are you fine with using vim-dev as our

Patch 7.3.523

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.523 Problem::diffupdate doesn't check for files changed elsewhere. Solution: Add the ! flag. (Christian Brabandt) Files: runtime/doc/diff.txt, src/diff.c, src/ex_cmds.h *** ../vim-7.3.522/runtime/doc/diff.txt 2010-08-15 21:57:16.0 +0200 --- runtime/doc/diff.txt

Re: [patch] runtime/indent/zimbu.vim

2012-05-18 Fir de Conversatie Bram Moolenaar
Thilo Six wrote: 'runtime/indent/zimbu.vim' uses line-continuation without cpo handling. This patch adds that. Though i am not exactly sure i did it right. Line-continuation happens inside a function with several 'return's surrounding. Please review. Thanks for the hint. The 'cpo' handling

runtime/indent/liquid.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Tim, looking at 'runtime/indent/liquid.vim' i notice it does not make use of 'b:undo_indent' though it sets 'indentexpr' and 'indentkeys' to nonstandard values. I am most probably wrong on the following so please review: 'runtime/indent/liquid.vim' uses '[^\n]' though it does not handle

backupskip and writebackup

2012-05-18 Fir de Conversatie Ben Fritz
Changeset 1b584a6f446c pushed just a bit ago updates the help for writebackup and backupskip to include text about potential data loss if Vim fails on write. Presumably this is in response to a recent thread on both vim_dev and vim_use about a user who experienced this data loss:

Re: Issue 60 in vim: Netrw is broken [Patch included]

2012-05-18 Fir de Conversatie vim
Comment #1 on issue 60 by francesc...@gmail.com: Netrw is broken [Patch included] http://code.google.com/p/vim/issues/detail?id=60 This was already fixed. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more

runtime/syntax/cl.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Philip, i noticed by looking at 'runtime/syntax/cl.vim' that it could make use of '@Spell' so that Vim highlights spelling mistakes in comments only when editing a cl file with those settings: :syntax on :set spell -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4

Re: Patch 7.3.523

2012-05-18 Fir de Conversatie Raymond Ko
src/version.c is missing a comma after 523 and as result VIM will not compile. -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php

Re: [patch] runtime/indent/zimbu.vim

2012-05-18 Fir de Conversatie Bram Moolenaar
I wrote to Thilo Six: 'runtime/indent/zimbu.vim' uses line-continuation without cpo handling. This patch adds that. Though i am not exactly sure i did it right. Line-continuation happens inside a function with several 'return's surrounding. Please review. Thanks for the hint. The

Patch 7.3.524

2012-05-18 Fir de Conversatie Bram Moolenaar
Patch 7.3.524 (after 7.3.523) Problem:Missing comma. Solution: Add the comma. Files: src/version.c *** ../vim-7.3.523/src/version.c2012-05-18 18:47:11.0 +0200 --- src/version.c 2012-05-18 21:52:26.0 +0200 *** *** 715,721 static int

Re: Patch 7.3.523

2012-05-18 Fir de Conversatie Bram Moolenaar
Raymond - src/version.c is missing a comma after 523 and as result VIM will not compile. Oops. Fixed now. - Bram -- BLACK KNIGHT: None shall pass. ARTHUR: I have no quarrel with you, brave Sir knight, but I must cross this bridge. BLACK KNIGHT: Then you shall die.

[patch] runtime/syntax/ninja.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Nicolas, here is small patch for 'runtime/syntax/ninja.vim' so that Vim highlights spelling mistakes in comments only when editing a file with those settings: :syntax on :set spell -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received

[patch] runtime/syntax/progress.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Philip, here is small patch for 'runtime/syntax/progress.vim' so that Vim highlights spelling mistakes in comments only when editing a file with those settings: :syntax on :set spell -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You

[patch] runtime/syntax/resolv.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello David, 'runtime/syntax/resolv.vim' uses '[-0-9A-Za-z_\.]' therefore it should handle cpoptions correctly. see ':h cpo-l' for details. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not

runtimefiles updated

2012-05-18 Fir de Conversatie Thilo Six
Hello Bram, please find attached updates for: runtime/syntax/dirpager.vim runtime/syntax/dnsmasq.vim runtime/syntax/gnash.vim -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type

[patch] runtime/ftplugin/art.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Dorai, this patch adds 'b:undo_ftplugin' to 'runtime/ftplugin/art.vim' -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For

[patch] runtime/ftplugin/cs.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Johannes, this patch adds 'b:undo_ftplugin' to 'runtime/ftplugin/cs.vim'. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to.

[patch] runtime/ftplugin/ishd.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Johannes, this patch adds 'b:undo_ftplugin' to 'runtime/ftplugin/ishd.vim'. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to.

[patch] runtime/ftplugin/occam.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello Mario, this patch fixes a typo inside 'b:undo_ftplugin'. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more

[patch] runtime/ftplugin/sql.vim

2012-05-18 Fir de Conversatie Thilo Six
Hello David, this patch completes 'b:undo_ftplugin' in 'runtime/ftplugin/sql.vim'. -- Regards, Thilo 4096R/0xC70B1A8F 721B 1BA0 095C 1ABA 3FC6 7C18 89A4 A2A0 C70B 1A8F -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying