John Beckett <[email protected]> wrote:

> Kazunobu Kuriyama wrote:
>> As a maintainer of a few runtime files, I have something to
>> make sure of: Are there any changes for the current
>> maintainers in what they observe--policy, obligations, or
>> something similar to those, to maintain the runtime files
>> they are in charge of?
>
> Nothing is definite, but I don't think so. What would be
> different (I think) is that a maintainer would send updates to
> someone or something other than Bram. The group maintainers
> would review the change and periodically notify Bram that
> updates were available. He would then incorporate them into the
> Vim distribution, presumably after his own review.
>
> John

Does anybody know if there is something that can easily be
set up for code reviews?  I would like to be able to comment
on checkins in a more formal way than emails.

I've personally used Crucible
http://www.atlassian.com/software/crucible/overview
and I found that such code reviews help to catch errors, improve code quality,
learn from others comments and improve awareness of changes happening in
the source tree. I'm not saying that we should use crucible (it's not free) but
something similar.

In this page http://code.google.com/p/support/wiki/GettingStarted
I read "Source subtab -- You can elect to have non-project members
review your code."
I wonder whether this is enabled for the vim project and whether it's the
kind of review that Crucible offers.

Ideally, it should add zero burden to checkins and any checkin could be
automatically reviewed.

Regards
-- Dominique

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Raspunde prin e-mail lui