Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-03-11 Fir de Conversatie Tony Mechelynck
On 05/01/10 20:30, Matt Wozniski wrote: On Tue, Jan 5, 2010 at 2:17 PM, Sergey Khorev wrote: Well, Isn't that only checking the type of CPU that the vim binary was built with, instead of whether it was built as an x64 binary? Or does defining WIN64 cause an x64 binary to be built instead?

Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-01-05 Fir de Conversatie Matt Wozniski
On Tue, Jan 5, 2010 at 8:52 AM, Sergey Khorev wrote: Hi, has(win64) returns 0 even for x64 version of Vim. It seems we need to define WIN64 for this to work. Something like that: *** ../vim72.323/src/Make_mvc.mak       Wed Dec 23 09:36:54 2009 --- src/Make_mvc.mak    Tue Jan  5 16:46:26

Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-01-05 Fir de Conversatie Sergey Khorev
Well, Isn't that only checking the type of CPU that the vim binary was built with, instead of whether it was built as an x64 binary?  Or does defining WIN64 cause an x64 binary to be built instead? CPU in makefile defines target CPU. -DWIN64 passed to compiler does nothing besides pointing

Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-01-05 Fir de Conversatie Matt Wozniski
On Tue, Jan 5, 2010 at 2:17 PM, Sergey Khorev wrote: Well, Isn't that only checking the type of CPU that the vim binary was built with, instead of whether it was built as an x64 binary?  Or does defining WIN64 cause an x64 binary to be built instead? CPU in makefile defines target CPU.

Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-01-05 Fir de Conversatie Sergey Khorev
Matt, I can conceive of a plugin that dynamically loads a DLL - or another program - that requires a 64-bit windows, which would need to know that the host OS supports it.  In this case, you'd want to know that the OS is 64 bit, even if the vim binary is 32-bit.  But as I said, I can see the

Re: [patch] has(win64) returns 0 in 64-bit Vim

2010-01-05 Fir de Conversatie Sergey Khorev
Hi, In many places in the code _WIN64 is checked for, but the list for has() uses WIN64. Perhaps we should change them all to WIN64 to be consistent with WIN32, and then define WIN64 in vim.h when _WIN64 is defined. That will be inconsistent with WIN32 because it is defined in Makefile :)