Re: Convert test_marks to a new style test

2016-08-28 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sun, Aug 28, 2016 at 11:14 AM, Bram Moolenaar wrote: > > Yegappan wrote: > >> The attached patch converts the test_marks test from old style to new style. > > Thanks, I'll look into it soon. > I have converted a few more tests to new style tests. - Yegappan -- --

Re: system() delay

2016-08-28 Fir de Conversatie Dominique Pellé
Ramel wrote: > Nice catch! > My 'shell' was tcsh and after changing it to /bin/sh (=bash) System() works > much better (only ~x2 slower than Job()). I probably wouldn't get into this > if I got these results in the first place.. still, I'm going to use the > above blocking

Re: Erroneous positioning of cursor with multibyte characters

2016-08-28 Fir de Conversatie Eric Pruitt
On Sun, Aug 28, 2016 at 05:26:01PM -0700, Eric Pruitt wrote: > I am Vim 7.4.2289, and I have noticed a problem with multibyte > characters and the cursor. I have attached a test file and a picture > showing the problem. When I press a button to move the cursor to the > right one character, it

Re: system() delay

2016-08-28 Fir de Conversatie Ramel
Nice catch! My 'shell' was tcsh and after changing it to /bin/sh (=bash) System() works much better (only ~x2 slower than Job()). I probably wouldn't get into this if I got these results in the first place.. still, I'm going to use the above blocking version of job_start (it is as fast as Job())

Re: system() delay

2016-08-28 Fir de Conversatie Dominique Pellé
Ramel Eshed wrote: > My problem is not with the channel, the problem is > that system() is slower than the equivalent job_start(). > You can run and compare the results of Job() and System() > functions in the attached file. They are both doing the same > thing ('echo aaa')

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie JohnBeckett
On Sunday, August 28, 2016 at 11:26:51 PM UTC+10, Christian Brabandt wrote: > Would a message, if both files are the same, be sufficient? I think diff > always returns 0 if there are no differences found, so we could simply > show a message in that case. Hi Christian, Thanks for the suggestion

Re: Small doc fixes for lambda

2016-08-28 Fir de Conversatie Ken Takata
Hi Bram, 2016/8/29 Mon 4:21:51 UTC+9 Bram Moolenaar wrote: > Manuel Ortega wrote: > > > At ":h lambda", there is some erroneous markup. It mistakenly is > > "|expr1|", which takes the user to the help for the ternary conditional! > > That is correct. This is the higest level expression.

Re: system() delay

2016-08-28 Fir de Conversatie Ramel Eshed
On Sunday, August 28, 2016 at 11:36:33 PM UTC+3, Bram Moolenaar wrote: > Ramel Eshed wrote: > > > Of course, I've measured the time from job_start to close_cb. You can see > > this comparison in the example I've attached earlier in this thread. > > Hmm, it's possible that detecting that the

[patch] corrections in runtime/doc/version8.txt

2016-08-28 Fir de Conversatie Dominique Pellé
Hi Attached patch contains minor corrections to runtime/doc/version8.txt. Regards Dominique -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You

[patch] fixed more issues with printf() with float numbers

2016-08-28 Fir de Conversatie Dominique Pellé
Hi Attached patch fixes further problems with printf() for floats in Vim-7.4.2290. Padding with 0 did not work properly when there is a sign: :echo printf("%06.2f", -1.0) Actual: "0-1.00" Expected: "-01.00" Forcing sign was not honored: :echo printf("%+.2f", 1.0) Actual: "1.00" Expected:

Re: system() delay

2016-08-28 Fir de Conversatie Bram Moolenaar
Ramel Eshed wrote: > Of course, I've measured the time from job_start to close_cb. You can see > this comparison in the example I've attached earlier in this thread. Hmm, it's possible that detecting that the other end closed the pipe happens much sooner than detecting that the child process

Re: warning in message.c in tiny build (ifdef missing in patch 2280?)

2016-08-28 Fir de Conversatie Bram Moolenaar
Tony wrote: > gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/message.o > message.c > message.c:3998:1: warning: ‘infinity_str’ defined but not used > [-Wunused-function] > infinity_str(int positive, > ^ > > - No

Re: Small doc fixes for lambda

2016-08-28 Fir de Conversatie Bram Moolenaar
Manuel Ortega wrote: > At ":h lambda", there is some erroneous markup. It mistakenly is > "|expr1|", which takes the user to the help for the ternary conditional! That is correct. This is the higest level expression. It's clearer if you start with reading ":help expression-syntax". > I

Patch 7.4.2290

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2290 Problem:Compiler warning in tiny build. (Tony Mechelynck) Solution: Add #ifdef around infinity_str(). Files: src/message.c *** ../vim-7.4.2289/src/message.c 2016-08-28 16:03:34.820991891 +0200 --- src/message.c 2016-08-28 21:19:37.217508980 +0200

Re: system() delay

2016-08-28 Fir de Conversatie Ramel
Of course, I've measured the time from job_start to close_cb. You can see this comparison in the example I've attached earlier in this thread. On Aug 28, 2016 10:01 PM, "Bram Moolenaar" wrote: > > Ramel Eshed wrote: > > > On Sunday, August 28, 2016 at 5:53:33 PM UTC+3, Bram

Patch 7.4.2289

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2289 Problem:When installing and $DESTDIR is set the icons probably won't be installed. Solution: Create the icon directories if $DESTDIR is not empty. (Danek Duvall) Files: src/Makefile *** ../vim-7.4.2288/src/Makefile2016-08-28

Re: patch to create icon directories before installing

2016-08-28 Fir de Conversatie Bram Moolenaar
Danek Duvall wrote: > I've been sitting on this patch for a bit. If you do "make install" with > DESTDIR set, then it's unlikely that the directories where the icons go > will exist already, so create them in that situation. > > --- a/src/Makefile > +++ b/src/Makefile > @@ -2366,6 +2366,10 @@

Re: system() delay

2016-08-28 Fir de Conversatie Bram Moolenaar
Ramel Eshed wrote: > On Sunday, August 28, 2016 at 5:53:33 PM UTC+3, Bram Moolenaar wrote: > > Ramel Eshed wrote: > > > > > On Friday, August 26, 2016 at 7:29:58 PM UTC+3, Bram Moolenaar wrote: > > > > Ramel Eshed wrote: > > > > > > > > > On Friday, August 26, 2016 at 12:02:38 AM UTC+3, Bram

Vim 7.4x ready for beta testing

2016-08-28 Fir de Conversatie Bram Moolenaar
Hello Vim users, Announcing: Vim (Vi IMproved) version 7.4x BETA This is the first BETA release for Vim 8 Please check that the distribution is OK. I haven't done one for a long time. Report anything that isn't right. That includes a crash but also a typo in the documentation or a

warning in message.c in tiny build (ifdef missing in patch 2280?)

2016-08-28 Fir de Conversatie Tony Mechelynck
gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/message.o message.c message.c:3998:1: warning: ‘infinity_str’ defined but not used [-Wunused-function] infinity_str(int positive, ^ - No warning in Huge build with +float

patch to create icon directories before installing

2016-08-28 Fir de Conversatie Danek Duvall
I've been sitting on this patch for a bit. If you do "make install" with DESTDIR set, then it's unlikely that the directories where the icons go will exist already, so create them in that situation. --- a/src/Makefile +++ b/src/Makefile @@ -2366,6 +2366,10 @@ ICONTHEMEPATH =

Re: Convert test_marks to a new style test

2016-08-28 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > The attached patch converts the test_marks test from old style to new style. Thanks, I'll look into it soon. -- >From "know your smileys": <|-) Chinese <|-( Chinese and doesn't like these kind of jokes /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net

Patch 7.4.2288

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2288 Problem:MS-Windows build instructions are clumsy. "dosbin" doesn't build. Solution: Add rename.bat. Fix building "dosbin". Files: Makefile, Filelist, tools/rename.bat *** ../vim-7.4.2287/Makefile2016-08-28 18:47:10.768482836 +0200 --- Makefile2016-08-28

Patch 7.4.2287

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2287 Problem:The callback passed to ch_sendraw() is not used. Solution: Pass the read part, not the send part. (haya14busa, closes #1019) Files: src/channel.c, src/testdir/test_channel.vim *** ../vim-7.4.2286/src/channel.c 2016-08-26 17:58:33.586124416 +0200 ---

Re: Add noexpandtab to modeline in *.c and *.h.

2016-08-28 Fir de Conversatie Bram Moolenaar
Naruhiko Nishino wrote: > I always set 'setlocal noexpandtab' when edit .c and .h files. > I'd like to add noexpandtab to modeline in *.c and *.h. I would say it's the default. But then, we also set 'tabstop' to 8. In case someone has a different default in their .vimrc. I suppose we could

Small doc fixes for lambda

2016-08-28 Fir de Conversatie Manuel Ortega
At ":h lambda", there is some erroneous markup. It mistakenly is "|expr1|", which takes the user to the help for the ternary conditional! I think what was meant was "{expr1}", but even better would just be "{expr}". The following diff fixes it, along with one tiny, unrelated omission. -Manny

Convert test_marks to a new style test

2016-08-28 Fir de Conversatie Yegappan Lakshmanan
Hi, The attached patch converts the test_marks test from old style to new style. - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You

Re: system() delay

2016-08-28 Fir de Conversatie Ramel Eshed
On Sunday, August 28, 2016 at 5:53:33 PM UTC+3, Bram Moolenaar wrote: > Ramel Eshed wrote: > > > On Friday, August 26, 2016 at 7:29:58 PM UTC+3, Bram Moolenaar wrote: > > > Ramel Eshed wrote: > > > > > > > On Friday, August 26, 2016 at 12:02:38 AM UTC+3, Bram Moolenaar wrote: > > > > > Ramel

Patch 7.4.2286

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2286 Problem:The tee program isn't included. Makefile contains build instructions that don't work. Solution: Update the Filelist and build instructions. Remove build instructions for DOS and old Windows. Add the tee program. Files: Filelist,

Patch 7.4.2285

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2285 Problem:Generated files are outdated. Solution: Generate the files. Avoid errors when generating prototypes. Files: src/if_mzsch.h, src/Makefile, src/option.h, src/os_mac_conv.c, src/os_amiga.c, src/vim.h, src/structs.h, src/os_win32.c,

Add noexpandtab to modeline in *.c and *.h.

2016-08-28 Fir de Conversatie Naruhiko Nishino
Hi Bram, I always set 'setlocal noexpandtab' when edit .c and .h files. I'd like to add noexpandtab to modeline in *.c and *.h. Best regards, Naruhiko Nishino -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For

Re: Patch 7.4.2278

2016-08-28 Fir de Conversatie h_east
Hi Bram and all, 2016-8-28(Sun) 21:40:05 UTC+9 Bram Moolenaar: > Patch 7.4.2278 > Problem:New users have no idea of the 'scrolloff' option. > Solution: Set 'scrolloff' in defaults.vim. > Files: runtime/defaults.vim > > > *** ../vim-7.4.2277/runtime/defaults.vim 2016-08-21

Patch 7.4.2284

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2284 Problem:Comment in scope header file is outdated. (KillTheMule) Solution: Point to the help instead. (closes #1017) Files: src/if_cscope.h *** ../vim-7.4.2283/src/if_cscope.h 2016-02-27 17:22:23.860493011 +0100 --- src/if_cscope.h 2016-08-28 17:13:21.056741458

Patch 7.4.2283

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2283 Problem:Part of ":oldfiles" command isn't cleared. (Lifepillar) Solution: Clear the rest of the line. (closes 1018) Files: src/ex_cmds.c *** ../vim-7.4.2282/src/ex_cmds.c 2016-08-26 22:29:06.079185186 +0200 --- src/ex_cmds.c 2016-08-28 17:03:13.318030092

Re: system() delay

2016-08-28 Fir de Conversatie Bram Moolenaar
Ramel Eshed wrote: > On Friday, August 26, 2016 at 7:29:58 PM UTC+3, Bram Moolenaar wrote: > > Ramel Eshed wrote: > > > > > On Friday, August 26, 2016 at 12:02:38 AM UTC+3, Bram Moolenaar wrote: > > > > Ramel Eshed wrote: > > > > > > > > > On Thursday, August 11, 2016 at 3:08:01 AM UTC+3,

Patch 7.4.2282

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2282 Problem:When a child process is very fast waiting 10 msec for it is noticeable. (Ramel Eshed) Solution: Start waiting for 1 msec and gradually increase. Files: src/os_unix.c *** ../vim-7.4.2281/src/os_unix.c 2016-08-17 21:31:54.441870400 +0200 ---

Patch 7.4.2281

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2281 Problem:Timer test fails sometimes. Solution: Reduce minimum time by 1 msec. Files: src/testdir/test_timers.vim *** ../vim-7.4.2280/src/testdir/test_timers.vim 2016-08-22 22:47:42.403063438 +0200 --- src/testdir/test_timers.vim 2016-08-28 16:01:42.701963773 +0200

Patch 7.4.2280

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2280 Problem:printf() doesn't handle infinity float values correctly. Solution: Add a table with possible infinity values. (Dominique Pelle) Files: src/message.c, src/testdir/test_expr.vim *** ../vim-7.4.2279/src/message.c 2016-08-27 15:41:28.886869527 +0200 ---

Re: [patch] fixed bugs with inf and nan when using printf()

2016-08-28 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > I found more unexpected results of printf() with > float infinity and float nan (not a number) values > using Vim-7.4.2275: > > :echo printf('%+f', 1.0/0.0) > Expected: '+inf' > Actual: 'inf' > > :echo printf('% f', 1.0/0.0) > Expected: ' inf' > Actual:

Patch 7.4.2279

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2279 Problem:Starting diff mode with the cursor in the last line might end up only showing one closed fold. (John Beckett) Solution: Scroll the window to show the same relative cursor position. Files: src/diff.c, src/window.c, src/proto/window.pro ***

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie Christian Brabandt
Hi JohnBeckett! On Sa, 27 Aug 2016, JohnBeckett wrote: > Can something be done to give a more convincing display of whether the > two buffers have a difference? The problem is that Vim's logic for > positioning the top line of the window shows the minimum amount of > text in the above scenario

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie Manuel Ortega
On Sun, Aug 28, 2016 at 6:05 AM, toothpik wrote: > On Sat, Aug 27, 2016 at 08:32:09PM -0700, JohnBeckett wrote: > > Bram recently fixed :diffoff! > > https://groups.google.com/forum/#!topic/vim_dev/h1nREhhF7mY > > > That reminds me of a diff frustration. > > > Suppose I have

Re: [bug] memory leak with getbufinfo() and signs in Vim-7.4.2275

2016-08-28 Fir de Conversatie Bram Moolenaar
Yegappan Lakshmanan wrote: > On Sun, Aug 28, 2016 at 1:56 AM, Dominique Pell=C3=A9 > wrote: > > Hi > > > > I see a memory leak in Vim-7.4.2275 which can be > > reproduced by: > > > > $ valgrind --leak-check=3Dyes --num-callers=3D50 \ > >vim -u NONE -N \ > >-c

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie Bram Moolenaar
John Beckett wrote: > On Sunday, August 28, 2016 at 8:05:29 PM UTC+10, toothpik wrote: > >> :tabe expected.txt > >> :vert diffs output.txt > > > >> When I last viewed those files, I may have exited with the cursor > >> on the last line. I use the code from ":help restore-cursor" to > >> restore

Patch 7.4.2278

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2278 Problem:New users have no idea of the 'scrolloff' option. Solution: Set 'scrolloff' in defaults.vim. Files: runtime/defaults.vim *** ../vim-7.4.2277/runtime/defaults.vim2016-08-21 17:44:57.440487201 +0200 --- runtime/defaults.vim2016-08-28

Patch 7.4.2277

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2277 Problem:Memory leak in getbufinfo() when there is a sign. (Dominique Pelle) Solution: Remove extra vim_strsave(). Files: src/evalfunc.c *** ../vim-7.4.2276/src/evalfunc.c 2016-08-27 21:25:22.694047740 +0200 --- src/evalfunc.c 2016-08-28

Re: [bug] memory leak with getbufinfo() and signs in Vim-7.4.2275

2016-08-28 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > I see a memory leak in Vim-7.4.2275 which can be > reproduced by: > > $ valgrind --leak-check=yes --num-callers=50 \ >vim -u NONE -N \ >-c 'sign define Sign text=x' \ >-c 'exe "sign place 1 line=3 name=Sign buffer=" . bufnr("%")' \ >-c 'echo

Re: [bug] memory leak with getbufinfo() and signs in Vim-7.4.2275

2016-08-28 Fir de Conversatie Yegappan Lakshmanan
Hi Dominique, On Sun, Aug 28, 2016 at 1:56 AM, Dominique Pellé wrote: > Hi > > I see a memory leak in Vim-7.4.2275 which can be > reproduced by: > > $ valgrind --leak-check=yes --num-callers=50 \ >vim -u NONE -N \ >-c 'sign define Sign text=x' \ >-c 'exe

Patch 7.4.2276

2016-08-28 Fir de Conversatie Bram Moolenaar
Patch 7.4.2276 Problem:Command line test fails on Windows when run twice. Solution: Wipe the buffer so that the directory can be deleted. Files: src/testdir/test_cmdline.vim *** ../vim-7.4.2275/src/testdir/test_cmdline.vim2016-08-27 21:55:09.787084275 +0200 ---

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie Christ van Willegen
Op 28 aug. 2016 12:46 schreef "JohnBeckett" : > > On Sunday, August 28, 2016 at 8:05:29 PM UTC+10, toothpik wrote: > >> :tabe expected.txt > >> :vert diffs output.txt > > > >> When I last viewed those files, I may have exited with the cursor > >> on the last line. I use

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie JohnBeckett
On Sunday, August 28, 2016 at 8:05:29 PM UTC+10, toothpik wrote: >> :tabe expected.txt >> :vert diffs output.txt > >> When I last viewed those files, I may have exited with the cursor >> on the last line. I use the code from ":help restore-cursor" to >> restore the cursor position, so the diff

Re: Diff should indicate if no differences detected

2016-08-28 Fir de Conversatie toothpik
On Sat, Aug 27, 2016 at 08:32:09PM -0700, JohnBeckett wrote: > Bram recently fixed :diffoff! > https://groups.google.com/forum/#!topic/vim_dev/h1nREhhF7mY > That reminds me of a diff frustration. > Suppose I have two files expected.txt and output.txt, each over 1000 > lines. Running a test

[bug] memory leak with getbufinfo() and signs in Vim-7.4.2275

2016-08-28 Fir de Conversatie Dominique Pellé
Hi I see a memory leak in Vim-7.4.2275 which can be reproduced by: $ valgrind --leak-check=yes --num-callers=50 \ vim -u NONE -N \ -c 'sign define Sign text=x' \ -c 'exe "sign place 1 line=3 name=Sign buffer=" . bufnr("%")' \ -c 'echo getbufinfo()' \ -c q 2> log And log file