Re: [PATCH] syntax: Add command to control how foldlevel is computed for a line

[Brad King]

On 10/18/2016 08:27 AM, Brad King wrote:
> On 10/17/2016 04:45 PM, Bram Moolenaar wrote:
>> Thanks.  I suppose that's the best way to do it.
> 
> Great.  Here is a revised patch.

Ping.

Thanks,
-Brad

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] syntax: Add command to control how foldlevel is computed for a line

[Brad King]

On 10/17/2016 04:45 PM, Bram Moolenaar wrote:
> Brad King wrote:
>> I've revised the change to add a new syntax command:
>>
>> :syntax foldlevel [start | minimum]
>>
>> that can be used to enable this.
> 
> Thanks.  I suppose that's the best way to do it.

Great.  I realized that the "syntax foldlevel" command itself should not
be conditioned on FEAT_FOLDING because clients should not have to switch
on the existence of the feature before calling it.  Here is a revised
patch.  Now the documentation simply says that the command is not
meaningful when folding is not available.

Thanks,
-Brad

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
>From 617860554d40293a40ef757b4404073769fe0bca Mon Sep 17 00:00:00 2001
Message-Id: <617860554d40293a40ef757b4404073769fe0bca.1476793464.git.brad.k...@kitware.com>
From: Brad King 
Date: Mon, 17 Oct 2016 13:42:53 -0400
Subject: [PATCH] syntax: Add command to control how foldlevel is computed for
 a line

With `foldmethod=syntax` the foldlevel of a line is computed based
on syntax items on the line.  Previously we always used the level
of the syntax item containing the start of the line.  This works
well in cases such as:

if (...) {
  ...
}
else if (...) {
  ...
}
else {
  ...
}

which folds like this:

+---  3 lines: if (...) {---
+---  3 lines: else if (...) {--
+---  3 lines: else {---

However, the code:

if (...) {
  ...
} else if (...) {
  ...
} else {
  ...
}

folds like this:

+---  7 lines: if (...) {---

We can make the latter case fold like this:

+---  2 lines: if (...) {---
+---  2 lines: } else if (...) {
+---  3 lines: } else {-

by choosing on each line the lowest fold level that is followed
by a higher fold level.

Add a syntax command

:syntax foldlevel [start | minimum]

to choose between these two methods of computing the foldlevel of
a line.
---
 runtime/doc/syntax.txt | 19 +++
 src/structs.h  |  5 
 src/syntax.c   | 64 ++
 3 files changed, 84 insertions(+), 4 deletions(-)

diff --git a/runtime/doc/syntax.txt b/runtime/doc/syntax.txt
index ae80a44..177f645 100644
--- a/runtime/doc/syntax.txt
+++ b/runtime/doc/syntax.txt
@@ -3480,6 +3480,23 @@ DEFINING CASE		*:syn-case* *E390*
 	items until the next ":syntax case" command are affected.
 
 
+DEFINING FOLDLEVEL	*:syn-foldlevel*
+
+:sy[ntax] foldlevel [start | minimum]
+	This defines how the foldlevel of a line is computed when using
+	foldmethod=syntax (see |fold-syntax| and |:syn-fold|):
+
+	start:		Use level of item containing start of line.
+	minimum:	Use lowest local-minimum level of items on line.
+
+	The default is 'start'.  Use 'minimum' to search a line horizontally
+	for the lowest level contained on the line that is followed by a
+	higher level.  This produces more natural folds when syntax items
+	may close and open horizontally within a line.
+
+	{not meaningful when Vim was compiled without |+folding| feature}
+
+
 SPELL CHECKING		*:syn-spell*
 
 :sy[ntax] spell [toplevel | notoplevel | default]
@@ -3938,6 +3955,8 @@ This will make each {} block form one fold.
 The fold will start on the line where the item starts, and end where the item
 ends.  If the start and end are within the same line, there is no fold.
 The 'foldnestmax' option limits the nesting of syntax folds.
+See |:syn-foldlevel| to control how the foldlevel of a line is computed
+from its syntax items.
 {not available when Vim was compiled without |+folding| feature}
 
 
diff --git a/src/structs.h b/src/structs.h
index 7a4d7fb..184f316 100644
--- a/src/structs.h
+++ b/src/structs.h
@@ -1710,6 +1710,10 @@ typedef struct list_stack_S
 #define SYNSPL_TOP	1	/* spell check toplevel text */
 #define SYNSPL_NOTOP	2	/* don't spell check toplevel text */
 
+/* values for b_syn_foldlevel: how to compute foldlevel on a line */
+#define SYNFLD_START	0	/* use level of item at start of line */
+#define SYNFLD_MINIMUM	1	/* use lowest local minimum level on line */
+
 /* avoid #ifdefs for when b_spell is not available */
 #ifdef FEAT_SPELL
 # define B_SPELL(buf)  ((buf)->b_spell)
@@ -1761,6 +1765,7 @@ typedef struct {
 hashtab_T	b_keywtab_ic;		/* idem, ignore case */
 int		b_syn_error;		/* TRUE when error occurred in HL */
 int		b_syn_ic;		/* 

Re: [PATCH] syntax: Add command to control how foldlevel is computed for a line

[Bram Moolenaar]

Brad King wrote:

> On 10/14/2016 04:04 PM, Bram Moolenaar wrote:
> > Either this needs to be donein the C syntax, or we need an folding
> > option to enable this behavior.
> 
> Thanks for taking a look.  It can't currently be done purely in syntax
> definitions so I've revised the change to add a new syntax command:
> 
> :syntax foldlevel [start | minimum]
> 
> that can be used to enable this.
> 
> With this we will later be able to edit `runtime/syntax/c.vim`
> (and possibly others) to add:
> 
> syntax foldlevel minimum
> 
> (possibly guarded by an option) in order to get this folding behavior.

Thanks.  I suppose that's the best way to do it.

-- 
Close your shells, or I'll kill -9 you
Tomorrow I'll quota you
Remember the disks'll always be full
And then while I'm away
I'll write ~ everyday
And I'll send-pr all my buggings to you.
[ CVS log "Beatles style" for FreeBSD ports/INDEX, Satoshi Asami ]

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.