Re: [vim/vim] Add 'stickybuf' support (PR #13903)

2024-02-17 Fir de Conversatie Tom M
On Sat, Feb 17, 2024 at 8:31 PM Colin Kennedy wrote: > Does :cc still honor the switchbuf=vsplit setting after this change? > > It’s nested in the PR replies currently but I think I asked whether we > need this now in this PR and the consensus was to handle it as a horizontal > split. If people

Re: [vim/vim] Add 'stickybuf' support (PR #13903)

2024-02-17 Fir de Conversatie Colin Kennedy
Yes, we should add that to the documentation for 'switchbuf'. We can always remove the documentation later if/when 'switchbuf' is incorporated into the split behavior. By the way though, I think only uselast is affected. I don’t use vsplit personally but I think vsplit should still work just the

Re: [vim/vim] Add 'stickybuf' support (PR #13903)

2024-02-17 Fir de Conversatie Colin Kennedy
Does :cc still honor the switchbuf=vsplit setting after this change? It’s nested in the PR replies currently but I think I asked whether we need this now in this PR and the consensus was to handle it as a horizontal split. If people want customizations, that can come in another revision. It

Re: New PRs - tests and coverage

2024-02-17 Fir de Conversatie Yee Cheng Chin
I think test coverage is good but I want to make sure we don't end up chasing the coverage % as an absolute goal (which just shows *line* coverage, not functionality coverage). I remember working on some PRs and rewriting some tests, and discovered the tests I was modifying didn't make too much