Re: [virt-tools-list] [virt-viewer] [PATCH 15/15 v2] msi: add gtk3 support

2014-12-10 Thread Christophe Fergeau
Hey, On Wed, Dec 10, 2014 at 01:07:27AM +0100, Fabiano Fidêncio wrote: On Wed, Dec 10, 2014 at 12:59 AM, Marc-André Lureau marcandre.lur...@gmail.com wrote: It's not easy to build atm with f21, because all the dependency are not available. Since current build is broken anyway on f21 and the

Re: [virt-tools-list] [virt-viewer] [PATCH 07/15] nsis: add libwinpthread-1.dll

2014-12-10 Thread Christophe Fergeau
Hey, On Tue, Dec 09, 2014 at 05:13:37PM +0100, Fabiano Fidêncio wrote: libwinpthread-1.dll is a dependency of libvirt I assume this means after this series virsh.exe/virt-viewer.exe can be successfully launched? This was not necessarily the case with past builds of the installer (forgot if this

Re: [virt-tools-list] [virt-manager PATCH] virt-clone: improve some error prompts

2014-12-10 Thread Cole Robinson
On 12/09/2014 10:40 PM, Chen, Hanxiao wrote: -Original Message- From: Cole Robinson [mailto:crobi...@redhat.com] Sent: Tuesday, December 09, 2014 8:05 PM To: Chen, Hanxiao/陈 晗霄; virt-tools-list@redhat.com Subject: Re: [virt-tools-list] [virt-manager PATCH] virt-clone: improve some

Re: [virt-tools-list] [PATCH virt-manager] virtManager: do not fail at connection time if a volume does not exist

2014-12-10 Thread Cole Robinson
On 12/10/2014 05:29 AM, Giuseppe Scrivano wrote: Problem introduced by commit 1662f75e07e8bfb46a552c686e2db3e4368786b6 Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- virtManager/domain.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/virtManager/domain.py

Re: [virt-tools-list] [virt-manager PATCH] tests/testdriver: Don't use invalid uid values

2014-12-10 Thread Cole Robinson
On 12/10/2014 04:08 AM, Martin Kletzander wrote: The value 4294967295 used in the testdriver for sheepdog volume is not valid on 32bit systems as it won't fit in uid_t and libvirt will fail parsing that. Running ./setup.py test then fails with: raise libvirtError('virConnectOpenAuth()

Re: [virt-tools-list] [virt-manager PATCH] tests/testdriver: Don't use invalid uid values

2014-12-10 Thread Martin Kletzander
On Wed, Dec 10, 2014 at 07:03:46AM -0500, Cole Robinson wrote: On 12/10/2014 04:08 AM, Martin Kletzander wrote: The value 4294967295 used in the testdriver for sheepdog volume is not valid on 32bit systems as it won't fit in uid_t and libvirt will fail parsing that. Running ./setup.py test

Re: [virt-tools-list] [virt-viewer] [PATCH 15/15 v2] msi: add gtk3 support

2014-12-10 Thread Fabiano Fidêncio
On Wed, Dec 10, 2014 at 10:03 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Wed, Dec 10, 2014 at 01:07:27AM +0100, Fabiano Fidêncio wrote: On Wed, Dec 10, 2014 at 12:59 AM, Marc-André Lureau marcandre.lur...@gmail.com wrote: It's not easy to build atm with f21, because all the

Re: [virt-tools-list] [PATCH virt-manager] virtManager: do not fail at connection time if a volume does not exist

2014-12-10 Thread Giuseppe Scrivano
Cole Robinson crobi...@redhat.com writes: On 12/10/2014 05:29 AM, Giuseppe Scrivano wrote: Problem introduced by commit 1662f75e07e8bfb46a552c686e2db3e4368786b6 Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- virtManager/domain.py | 5 - 1 file changed, 4 insertions(+), 1

Re: [virt-tools-list] [PATCH virt-viewer] display-vnc: set correct window size when vnc is initialized

2014-12-10 Thread Pavel Grunt
Thank you for the review, I am sending v2. Pavel Pavel, I'd go for a short-log as something like: display-vnc: fix zoom-level set by command line On Wed, Dec 10, 2014 at 10:39 AM, Pavel Grunt pgr...@redhat.com wrote: The display is shrinked when connecting to a vnc guest. Also

[virt-tools-list] [PATCH virt-viewer v2] display-vnc: fix zoom-level set by command line

2014-12-10 Thread Pavel Grunt
Setting the zoom-level using the command line option '--zoom' is not working for vnc guests. This problem can be solved by emitting the display-desktop-resize signal when vnc is initialized. https://bugzilla.redhat.com/show_bug.cgi?id=1170071 --- v2: - commit log changed ---

Re: [virt-tools-list] [PATCH virt-viewer v2] display-vnc: fix zoom-level set by command line

2014-12-10 Thread Fabiano Fidêncio
On Wed, Dec 10, 2014 at 2:07 PM, Pavel Grunt pgr...@redhat.com wrote: Setting the zoom-level using the command line option '--zoom' is not working for vnc guests. This problem can be solved by emitting the display-desktop-resize signal when vnc is initialized.

Re: [virt-tools-list] [PATCH virt-manager] virtManager: do not fail at connection time if a volume does not exist

2014-12-10 Thread Cole Robinson
On 12/10/2014 07:52 AM, Giuseppe Scrivano wrote: Cole Robinson crobi...@redhat.com writes: On 12/10/2014 05:29 AM, Giuseppe Scrivano wrote: Problem introduced by commit 1662f75e07e8bfb46a552c686e2db3e4368786b6 Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- virtManager/domain.py

Re: [virt-tools-list] [PATCH 1/2] Default connection URI if libvirt-daemon-driver-lxc is installed

2014-12-10 Thread Cole Robinson
On 12/05/2014 10:28 AM, Cedric Bosdonnat wrote: Hi Cole, On Fri, 2014-12-05 at 09:49 -0500, Cole Robinson wrote: RH distros use /usr/libexec/libvirt_lxc, so we'd want to add that as well. I can fix that when applying though Oh, I forgot about that... but yes and /usr/lib/libvirt_lxc as well

Re: [virt-tools-list] [PATCH] URL installs: remove hasFile() check

2014-12-10 Thread Cole Robinson
On 12/08/2014 04:43 PM, Gabriel de Perthuis wrote: Specialised proxies like apt-cacher-ng disallow directory listing. OSDistro subclasses do have checks for known files and they are sufficient. --- virtinst/urlfetcher.py | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [virt-tools-list] [PATCH] URL installs: remove hasFile() check

2014-12-10 Thread Cole Robinson
On 12/10/2014 01:49 PM, Cole Robinson wrote: On 12/08/2014 04:43 PM, Gabriel de Perthuis wrote: Specialised proxies like apt-cacher-ng disallow directory listing. OSDistro subclasses do have checks for known files and they are sufficient. --- virtinst/urlfetcher.py | 5 - 1 file changed,

Re: [virt-tools-list] [virt-viewer] [PATCH 15/15 v2] msi: add gtk3 support

2014-12-10 Thread Fabiano Fidêncio
On Wed, Dec 10, 2014 at 1:53 PM, Fabiano Fidêncio fabi...@fidencio.org wrote: On Wed, Dec 10, 2014 at 10:03 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Wed, Dec 10, 2014 at 01:07:27AM +0100, Fabiano Fidêncio wrote: On Wed, Dec 10, 2014 at 12:59 AM, Marc-André Lureau

[virt-tools-list] [virt-manager PATCH] test_urls: remove commented fedora21 alpha urls

2014-12-10 Thread Chen Hanxiao
Discoverd by pep8 '# ' style check. introduced by 92b443df. Guess that you forgot to delete it. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- tests/test_urls.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/test_urls.py b/tests/test_urls.py index c0d7b91..d0f440d

Re: [virt-tools-list] [PATCH] virtinst: refresh pools status before fetch_pools

2014-12-10 Thread Chun Yan Liu
On 12/5/2014 at 09:54 PM, in message 5481b907.4040...@redhat.com, Cole Robinson crobi...@redhat.com wrote: On 12/05/2014 03:40 AM, Chunyan Liu wrote: Currently, when connecting to hypervisor, if there are pools active but in fact target path already deleted (or for other reasons the

[virt-tools-list] [virt-manager PATCH] clitest: replace DIR from current pwd by '/var'

2014-12-10 Thread Chen Hanxiao
Introduced by f16dc4dd34f4f1aa326939cf79fcbdc204e2146f This will cause test case failure on different machines. Use '/var' to replace it. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- tests/cli-test-xml/compare/virt-install-many-devices.xml | 2 +- tests/clitest.py