Re: [virt-tools-list] [virt-manager PATCH] cloner: preserve the disk type in the cloned domain

2017-03-03 Thread Cole Robinson
On 03/03/2017 12:25 PM, Pavel Hrdina wrote: > On Fri, Mar 03, 2017 at 12:02:37PM -0500, Cole Robinson wrote: >> On 03/03/2017 02:19 AM, Pavel Hrdina wrote: >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 >>> >>> Signed-off-by: Pavel Hrdina >>> --- >>>

Re: [virt-tools-list] [virt-manager PATCH] cloner: preserve the disk type in the cloned domain

2017-03-03 Thread Pavel Hrdina
On Fri, Mar 03, 2017 at 12:02:37PM -0500, Cole Robinson wrote: > On 03/03/2017 02:19 AM, Pavel Hrdina wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 > > > > Signed-off-by: Pavel Hrdina > > --- > > virtinst/cloner.py | 2 +- > > 1 file changed, 1

Re: [virt-tools-list] [virt-manager PATCH 1/2] hostdev: add support for specify driver name when adding host device

2017-03-03 Thread Cole Robinson
On 03/03/2017 05:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > When adding host device, we could specify driver names, > such as vfio, xen, etc. We can, but is it important enough to expose in the UI? VFIO is preferred and we want to encourage it, which is why it's

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: add driver_name example in man-page

2017-03-03 Thread Cole Robinson
On 03/03/2017 05:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Give some examples for driver_name of host device. > > Signed-off-by: Chen Hanxiao > --- > man/virt-install.pod | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [virt-tools-list] [virt-manager PATCH] cloner: preserve the disk type in the cloned domain

2017-03-03 Thread Cole Robinson
On 03/03/2017 02:19 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 > > Signed-off-by: Pavel Hrdina > --- > virtinst/cloner.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/cloner.py

[virt-tools-list] [virt-viewer v1] Avoid harmless warnings due lack of oVirt on build

2017-03-03 Thread Victor Toso
From: Victor Toso > remote-viewer.c: In function 'remote_viewer_get_property': > remote-viewer.c:227:26: warning: unused variable 'priv' [-Wunused-variable] > RemoteViewerPrivate *priv = self->priv; > ^~~~ > remote-viewer.c:224:36: warning:

[virt-tools-list] [virt-viewer v1 1/2] Fix build when building without oVirt

2017-03-03 Thread Victor Toso
From: Victor Toso As remote_viewer_iso_list_dialog_new() is defined on remote-viewer-iso-list-dialog.h which is only build with oVirt integration. > undefined reference to `remote_viewer_iso_list_dialog_new' Note that the callback

[virt-tools-list] [PATCH virt-viewer v3 2/2] virt-viewer: Adjust name-id-uuid comment

2017-03-03 Thread Pavel Grunt
virt-viewer by default chooses the VM by its id, then uuid and then by name. Adjust the comment to match the implementation. Related: rhbz#1399077 --- man/virt-viewer.pod | 2 +- src/virt-viewer.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/man/virt-viewer.pod

[virt-tools-list] [PATCH virt-viewer v3 1/2] virt-viewer: Allow more precise VM selection

2017-03-03 Thread Pavel Grunt
Theoretically a VM name can be a valid VM id or uuid. In that case connecting to the VMs may be problematic since virt-viewer selects the VM by its id then by uuid if not found then by its name. Introduce new command line options to cover this situation: "--id" to connect to the VM by its id

[virt-tools-list] [virt-manager PATCH 1/2] hostdev: add support for specify driver name when adding host device

2017-03-03 Thread Chen Hanxiao
From: Chen Hanxiao When adding host device, we could specify driver names, such as vfio, xen, etc. Signed-off-by: Chen Hanxiao --- ui/addhardware.ui | 38 -- virtManager/addhardware.py | 17