On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
Add commands to find out which commands does each group support,
as well as enable their use by driver.
This will be especially useful once we have multiple group types.
An alternative is per-type VQs. This is possible but will
require more per-t
On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
Adding relevant registers needs more work and it's not
clear what the use-case will be as currently only
the PCI transport is supported. But let's keep the
door open on this.
We already say it's reserved in a central place, but it
does not hurt t
On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
Add new registers to the PCI common configuration structure.
These registers will be used for querying the indices of the admin
virtqueues of the owner device. To configure, reset or enable the admin
virtqueues, the driver should follow existing
On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
The admin virtqueues will be the first interface used to issue admin commands.
The admin virtqueue
Currently the virtio specification defines control virtqueue to manipulate
features and configuration of the device it operates on:
virtio-net,
On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
This introduces a general structure for group administration commands,
used to control device groups through their owner.
Following patches will introduce specific commands and an interface for
submitting these commands to the owner.
Note that
On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
Each device group has a type. For now, define one initial group type:
SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given
PCI SR-IOV physical function (PF). This group may contain zero or more
virtio devices according to NumVFs configure
On Wed, Apr 05, 2023 at 03:57:09PM +0200, Cornelia Huck wrote:
> That said, let me propose the following timeline:
>
> - July 1st 2023: enter feature freeze; all proposed changes must at
> least have an open github issue that refers to a proposal on-list
> - August 1st 2023: enter change freeze;
> From: Halil Pasic
> Sent: Wednesday, April 5, 2023 11:28 AM
>
> On Wed, 5 Apr 2023 13:21:40 +
> Parav Pandit wrote:
>
> > > VIRTIO_F_NOTIF_CONFIG_DATA is such a narrow usecase, I don't like
> > > burning "vq identifier" on this. How about we just say something along the
> lines of:
> > >
On Wed, 5 Apr 2023 13:21:40 +
Parav Pandit wrote:
> > VIRTIO_F_NOTIF_CONFIG_DATA is such a narrow usecase, I don't like burning
> > "vq identifier" on this. How about we just say something along the lines of:
> >
> Ok.
> >
> > When VIRTIO_F_NOTIFICATION_DATA has not been negotiated, this
On Wed, 5 Apr 2023 05:12:12 -0400
"Michael S. Tsirkin" wrote:
> > > it's not necessarily an identifier. can be e.g. just 0 for all vqs.
> > > whatever the device needs.
> > For driver its just an id, content doesn't matter.
>
> No, this value might or might not be somehow related to the vq b
Hi Cornelia,
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Cornelia Huck
> Sent: Wednesday, April 5, 2023 9:57 AM
>
> The virtio 1.2 spec has been released on July 1st, 2022, so I think we should
> come up with a plan for the 1.3 release. Given that it took us several months
The virtio 1.2 spec has been released on July 1st, 2022, so I think we
should come up with a plan for the 1.3 release. Given that it took us
several months last time, we need to think about declaring freeze during
(northern hemisphere) summer if we want to have a release ready before
the end-of-yea
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 1:30 AM
> VIRTIO_F_NOTIF_CONFIG_DATA is such a narrow usecase, I don't like burning
> "vq identifier" on this. How about we just say something along the lines of:
>
Ok.
>
> When VIRTIO_F_NOTIFICATION_DATA has not been negotiated,
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 1:22 AM
>
> This is not much of an improvement.
>
> On Wed, Apr 05, 2023 at 04:06:50AM +0300, Parav Pandit wrote:
> > Currently queue_notify_data register indicates the device internal
> > queue notification identifier. This register
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 1:11 AM
> > > > +struct virtio_pcie_ext_cap {
> > > > +struct pcie_ext_cap pcie_ecap;
> > > > +u8 cfg_type; /* Identifies the structure. */
> > > > +u8 bar; /* Index of the BAR where its located */
> > > > +
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 1:33 AM
>
> I like where this is going. I will change AQ patches to be like this, but
> it's holidays
> here in israel so not reposting immediately, pls review assuming I will
> address
> that change.
Yes, will review AQ shortly.
>
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 5:21 AM
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/163
>
> I feel there are now two patchsets here:
> 1. renaming of queue num to queue size
> 2. virtqueue index and rss clarification depending on it
>
> 1 seems mostly
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 5:19 AM
>
> In fact can we just say "virtqueue index" everywhere? The less slang reader
> has
> to learn, the better.
Wow, didn't know that "vq" is a slang. :)
-
T
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 5:18 AM
> following format for \field{command-specific-data}:
> > \begin{lstlisting}
> > +struct rss_rq_id {
> > + le16 vqn_1_16: 15; /* Bits 1 to 16 of the vq index */
>
> Do you want to then call this vq_index_1_16 ?
Yes. will c
> From: Michael S. Tsirkin
> Sent: Wednesday, April 5, 2023 1:26 AM
>
> On Wed, Apr 05, 2023 at 04:06:48AM +0300, Parav Pandit wrote:
> > Introduce vq index and its range so that subsequent patches can refer
> > to it.
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> > Revi
On Wed, Apr 05, 2023 at 02:39:53PM +0200, Alexandra Winter wrote:
>
>
> On 24.03.23 05:03, Wen Gu wrote:
> >
> >
> > On 2023/3/23 22:46, Halil Pasic wrote:
> >
> >> On Thu, 9 Feb 2023 11:30:56 +0800
> >> Xuan Zhuo wrote:
> >>
>
> ...
>
> >
> >> To get back to the things proposed here: the
On Wed, Apr 05, 2023 at 11:24:43AM +0100, Alex Bennée wrote:
>
> "Michael S. Tsirkin" writes:
>
> > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
> >>
> >> Viresh Kumar writes:
> >>
> >> > On 09-03-23, 14:20, Viresh Kumar wrote:
> >> >> Hello,
> >> >>
> >> >> This patchset tri
"Michael S. Tsirkin" writes:
> On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
>>
>> Viresh Kumar writes:
>>
>> > On 09-03-23, 14:20, Viresh Kumar wrote:
>> >> Hello,
>> >>
>> >> This patchset tries to update the vhost-user protocol to make it support
>> >> special
>> >> memor
On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
>
> Viresh Kumar writes:
>
> > On 09-03-23, 14:20, Viresh Kumar wrote:
> >> Hello,
> >>
> >> This patchset tries to update the vhost-user protocol to make it support
> >> special
> >> memory mapping required in case of Xen hypervisor
Viresh Kumar writes:
> On 09-03-23, 14:20, Viresh Kumar wrote:
>> Hello,
>>
>> This patchset tries to update the vhost-user protocol to make it support
>> special
>> memory mapping required in case of Xen hypervisor.
>>
>> The first patch is mostly cleanup and second one introduces a new xen
On Wed, Apr 05 2023, "Michael S. Tsirkin" wrote:
> On Wed, Apr 05, 2023 at 04:06:50AM +0300, Parav Pandit wrote:
>> diff --git a/content.tex b/content.tex
>> index cd93db2..d5f8026 100644
>> --- a/content.tex
>> +++ b/content.tex
>> @@ -405,8 +405,18 @@ \section{Driver Notifications} \label{sec:B
On Wed, Apr 05 2023, Parav Pandit wrote:
> Replace virtqueue number with index to align to rest of the
> specification.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Signed-off-by: Parav Pandit
>
> ---
> changelog:
> v11->v12:
> - new patch
> ---
> content.tex | 8
>
On Wed, Apr 05, 2023 at 04:06:47AM +0300, Parav Pandit wrote:
> 1. Currently, virtqueue is identified between driver and device
> interchangeably using either number or index terminology.
>
> 2. Between PCI and MMIO transport the queue size (depth) is
> defined as queue_size and QueueNum respectiv
On Wed, Apr 05, 2023 at 04:06:48AM +0300, Parav Pandit wrote:
> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Cornelia Huck
> Signed-off-by: Parav Pandit
> ---
> changelog:
> v11->v12:
On Wed, Apr 05, 2023 at 04:06:57AM +0300, Parav Pandit wrote:
> The content of the indirection table and unclassified_queue were
> originally described based on mathematical operations. In order to
> make it easier to understand and to avoid intermixing the array
> index with the vq index, introduc
On Tue, Apr 04, 2023 at 08:50:43PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Tuesday, April 4, 2023 4:14 PM
> >
> > On Tue, Apr 04, 2023 at 03:39:21PM -0400, Parav Pandit wrote:
> > >
> > >
> > > On 4/4/2023 1:44 PM, Michael S. Tsirkin wrote:
> > > > On Tue, Apr 04,
On 09-03-23, 14:20, Viresh Kumar wrote:
> Hello,
>
> This patchset tries to update the vhost-user protocol to make it support
> special
> memory mapping required in case of Xen hypervisor.
>
> The first patch is mostly cleanup and second one introduces a new xen specific
> feature.
Can we apply
32 matches
Mail list logo
