[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Xuan Zhuo
On Mon, 19 Jun 2023 10:25:38 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 15, 2023 at 02:23:31PM +0800, Xuan Zhuo wrote: > > On Tue, 13 Jun 2023 05:02:01 -0400, "Michael S. Tsirkin" > > wrote: > > > On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xuan Zhuo wrote: > > > > On Mon, 12 Jun 2023

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Xuan Zhuo
On Mon, 19 Jun 2023 10:20:56 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jun 19, 2023 at 12:33:33PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Friday, June 16, 2023 10:13 AM > > > > Such as "limit", in a cloud scenario, multiple users purchase > > > >

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:46 PM > These devices have a legacy interface yes? Yes. partially. > So they should be transitional to avoid breaking assumption. > > > But they are not *exactly* > in that they don't

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:17 PM > I'd love to just put this stuff in a separate tex document and just link > there from > the generic thing. > Or if it's too hard, please create new sections for this stuff. But in this > case each > of these sections has to

[virtio-dev] RE: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 10:21 AM > > Yes but Xuan Zhuo here is saying that he wants a register that is like link > speed, > not a counter. > I understand it as counter because Xuan is saying counter. He wrote " The counter is for the user, not for the

[virtio-dev] RE: RE: About custom device counter

2023-06-19 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Thursday, June 15, 2023 2:35 AM > > Debug counters are useful to have. > > I agree that they may be vendor specific. > > We often try to abstract and define as much as vendor neutral as possible. > > > > So we should probably first put our efforts to see if more than

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 2:01 PM > > That flexibility is better gained via AQ instead of introducing new extended > capability on the VF. > > To be frank for e.g. transport vq we'll need to do it with admin command (can > we stop saying AQ please? it's a habit

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:58 PM > > AQ command on the PF is self-contained and extendible without baking things > in very low level hw centric pci capabilities, which are hard to get rid of > it. > > I worry about systems where there's value in having VF

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:45:17PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:38 PM > > > > > If we can't just make it come for free then maybe > > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > > number in the

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:45:17PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:38 PM > > > > > If we can't just make it come for free then maybe > > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > > number in the

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:35:04PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:26 PM > > > > > Also these devices will use non-transitional ID but they in fact do > > > > have a legacy interface so using this definition they are > > > >

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:38 PM > > > If we can't just make it come for free then maybe > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > number in the common section and then link to the description in the new > section. > > > > >

RE: [virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:33 PM > But I am looking for a way to keep this stuff as self contained as possible. > I don't > much care whether the new tex is under pci and admin command section just > lists commands and links there, or it is under admin and then

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:26:22PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:20 PM > > > > It is reused, but it doesnt come for free. > > > Do you want to re-consider AQ notify query command? > > > Or continue as proposed in v6? > > > > > > If

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:26 PM > > > Also these devices will use non-transitional ID but they in fact do > > > have a legacy interface so using this definition they are > > > transitional devices. Maybe we need to add when we describe the > > > device ID text

Re: [virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:21:20PM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:11 PM > > > > The "legacy interface of member device" is a vague term. As implementer, > > reader I don't understand

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:20 PM > > It is reused, but it doesnt come for free. > > Do you want to re-consider AQ notify query command? > > Or continue as proposed in v6? > > > If we can't just make it come for free then maybe >

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:11:19PM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:04 PM > > > On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > > > +Even though virtqueue driver

RE: [virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:11 PM > > The "legacy interface of member device" is a vague term. As implementer, > reader I don't understand what that means. > > The commands clearly communicate the scope. > > Add

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 04:39:16PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 12:38 PM > > > > > > > +\field{legacy_q_notify_supported} when set to 1, indicates that the > > > +device supports legacy queue notifications at this notification > >

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:04 PM > On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > > +Even though virtqueue driver notifications can be communicated > > +through administration virtqueue, if the

[virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 04:45:23PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 12:40 PM > > > > > > > > we can just say "the legacy interface of member devices" > > > > > > > What is the harm in telling explicitly what is currently supported, > >

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > +Even though virtqueue driver notifications can be communicated through > +administration virtqueue, if the group member device support such > +notifications using a memory-mapped operation, such driver notifications > +are sent using

[virtio-dev] RE: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:40 PM > > > > > > we can just say "the legacy interface of member devices" > > > > > What is the harm in telling explicitly what is currently supported, > > specially > when it theory of operation description section. > > The harm

[virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 04:29:43PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 12:21 PM > > > > diff --git a/admin-cmds-legacy-access.tex > > > b/admin-cmds-legacy-access.tex new file mode 100644 index > > > 000..89a4f49 > > > --- /dev/null >

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:38 PM > > > > +\field{legacy_q_notify_supported} when set to 1, indicates that the > > +device supports legacy queue notifications at this notification > > +location. Legacy Queue Notification address is derived within a BAR for a >

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -541,6 +541,8 @@ \subsubsection{Notification structure > layout}\label{sec:Virtio Transport Options > struct virtio_pci_notify_cap { > struct virtio_pci_cap cap; >

[virtio-dev] RE: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:21 PM > > diff --git a/admin-cmds-legacy-access.tex > > b/admin-cmds-legacy-access.tex new file mode 100644 index > > 000..89a4f49 > > --- /dev/null > > +++ b/admin-cmds-legacy-access.tex > > @@ -0,0 +1,138 @@ > >

[virtio-dev] Re: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:11PM +0300, Parav Pandit wrote: > This short series introduces legacy registers access commands for the owner > group member PCI PF to access the legacy registers of the member VFs. > > If in future any SIOV devices to support legacy registers, they > can be easily

[virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:14PM +0300, Parav Pandit wrote: > Introduce group member legacy common configuration and legacy device > configuration access read/write commands. > > Group member legacy registers access commands enable group owner driver > software to access legacy registers on

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > This patch links how in a PCI transport a group owner can access group > member (PCI VFs) legacy registers using a legacy registers access > commands using administration virtqueue infrastructure. > > Additionally it extend the PCI

[virtio-dev] RE: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 11:19 AM > > Just back from travel. I remember having comments, will send in a day or two. > I > don't think we are talking about editorial things though. Let me know what are those new one those were not asked in v4.

[virtio-dev] Re: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 12:38:29PM +, Parav Pandit wrote: > Hi Michael, > > > From: Parav Pandit > > Sent: Tuesday, June 13, 2023 1:30 PM > > > > This short series introduces legacy registers access commands for the owner > > group member PCI PF to access the legacy registers of the member

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Michael S. Tsirkin
On Thu, Jun 15, 2023 at 02:23:31PM +0800, Xuan Zhuo wrote: > On Tue, 13 Jun 2023 05:02:01 -0400, "Michael S. Tsirkin" > wrote: > > On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xuan Zhuo wrote: > > > On Mon, 12 Jun 2023 02:25:42 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Mon, Jun 12, 2023

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 12:33:33PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Friday, June 16, 2023 10:13 AM > > > Such as "limit", in a cloud scenario, multiple users purchase > > > different VMs, and these VMs share the capabilities of the same host. > > > In order

[virtio-dev] RE: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ

2023-06-19 Thread Parav Pandit
Hi Michael, > From: Parav Pandit > Sent: Tuesday, June 13, 2023 1:30 PM > > This short series introduces legacy registers access commands for the owner > group member PCI PF to access the legacy registers of the member VFs. > [..] > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/167

[virtio-dev] RE: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, June 16, 2023 10:13 AM > > Such as "limit", in a cloud scenario, multiple users purchase > > different VMs, and these VMs share the capabilities of the same host. > > In order to ensure that each VM will not affect others, the network > >