RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Heng Qi > Sent: Thursday, February 9, 2023 12:21 AM > Thanks for your reply. > >>> I had one last question. Why do we need to inform the > >> hash_report_tunnel_type of the outer header in the virtio_net_hdr? > >>> Is this for debug? Or is there a use case that will process this va

[virtio-dev] RE: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 9:09 AM > > > header: it allow users inside the tunnel control queueing outside. > > > By observing packet loss some information leaks between tunnels. > > > > > I likely didn't understand. Can you please explain? > > > > Queuing is a

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 02:05:52PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 8:52 AM > > > > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 8:32 AM

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 02:00:14PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 8:52 AM > > > > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 8:32 AM

[virtio-dev] RE: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 8:52 AM > > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 8:32 AM > > > > > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote: >

[virtio-dev] RE: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 8:52 AM > > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 8:32 AM > > > > > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote: >

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 8:32 AM > > > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote: > > > > From: Heng Qi > > > > Sent: Tuesday, February 7, 2023 10:25 PM > > > > > > [..

[virtio-dev] RE: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 8:32 AM > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote: > > > From: Heng Qi > > > Sent: Tuesday, February 7, 2023 10:25 PM > > > > [..] > > > >> > > > >> Do you think we need both hash_types and hash_tunnel_types?

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote: > > From: Heng Qi > > Sent: Tuesday, February 7, 2023 10:25 PM > > [..] > > >> > > >> Do you think we need both hash_types and hash_tunnel_types? > > > In struct virtio_net_config we need two fields. > > > a. supported_hash_types (alre

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-08 Thread Parav Pandit
> From: Heng Qi > Sent: Wednesday, February 8, 2023 1:11 AM > > > 在 2023/2/8 下午1:18, Parav Pandit 写道: > >> From: Heng Qi > >> Sent: Tuesday, February 7, 2023 10:25 PM > > [..] > Do you think we need both hash_types and hash_tunnel_types? > >>> In struct virtio_net_config we need two field

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 10:25 PM [..] > >> > >> Do you think we need both hash_types and hash_tunnel_types? > > In struct virtio_net_config we need two fields. > > a. supported_hash_types (already exists) b. supported_hash_tunnel_type > > -> bitmap indicating for which o

RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 9:31 PM > > 在 2023/1/31 下午1:28, Heng Qi 写道: > > On Mon, Jan 16, 2023 at 04:42:11PM +0800, Jason Wang wrote: > >> 在 2023/1/16 16:01, Heng Qi 写道: > >>> On Wed, Jan 11, 2023 at 04:45:12AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 04, 2023

[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-16 Thread Jason Wang
在 2023/1/16 16:01, Heng Qi 写道: On Wed, Jan 11, 2023 at 04:45:12AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: If the tunnel is used to encapsulate the packets, the hash calculated using the outer header of the receive packets is always fixed for t

[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-16 Thread Cornelia Huck
On Mon, Jan 16 2023, Heng Qi wrote: > On Wed, Jan 11, 2023 at 04:45:12AM -0500, Michael S. Tsirkin wrote: >> On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: >> > @@ -3386,7 +3391,8 @@ \subsection{Device Operation}\label{sec:Device Types >> > / Network Device / Device O >> > le1

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 12:45:06PM +0800, Jason Wang wrote: > On Wed, Jan 11, 2023 at 11:23 AM Heng Qi wrote: > > > > > > > > 在 2023/1/10 下午3:26, Heng Qi 写道: > > > On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: > > >> On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirki

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-10 Thread Jason Wang
On Wed, Jan 11, 2023 at 11:23 AM Heng Qi wrote: > > > > 在 2023/1/10 下午3:26, Heng Qi 写道: > > On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: > >> On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: > This will give extra pressure on the management stack, e.g

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-10 Thread Heng Qi
在 2023/1/10 下午3:26, Heng Qi 写道: On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: This will give extra pressure on the management stack, e.g it requires the device to have an out of spec way for introspecti

[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Heng Qi
在 2023/1/9 下午7:39, Michael S. Tsirkin 写道: Btw this "are defined below" all over the place is just contributing to making the spec unnecesarily verbose. Simple "are:" will do. Sure. I'll fix it in the next version. Thanks. ---

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Heng Qi
On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: > > > This will give extra pressure on the management stack, e.g it requires > > > the device to have an out of spec way for introspection. > > > > > > Thanks >

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S. Tsirkin wrote: > > This will give extra pressure on the management stack, e.g it requires > > the device to have an out of spec way for introspection. > > > > Thanks > > As I tried to explain this is already the case. Feature bits do not > desc

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2023 at 10:06:53AM +0800, Jason Wang wrote: > On Mon, Jan 9, 2023 at 7:34 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > > > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > > > > > On Fri, Jan 06, 2023 at 01:59:38AM -0500,

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Jason Wang
On Mon, Jan 9, 2023 at 7:34 PM Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > > > On Fri, Jan 06, 2023 at 02:42:21PM +0

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 04:59:26PM +0800, Jason Wang wrote: > On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Jan 06, 2023 at 02:42:21PM +0800, Heng Qi wrote: > > > > On Fri, Jan 06, 2023 at 12:27:04AM -0500,

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-09 Thread Jason Wang
On Mon, Jan 9, 2023 at 10:43 AM Heng Qi wrote: > > On Fri, Jan 06, 2023 at 01:59:38AM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 06, 2023 at 02:42:21PM +0800, Heng Qi wrote: > > > On Fri, Jan 06, 2023 at 12:27:04AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Jan 04, 2023 at 03:14:01PM +

[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-05 Thread Michael S. Tsirkin
On Fri, Jan 06, 2023 at 02:42:21PM +0800, Heng Qi wrote: > On Fri, Jan 06, 2023 at 12:27:04AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: > > > If the tunnel is used to encapsulate the packets, the hash calculated > > > using the outer header of the