[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 09:52:54 -0500 > "Michael S. Tsirkin" wrote: > >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: >> > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: >> > >

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
n 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: >> > > > On Sun, Jan 30, 2022 at 11:13:38AM +0200, Max Gurtovoy wrote: >> > > > > On 1/29/2022 5:53 AM, Jason Wang wrote: >> > > > > > On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirki

[virtio-dev] RE: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Tuesday, February 8, 2022 12:13 PM > >> On Tue, Feb 08, 2022 at 06:25:41AM +, Parav Pandit wrote: >> > >> > > From: Michael S. Tsirkin >> > > Sent: Monday, February 7, 2022 4:09 PM >> > > >> > > Next, trying to

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Max Gurtovoy wrote: > On 2/8/2022 8:45 AM, Michael S. Tsirkin wrote: >> On Tue, Feb 08, 2022 at 02:41:44AM +0200, Max Gurtovoy wrote: >>> On 2/7/2022 6:18 PM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2022 at 04:58:19PM +0200, Max Gurtovoy wrote: > On 2/7/2022 12:39

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2022 at 01:32:12PM +, Parav Pandit wrote: >> >> > From: Cornelia Huck >> > Sent: Tuesday, February 8, 2022 6:50 PM >> > >> > On Tue, Feb 08 2022, Parav Pandit wrot

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2022 at 03:59:13PM +0100, Cornelia Huck wrote: >> On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: >> >> > On Tue, Feb 08, 2022 at 01:32:12PM +0000, Parav Pandit wrote: >> >

Re: [virtio-dev] RE: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, February 8, 2022 8:29 PM > >> very specific (essentially PCI-specific), we need to at least answer the >> question >> "how could this work for things that are not PCI?"

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, Max Gurtovoy wrote: > On 2/7/2022 1:51 PM, Cornelia Huck wrote: >> On Mon, Feb 07 2022, "Michael S. Tsirkin" wrote: >> >>> On Mon, Feb 07, 2022 at 12:14:33PM +0200, Max Gurtovoy wrote: >>>> On 2/3/2022 3:09 PM, Cornelia Huck

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, "Michael S. Tsirkin" wrote: > On Mon, Feb 07, 2022 at 12:14:33PM +0200, Max Gurtovoy wrote: >> >> On 2/3/2022 3:09 PM, Cornelia Huck wrote: >> > On Thu, Feb 03 2022, Max Gurtovoy wrote: >> > > +command

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: >> >> > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wro

Re: [virtio-dev] spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-14 Thread Cornelia Huck
On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > It is unfortunate that it does not copy this requirement in more places, > and that the non-conformance text is incomplete and does not > mention the MSI-X usage at all. > > I propose to extend 4.1.4.5 ISR status capability and > 4.1.5.4

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: >> > > above you said bytes sent. >> > >> > I mean, all about GSO are statistics based on big packets. So here is the >> > package from Guest, and rx is the package passed to Guest. >> >> it's a subtle distinction that we need to make. > > I will make this

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: >> On Tue, Jan 18 2022, Xuan Zhuo wrote: >> >> >> > > above you said bytes sent. >> >> > >> >> > I mean, all about GSO are statistic

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-21 Thread Cornelia Huck
On Fri, Jan 21 2022, Halil Pasic wrote: > On Thu, 20 Jan 2022 14:05:37 +0100 > Cornelia Huck wrote: > >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> My take would be:

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: >> On Mon, 17 Jan 2022 17:26:10 -0500 >> "Michael S. Tsirkin" wrote: >> >> > On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 06:50:18PM +0100, Cornelia Huck wrote: >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: >> >

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> On Fri, 14 Jan 2022 17:50:51 -0500 >> "Michael S. Tsirkin" wrote: >> > Subject: virtio: clarify feature negotiation >> > @@ -500,8 +500,13 @@ \section{Device

[virtio-dev] The virtio spec is now in FREEZE for 1.2

2022-01-25 Thread Cornelia Huck
The virtio spec is now in freeze for the upcoming 1.2 release. What does this mean? - No more issues will be accepted into the 1.2 release, i.e. no more votes will be started. Anything outstanding will be delayed until after we have released 1.2 (which we hope to have done by the end of

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > It's true. However, that's a generic rule and specific devices > can differ. and if you look at specific instances, you will > see that they typically require that the feature is negotiated. > For example: > > \item If the VIRTIO_BLK_F_BLK_SIZE

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, Halil Pasic wrote: > On Fri, 21 Jan 2022 17:05:07 +0100 > Cornelia Huck wrote: > >> On Fri, Jan 21 2022, Halil Pasic wrote: >> >> > On Thu, 20 Jan 2022 14:05:37 +0100 >> > Cornelia Huck wrote: >> > >&g

Re: [virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

2022-04-13 Thread Cornelia Huck
On Tue, Jan 25 2022, "Michael S. Tsirkin" wrote: > virtqueues are only discovered after FEATURES_OK. > As such it makes no sense to talk about virtqueues being affected by > features which are offered but not negotiated, and doing so will confuse > the reader. > > Signed-off-by: Michael S.

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-04-07 Thread Cornelia Huck
[sorry about resurrecting an undead thread; I'm trying to collect some editorial changes] On Wed, Jan 26 2022, Jean-Philippe Brucker wrote: > On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote: >> So from that point of view, we are actually relaxing the requirements, >> and yes

Re: [virtio-dev] [PATCH] html: add missing enumitem package

2023-09-28 Thread Cornelia Huck
On Wed, Sep 27 2023, "Michael S. Tsirkin" wrote: > makediffhtml.sh currently fails with: > > ! Missing number, treated as zero. > >\c@* > l.25850 \begin{enumerate}[label=\alph* > .] > ? > ! Emergency stop. > >\c@* >

[virtio-dev] [PATCH virtio-1.3] update acknowledgements for 1.3

2023-08-15 Thread Cornelia Huck
Move some names to the section for previous versions, add names of new contributors, etc. Signed-off-by: Cornelia Huck --- acknowledgements.tex | 124 ++- 1 file changed, 75 insertions(+), 49 deletions(-) diff --git a/acknowledgements.tex b

[virtio-dev] Re: [virtio-comment] [PATCH] revision: update date

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > --- > REVISION-DATE | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@l

[virtio-dev] Re: [virtio] [PATCH] virtio-html.cfg: use variable for spec version

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > this way it gets updated automatically > > Signed-off-by: Michael S. Tsirkin > --- > virtio-html.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[virtio-dev] Re: [virtio-comment] [PATCH] make-setup-generated.sh: get version from spec string

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > make-setup-generated.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck -

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-20 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > Link conformance statements into conformance chapter. > > Signed-off-by: Michael S. Tsirkin > --- > conformance.tex | 9 + > packed-ring.tex | 16 +--- > 2 files changed, 14 insertions(+), 11 deletions(-) Thanks, pushed

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-21 Thread Cornelia Huck
On Wed, Apr 20 2022, "Michael S. Tsirkin" wrote: > On Wed, Apr 20, 2022 at 12:02:03PM +0200, Cornelia Huck wrote: >> On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: >> >> > Link conformance statements into conformance chapter.

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-19 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > Link conformance statements into conformance chapter. > > Signed-off-by: Michael S. Tsirkin > --- > conformance.tex | 9 + > packed-ring.tex | 16 +--- > 2 files changed, 14 insertions(+), 11 deletions(-) > > diff --git

Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Cornelia Huck
On Sun, Apr 24 2022, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: >> Hi, >> >> A recently defined queue_reset register has a little weird definition that >> we should improve. >> When driver initiate queue reset, it writes queue_reset = 1. >> When

[virtio-dev] Re: [PATCH v5 5/7] Add miscellaneous configuration structure for PCI

2022-05-17 Thread Cornelia Huck
On Sun, May 15 2022, "Michael S. Tsirkin" wrote: > On Wed, Apr 27, 2022 at 01:58:22AM +0300, Max Gurtovoy wrote: >> This new structure will be used for adding new miscellaneous registers >> for a virtio device configuration layout. >> >> For now, only admin_queue_index register is added. Admin

[virtio-dev] Re: [virtio-comment] RE: [PATCH v5 2/7] Introduce admin command set

2022-05-17 Thread Cornelia Huck
On Mon, May 16 2022, Parav Pandit wrote: > Hi Michael, > >> From: Michael S. Tsirkin >> Sent: Sunday, May 15, 2022 11:24 AM > > [..] > >> > +\subsection{VIRTIO ADMIN DEVICE CAPS ACCEPT >> command}\label{sec:Basic >> > +Facilities of a Virtio Device / Admin command set / VIRTIO ADMIN >> >

[virtio-dev] Re: [virtio-comment] RE: [PATCH v5 2/7] Introduce admin command set

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > On 5/17/2022 2:48 PM, Michael S. Tsirkin wrote: >> On Mon, May 16, 2022 at 09:08:34PM +, Parav Pandit wrote: >>> Hi Michael, >>> From: Michael S. Tsirkin Sent: Sunday, May 15, 2022 11:24 AM >>> [..] >>> > +\subsection{VIRTIO ADMIN

[virtio-dev] Re: [virtio-comment] Re: [PATCH v5 2/7] Introduce admin command set

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > On 5/15/2022 6:23 PM, Michael S. Tsirkin wrote: >> On Wed, Apr 27, 2022 at 01:58:19AM +0300, Max Gurtovoy wrote: >>> This command set is used for essential administrative and management >>> operations. >>> >>> Admin commands should be submitted to a

[virtio-dev] Re: [virtio-comment] Re: [PATCH v5 1/7] Introduce device group

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > Hi MST, > > On 5/15/2022 6:25 PM, Michael S. Tsirkin wrote: >> On Wed, Apr 27, 2022 at 01:58:18AM +0300, Max Gurtovoy wrote: >>> +\subsection{Device group}\label{sec:Introduction / Terminology / Device >>> group} >>> + >>> +A device group includes one

Re: [virtio-dev] [PATCH v3] virtio_net: support split header

2022-06-07 Thread Cornelia Huck
On Mon, Jun 06 2022, Xuan Zhuo wrote: > The purpose of this feature is to split the header and the payload of > the packet. > > |receive buffer| > | 0th descriptor | 1th descriptor| > | virtnet hdr |

Re: [virtio-dev] [PATCH v5] virtio_net: support split header

2022-07-25 Thread Cornelia Huck
g of used lenght if the first descriptor is skipped > in the case of merge > > v4: > 1. fix typo @Cornelia Huck @Jason Wang > 2. do not split header for IP fragmentation packet. @Jason Wang > > v3: > 1. Fix some syntax issues > 2. Fix some terminology issue

[virtio-dev] Re: [virtio] [PATCH] acknowledgements: update for 1.2

2022-05-02 Thread Cornelia Huck
pecification and are gratefully acknowledged: > > +\subsection*{Participants} > +Alexander Duyck, Intel \newline > +Alex Bennée, Linaro \newline > +Anton Yakovlev, OpenSynergy \newline > +Arseny Krasnov, Kaspersky Lab \newline > +Cornelia Huck, Red Hat \newline > +David Hildenbrand,

[virtio-dev] Re: [PATCH v5] virtio: Improve queue_reset polarity to match to default reset state

2022-05-02 Thread Cornelia Huck
On Fri, Apr 29 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when

RE: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Cornelia Huck
On Thu, Apr 28 2022, Parav Pandit wrote: > All above comments are taken care now with Cornelia's wording for your input > and by correctly updating device side section now. > Sending v3. Honestly, I think it's a bit early for sending a v3 already, since it seems we've not reached complete

[virtio-dev] Re: [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Cornelia Huck
On Wed, Apr 27 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when

Re: [virtio-dev] [PATCH] editorial: use bold for title and headings

2022-05-10 Thread Cornelia Huck
in makehtml.sh for the future. > > Reported-by: Paul Knight > Signed-off-by: Michael S. Tsirkin > --- > makehtml.sh | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) I'm not familiar with .css, but Acked-by: Cornelia Huck --

Re: [virtio-dev] [PATCH] changelog editorial fixes

2022-05-10 Thread Cornelia Huck
gt; Reported-by: Paul Knight > Signed-off-by: Michael S. Tsirkin > --- > cl-os.tex | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Anyway, Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio

Re: [virtio-dev] [PATCH] editorial: update S390 Common I/O link

2022-05-10 Thread Cornelia Huck
On Tue, May 10 2022, "Michael S. Tsirkin" wrote: > Paul Knight wrote: > > In running a link check, I noted several issues, none significant for this > initial public review publication: > - broken link in Normative references: > -- [S390 Common I/O] ESA/390 Common I/O-Device and

[virtio-dev] Re: [PATCH v2] editorial: update S390 Common I/O link

2022-05-10 Thread Cornelia Huck
fication. > > Reported-by: Paul Knight > Suggested-by: Halil Pasic > Signed-off-by: Michael S. Tsirkin > --- > > changes from v1: > do not tweak description just the url > > introductio

[virtio-dev] Re: [PATCH v4] virtio: Improve queue_reset polarity to match to default reset state

2022-04-29 Thread Cornelia Huck
On Fri, Apr 29 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when

Re: [virtio-dev] [PATCH v7] virtio_net: support split header

2022-08-25 Thread Cornelia Huck
beneficial for the zerocopy > implemented by the upper layer. > > Signed-off-by: Xuan Zhuo > Signed-off-by: Heng Qi > Reviewed-by: Kangjie Xu > --- > v7: > 1. Fix some presentation issues. > 2. Use "split transport header". @Jason Wang > 3.

Re: [virtio-dev] [PATCH v5] virtio-blk: add zoned block device specification

2022-08-29 Thread Cornelia Huck
On Sun, Aug 28 2022, Dmitry Fomichev wrote: > Introduce support for Zoned Block Devices to virtio. > > Zoned Block Devices (ZBDs) aim to achieve a better capacity, latency > and/or cost characteristics compared to commonly available block > devices by getting the entire LBA space of the device

Re: [virtio-dev] [PATCH] content: reserve device ID 43 for Camera device

2022-10-21 Thread Cornelia Huck
On Fri, Oct 14 2022, hrishivarya.bhageerad...@opensynergy.com wrote: > From: Hrishivarya Bhageeradhan > > The virtio-camera device allows to stream a camera video with > ability to change controls, formats and get camera captures. > This patch is to reserve the next available device ID for >

Re: [virtio-dev] [PATCH] audio->sound

2022-09-08 Thread Cornelia Huck
ce \\ > +25 & Sound device \\ > \hline > 26 & file system device \\ > \hline Reviewed-by: Cornelia Huck Actually, under the title "Sound device", the spec says "The virtio sound card is a virtual audio device..." -- should it be &

Re: [virtio-dev] [PATCH v3 1/4] content: Introduce driver/device auxiliary notifications

2022-10-11 Thread Cornelia Huck
On Fri, Oct 07 2022, Usama Arif wrote: > Driver auxiliary notifications allow the device to send notifications > other than configuration changes and used buffer notifications to the > driver, these are optional and their meaning is device-specific. > > Device auxiliary notifications allow the

[virtio-dev] Re: [PATCH v6] virtio-blk: add zoned block device specification

2022-09-30 Thread Cornelia Huck
e following people for their useful feedback >> and suggestions while working on the initial iterations of this patch. >> >> Damien Le Moal >> Matias Bjørling >> Niklas Cassel >> Hans Holmberg >> >> Fixes: https://github.com/oasis-tcs/virtio-spec

[virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-10 Thread Cornelia Huck
On Wed, Aug 10 2022, "Michael S. Tsirkin" wrote: > On Wed, Aug 10, 2022 at 11:54:35AM +0200, Cornelia Huck wrote: >> On Tue, Aug 09 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Mar 30, 2022 at 04:21:02PM +0100, Usama Arif wrote: >>

[virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-10 Thread Cornelia Huck
On Tue, Aug 09 2022, "Michael S. Tsirkin" wrote: > On Wed, Mar 30, 2022 at 04:21:02PM +0100, Usama Arif wrote: >> Driver auxiliary notifications allow the device to send notifications >> other than configuration changes and used buffer notifications to the >> driver, these are optional and their

Re: [virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-11 Thread Cornelia Huck
On Wed, Aug 10 2022, "Michael S. Tsirkin" wrote: > On Wed, Aug 10, 2022 at 07:41:08PM +0200, Halil Pasic wrote: >> On Wed, 10 Aug 2022 11:54:35 +0200 >> Cornelia Huck wrote: >> > This highlights another problem, however: When we introduce new features >

Re: [virtio-dev] Re: [PATCH] virtio_net: support split header

2022-08-04 Thread Cornelia Huck
On Thu, Aug 04 2022, Heng Qi wrote: > 在 2022/8/4 下午2:27, Jason Wang 写道: >> On Mon, Aug 1, 2022 at 2:59 PM Heng Qi wrote: >>> @@ -3820,9 +3826,13 @@ \subsubsection{Processing of Incoming >>> Packets}\label{sec:Device Types / Network >>> driver MUST NOT use the \field{csum_start} and

Re: [virtio-dev] Re: [PATCH] virtio_net: support split header

2022-08-09 Thread Cornelia Huck
On Fri, Aug 05 2022, Heng Qi wrote: > 在 2022/8/4 下午9:50, Cornelia Huck 写道: >> On Thu, Aug 04 2022, Heng Qi wrote: >> >>> 在 2022/8/4 下午2:27, Jason Wang 写道: >>>> On Mon, Aug 1, 2022 at 2:59 PM Heng Qi wrote: >>>>> @@ -3820,9 +3826,13 @@ \

[virtio-dev] Re: [PATCH v4] virtio_net: support inner header hash

2022-12-22 Thread Cornelia Huck
On Wed, Dec 21 2022, Heng Qi wrote: > If the tunnel is used to encapsulate the packets, the hash calculated > using the outer header of the receive packets is always fixed for the > same flow packets, i.e. they will be steered to the same receive queue. > > We add a tunnel feature bit

[virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > On Mon, Jan 09, 2023 at 06:28:29PM +0200, Parav Pandit wrote: >> Relatively several of the recent device specifications are maintained >> in their own specification file. Such separate files enables better >> maintenance of the specification

RE: [virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Tue, Jan 10 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, January 10, 2023 10:21 AM >> >> On Tue, Jan 10 2023, Parav Pandit wrote: >> >> >> From: virtio-dev@lists.oasis-open.org >> >> On Behalf Of Cornelia Huc

RE: [virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Tue, Jan 10 2023, Parav Pandit wrote: >> From: virtio-dev@lists.oasis-open.org On >> Behalf Of Cornelia Huck >> >> On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: >> > Does makediff still work? Documentation says latexpand does not >&g

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Xuan Zhuo wrote: > On Thu, 12 Jan 2023 09:42:05 +0100, Cornelia Huck wrote: >> On Thu, Jan 12 2023, "Michael S. Tsirkin" wrote: >> >> > On Thu, Jan 12, 2023 at 10:01:25AM +0800, Jason Wang wrote: >> >> On We

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Halil Pasic wrote: > On Thu, 12 Jan 2023 15:30:58 +0100 > Cornelia Huck wrote: > >> >> >> >> I like that: we don't want to talk about hosts/VMMs/etc. as we >> >> fundamentally deal with devices and drivers, but sharing between g

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Alexandre Courbot wrote: > Hi Cornelia, > > On Wed, Jan 11, 2023 at 5:45 PM Cornelia Huck wrote: >> >> > + >> >> > +The device MUST set the \field{caps_length} field to a value equal to >> >> > +the response size of VIRT

[virtio-dev] Re: [PATCH v3 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [PATCH v3 11/20] virtio-vsock: Maintain socket device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Cornelia Huck
On Thu, Jan 12 2023, Parav Pandit wrote: > Relatively several of the recent device specifications are maintained > in their own specification file. Such separate files enables better > maintenance of the specification overall. > However, several of the initial virtio device specifications > are

[virtio-dev] Re: [virtio-comment] [PATCH v1 17/20] virtio-i2c: Maintain i2c device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

Re: [virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, Cornelia Huck wrote: > On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > >> On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >>> On Sun, Jan 01 2023, Parav Pandit wrote: >>> >>> > Place device specificati

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 15/20] virtio-sound: Maintain sound device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >> On Sun, Jan 01 2023, Parav Pandit wrote: >> >> > Place device specification, its driver and device >> > conformance into its

[virtio-dev] Re: [virtio-comment] [PATCH v1 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Cornelia Huck
On Tue, Dec 27 2022, Alexandre Courbot wrote: > Hi Cornelia, thanks for the feedback! I have directly reported the > comments snipped from this answer to the source document. > > On Fri, Dec 9, 2022 at 12:01 AM Cornelia Huck wrote: >> >> On Thu, Dec 08 2022,

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, David Hildenbrand wrote: > On 11.01.23 16:01, Parav Pandit wrote: >> Hi David, > > Hi Parav, > >> >>> From: David Hildenbrand >>> Sent: Wednesday, January 11, 2023 9:14 AM >>> To: Parav Pandit ; m...@redhat.com; >>> virtio-dev@lists.oasis- >>> open.org; coh...@redhat.com

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
roduce a catchy name for the >> > > > "entity that launched the VMs" and prevent oversimplification by >> > > > explaining any shortcomings of the name if any in one place. Host would >> > > > be one candidate, VMM another. &g

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-08 Thread Cornelia Huck
On Thu, Dec 08 2022, Alexandre Courbot wrote: > Add the specification of the video decoder and encoder devices, which > can be used to provide host-accelerated video operations to the guest. > > Signed-off-by: Keiichi Watanabe > Signed-off-by: Alexandre Courbot > -- > Here is the long-overdue

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-20 Thread Cornelia Huck
On Tue, Dec 20 2022, Alexander Gordeev wrote: > Hello Cornelia, > > On 20.12.22 10:51, Cornelia Huck wrote: >> On Mon, Dec 19 2022, Alexander Gordeev >> wrote: >> >>> Hello Alexandre, >>> >>> Thanks for the update. Please check m

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-20 Thread Cornelia Huck
On Mon, Dec 19 2022, Alexander Gordeev wrote: > Hello Alexandre, > > Thanks for the update. Please check my comments below. > I'm new to the virtio video spec development, so I may lack some > historic perspective. I would gladly appreciate pointing me to some > older emails explaining

Re: [virtio-dev] Re: [PATCH v3] virtio_net: support inner header hash

2022-12-14 Thread Cornelia Huck
If the reviewers do not have more comments on >> I plan to review this no later than the end of this week. > > Okay, I see. > > @Cornelia Huck, Although I have submitted the voting issue, please wait > for a while for @Jason Wang to review, thank you. Ack, will do. (I'm not

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > The admin virtqueues will be the first interface to issue admin commands. > > Currently virtio specification defines control virtqueue to manipulate > features and configuration of the device it operates on. However, > control virtqueue commands

[virtio-dev] Re: [PATCH v8 7/9] ccw: document ADMIN_VQ as reserved

2022-11-22 Thread Cornelia Huck
On Mon, Nov 21 2022, "Michael S. Tsirkin" wrote: > OK I think for now the following is sufficient, right? > Separately, we should make an effort to document that these > features are transport specific and not supported on all transports: > happily VIRTIO_F_RING_RESET is only used in

[virtio-dev] Re: [PATCH v8 2/9] admin: introduce device group and related concepts

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Each device group has a type. For now, define one initial group: > > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given > PCI SR-IOV physical function (PF). This group may contain one or more > virtio devices. > > Each device within a

[virtio-dev] Re: [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-24 Thread Cornelia Huck
On Thu, Nov 24 2022, "Michael S. Tsirkin" wrote: > On Thu, Nov 24, 2022 at 03:34:19PM +0800, Jason Wang wrote: >> On Thu, Nov 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: >> > >> > On Thu, Nov 24, 2022 at 12:33:52PM +0800, Jason Wang wrote: >> > > On Thu, Nov 24, 2022 at 5:08 AM Michael S.

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-24 Thread Cornelia Huck
On Thu, Nov 24 2022, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: >> +The device MUST support device-readable and device-writeable buffers >> +shorter than described in this specification, by >> +\begin{enumerate} >> +\item assuming that any data that would be

Re: [virtio-dev] Re: [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-24 Thread Cornelia Huck
On Thu, Nov 24 2022, "Michael S. Tsirkin" wrote: > On Thu, Nov 24, 2022 at 03:37:42PM +0800, Jason Wang wrote: >> On Thu, Nov 24, 2022 at 3:08 PM Michael S. Tsirkin wrote: >> > >> > On Thu, Nov 24, 2022 at 01:41:41PM +0800, Jason Wang wrote: >> > > On Thu, Nov 24, 2022 at 5:08 AM Michael S.

Re: [virtio-dev] Re: [PATCH v9 03/10] admin: introduce group administration commands

2022-11-24 Thread Cornelia Huck
On Thu, Nov 24 2022, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: >> +All the group administration commands are of the following form: >> + >> +\begin{lstlisting} >> +struct virtio_admin_cmd { >> +/* Device-readable part */ >> +le16 opcode; >> +

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add commands to find out which commands does each group support, > as well as enable their use by driver. > This will be especially useful once we have multiple group types. > > Signed-off-by: Max Gurtovoy > Signed-off-by: Michael S. Tsirkin >

[virtio-dev] Re: [PATCH v8 9/9] admin: conformance clauses

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add conformance clauses for admin commands and admin virtqueues. > > Signed-off-by: Michael S. Tsirkin > --- > admin.tex | 122 ++ > 1 file changed, 122 insertions(+) > > diff --git

[virtio-dev] Re: [PATCH v8 5/9] pci: add admin vq registers to virtio over pci

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Add new registers to the PCI common configuration structure. > > These registers will be used for querying the indices of the admin > virtqueues of the owner device. To configure, reset or enable the admin > virtqueues, the driver should follow

[virtio-dev] Re: [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, Jason Wang wrote: > 在 2022/11/24 20:05, Cornelia Huck 写道: >> On Thu, Nov 24 2022, "Michael S. Tsirkin" wrote: >> >>> On Thu, Nov 24, 2022 at 03:34:19PM +0800, Jason Wang wrote: >>>> On Thu, Nov 24, 2022 at 2:59 PM Michael S. Ts

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, "Michael S. Tsirkin" wrote: > On Fri, Nov 25, 2022 at 12:42:23PM +0100, Cornelia Huck wrote: >> On Fri, Nov 25 2022, Jason Wang wrote: >> >> > 在 2022/11/24 16:36, Michael S. Tsirkin 写道: >> >> On Thu, Nov 24, 2022 at 02:51:21PM

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, Jason Wang wrote: > 在 2022/11/24 16:36, Michael S. Tsirkin 写道: >> On Thu, Nov 24, 2022 at 02:51:21PM +0800, Jason Wang wrote: >>> On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: +The device MUST NOT fail a command solely because the buffers +provided are

Re: [virtio-dev] Re: [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, Jason Wang wrote: > 在 2022/11/24 20:12, Cornelia Huck 写道: >> On Thu, Nov 24 2022, "Michael S. Tsirkin" wrote: >> >>> On Thu, Nov 24, 2022 at 03:37:42PM +0800, Jason Wang wrote: >>>> On Thu, Nov 24, 2022 at 3:08 PM Michael S. Ts

[virtio-dev] Re: [PATCH v8 3/9] admin: introduce group administration commands

2022-11-22 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > This introduces a general structure for group administration commands, > used to control device groups through their owner. > > Following patches will introduce specific commands and an interface for > submitting these commands to the owner. > >

[virtio-dev] Re: [PATCH v8 7/9] ccw: document ADMIN_VQ as reserved

2022-11-21 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Adding relevant registers needs more work and it's not > clear what the use-case will be as currently only > the PCI transport is supported. But let's keep the > door open on this. > We already say it's reserved in a central place, but it > does

[virtio-dev] Re: [PATCH v8 1/9] virtio: document forward compatibility guarantees

2022-11-21 Thread Cornelia Huck
On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Feature negotiation forms the basis of forward compatibility > guarantees of virtio but has never been properly documented. > Do it now. > > Suggested-by: Halil Pasic > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 37

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 04:25:23PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Using 0x instead of h suffix? Sure. > > We should probably document the syntax in in

[virtio-dev] Re: [PATCH v8 9/9] admin: conformance clauses

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 05:06:04PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> > +List of supported commands MUST NOT change: after reporting a >> >> s/L

<    1   2   3   4   5   6   7   >