Re: [PATCH v4 1/6] vdpa/mlx5: Remove redundant header file inclusion

2021-08-25 Thread Jason Wang
在 2021/8/24 下午6:52, Eli Cohen 写道: On Tue, Aug 24, 2021 at 05:08:12PM +0800, Jason Wang wrote: 在 2021/8/23 下午1:21, Eli Cohen 写道: linux/if_vlan.h is not required. Remove it. Signed-off-by: Eli Cohen Acked-by: Jason Wang (btw, some of my acks for previous version were lost). Thanks for

Re: [PATCH net-next] sock: remove one redundant SKB_FRAG_PAGE_ORDER macro

2021-08-25 Thread Jason Wang
On Thu, Aug 26, 2021 at 10:51 AM Yunsheng Lin wrote: > > Both SKB_FRAG_PAGE_ORDER are defined to the same value in > net/core/sock.c and drivers/vhost/net.c. > > Move the SKB_FRAG_PAGE_ORDER definition to net/core/sock.h, > as both net/core/sock.c and drivers/vhost/net.c include it, > and it

Re: [PATCH v2 1/3] /dev/mem: disallow access to explicitly excluded system RAM regions

2021-08-25 Thread David Hildenbrand
On 25.08.21 19:07, Dan Williams wrote: On Wed, Aug 25, 2021 at 12:23 AM David Hildenbrand wrote: On 25.08.21 02:58, Dan Williams wrote: On Mon, Aug 16, 2021 at 7:25 AM David Hildenbrand wrote: virtio-mem dynamically exposes memory inside a device memory region as system RAM to Linux,

Re: [PATCH v2 1/3] /dev/mem: disallow access to explicitly excluded system RAM regions

2021-08-25 Thread Dan Williams
On Wed, Aug 25, 2021 at 12:23 AM David Hildenbrand wrote: > > On 25.08.21 02:58, Dan Williams wrote: > > On Mon, Aug 16, 2021 at 7:25 AM David Hildenbrand wrote: > >> > >> virtio-mem dynamically exposes memory inside a device memory region as > >> system RAM to Linux, coordinating with the

Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range}

2021-08-25 Thread Bjorn Helgaas
On Tue, Aug 24, 2021 at 01:50:00PM -0700, Andi Kleen wrote: > > On 8/24/2021 1:31 PM, Bjorn Helgaas wrote: > > On Tue, Aug 24, 2021 at 01:14:02PM -0700, Andi Kleen wrote: > > > On 8/24/2021 11:55 AM, Bjorn Helgaas wrote: > > > > [+cc Rajat; I still don't know what "shared memory with a hypervisor

[PATCH v1] virtio-mem: fix sleeping in RCU read side section in virtio_mem_online_page_cb()

2021-08-25 Thread David Hildenbrand
virtio_mem_set_fake_offline() might sleep now, and we call it under rcu_read_lock(). To fix it, simply move the rcu_read_unlock() further up, as we're done with the device. Reported-by: Dan Carpenter Fixes: 6cc26d77613a: "virtio-mem: use page_offline_(start|end) when setting PageOffline() Cc:

Re: [bug report] virtio-mem: use page_offline_(start|end) when setting PageOffline()

2021-08-25 Thread David Hildenbrand
On 25.08.21 11:40, Dan Carpenter wrote: Hello David Hildenbrand, The patch 6cc26d77613a: "virtio-mem: use page_offline_(start|end) when setting PageOffline()" from Jun 30, 2021, leads to the following Smatch static checker warning: drivers/virtio/virtio_mem.c:1072

Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-25 Thread Will Deacon
On Tue, Aug 24, 2021 at 02:08:33PM -0400, Michael S. Tsirkin wrote: > On Wed, Aug 18, 2021 at 08:06:31PM +0800, Xie Yongji wrote: > > Export alloc_iova_fast() and free_iova_fast() so that > > some modules can make use of the per-CPU cache to get > > rid of rbtree spinlock in alloc_iova() and

[bug report] virtio-mem: use page_offline_(start|end) when setting PageOffline()

2021-08-25 Thread Dan Carpenter
Hello David Hildenbrand, The patch 6cc26d77613a: "virtio-mem: use page_offline_(start|end) when setting PageOffline()" from Jun 30, 2021, leads to the following Smatch static checker warning: drivers/virtio/virtio_mem.c:1072 virtio_mem_set_fake_offline() warn: sleeping in atomic

Re: [PATCH v2 1/3] /dev/mem: disallow access to explicitly excluded system RAM regions

2021-08-25 Thread David Hildenbrand
On 25.08.21 02:58, Dan Williams wrote: On Mon, Aug 16, 2021 at 7:25 AM David Hildenbrand wrote: virtio-mem dynamically exposes memory inside a device memory region as system RAM to Linux, coordinating with the hypervisor which parts are actually "plugged" and consequently usable/accessible.