Re: [PATCH 1/2] i2c: virtio: disable timeout handling

2021-11-02 Thread Viresh Kumar
On 03-11-21, 06:18, Chen, Conghui wrote: > >>> Over the long term, I think the backend should provide that timeout > >>> value and guarantee that its processing time should not exceed that > >>> value. > >> If you mean that the spec should be changed to allow the virtio driver > >> to be able to pr

Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq

2021-11-02 Thread Jason Wang
On Tue, Nov 2, 2021 at 4:10 PM Eugenio Perez Martin wrote: > > On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote: > > > > On Sat, Oct 30, 2021 at 2:44 AM Eugenio Pérez wrote: > > > > > > This allows it to test if the guest has aknowledge an invalid transport > > > feature for SVQ. This will includ

Re: [RFC PATCH v5 23/26] util: Add iova_tree_alloc

2021-11-02 Thread Jason Wang
On Tue, Nov 2, 2021 at 4:29 PM Eugenio Perez Martin wrote: > > On Tue, Nov 2, 2021 at 7:35 AM Jason Wang wrote: > > > > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > > This iova tree function allows it to look for a hole in allocated > > > regions and return a totally new translation for a given

Re: [PATCH v2 01/12] kexec: Allow architecture code to opt-out at runtime

2021-11-02 Thread Eric W. Biederman
Joerg Roedel writes: > Hi again, > > On Mon, Nov 01, 2021 at 04:11:42PM -0500, Eric W. Biederman wrote: >> I seem to remember the consensus when this was reviewed that it was >> unnecessary and there is already support for doing something like >> this at a more fine grained level so we don't need

Re: [PATCH v2 01/12] kexec: Allow architecture code to opt-out at runtime

2021-11-02 Thread Borislav Petkov
On Mon, Nov 01, 2021 at 04:11:42PM -0500, Eric W. Biederman wrote: > I seem to remember the consensus when this was reviewed that it was > unnecessary and there is already support for doing something like > this at a more fine grained level so we don't need a new kexec hook. Well, the executive su

Re: [PATCH v2 01/12] kexec: Allow architecture code to opt-out at runtime

2021-11-02 Thread Joerg Roedel
Hi again, On Mon, Nov 01, 2021 at 04:11:42PM -0500, Eric W. Biederman wrote: > I seem to remember the consensus when this was reviewed that it was > unnecessary and there is already support for doing something like > this at a more fine grained level so we don't need a new kexec hook. Forgot to s

Re: [PATCH v2 01/12] kexec: Allow architecture code to opt-out at runtime

2021-11-02 Thread Joerg Roedel
On Mon, Nov 01, 2021 at 04:11:42PM -0500, Eric W. Biederman wrote: > I seem to remember the consensus when this was reviewed that it was > unnecessary and there is already support for doing something like > this at a more fine grained level so we don't need a new kexec hook. It was a discussion, n

Re: [PATCH] drm/virtio: delay pinning the pages till first use

2021-11-02 Thread Chia-I Wu
On Tue, Nov 2, 2021 at 6:07 AM Gerd Hoffmann wrote: > > On Tue, Nov 02, 2021 at 12:31:39PM +0100, Maksym Wezdecki wrote: > > From: mwezdeck > > > > The idea behind the commit: > > 1. not pin the pages during resource_create ioctl > > 2. pin the pages on the first use during: > > - trans

Re: [PATCH] drm/virtio: delay pinning the pages till first use

2021-11-02 Thread Gerd Hoffmann
On Tue, Nov 02, 2021 at 12:31:39PM +0100, Maksym Wezdecki wrote: > From: mwezdeck > > The idea behind the commit: > 1. not pin the pages during resource_create ioctl > 2. pin the pages on the first use during: > - transfer_*_host ioctl > - map ioctl i.e. basically lazy pinning.

[PATCH] drm/virtio: delay pinning the pages till first use

2021-11-02 Thread Maksym Wezdecki
From: mwezdeck The idea behind the commit: 1. not pin the pages during resource_create ioctl 2. pin the pages on the first use during: - transfer_*_host ioctl - map ioctl 3. introduce new ioctl for pinning pages on demand This change has no impact on user space. Signed-off

Re: [PATCH v2 1/3] virtio: cache indirect desc for split

2021-11-02 Thread Xuan Zhuo
On Sun, 31 Oct 2021 10:46:12 -0400, Michael S. Tsirkin wrote: > On Thu, Oct 28, 2021 at 06:49:17PM +0800, Xuan Zhuo wrote: > > In the case of using indirect, indirect desc must be allocated and > > released each time, which increases a lot of cpu overhead. > > > > Here, a cache is added for indire

Re: [PATCH v2 1/3] virtio: cache indirect desc for split

2021-11-02 Thread Xuan Zhuo
On Tue, 02 Nov 2021 14:35:39 +0800, Xuan Zhuo wrote: > On Sun, 31 Oct 2021 10:46:12 -0400, Michael S. Tsirkin > wrote: > > On Thu, Oct 28, 2021 at 06:49:17PM +0800, Xuan Zhuo wrote: > > > In the case of using indirect, indirect desc must be allocated and > > > released each time, which increase

Re: [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding

2021-11-02 Thread Jason Wang
在 2021/10/30 上午2:35, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There are no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices uses forced IOMMU, this means that SVQ is not usable at th

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

2021-11-02 Thread Jason Wang
在 2021/10/30 上午2:35, Eugenio Pérez 写道: If device supports host notifiers, this makes one jump less (kernel) to deliver SVQ notifications to it. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 2 ++ hw/virtio/vhost-shadow-virtqueue.c | 23 ++- 2 fi

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. > > To fix this, just resort to the lower even number of queues. > > Fix

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the >> > case, and the device

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > Command to set shadow virtqueue mode. > > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela You need to keep care of: Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling unstable interfaces When this hit the tree, you need to drop the x- an

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: > Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > > case, and the device may have a pair number of queues. >

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. even I know, I know, I am Spanis

Re: [PATCH v2 1/3] virtio: cache indirect desc for split

2021-11-02 Thread Xuan Zhuo
On Sun, 31 Oct 2021 10:46:12 -0400, Michael S. Tsirkin wrote: > On Thu, Oct 28, 2021 at 06:49:17PM +0800, Xuan Zhuo wrote: > > In the case of using indirect, indirect desc must be allocated and > > released each time, which increases a lot of cpu overhead. > > > > Here, a cache is added for indire