Re: Can vhost translate to io_uring?

2023-06-14 Thread Mike Christie
On 6/14/23 1:25 AM, michael.chris...@oracle.com wrote: > It would be nice if the vhost layer could use the io-wq code as sort of > generic worker. I can look into what that would take if Jens is ok > with that type of thing. We could use the io-wq code, but we hit the same problems as before: 1.

Re: [CFT][PATCH v3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

2023-06-14 Thread Oleg Nesterov
On 06/11, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > Could you spell to explain why this can't work (again, in this simple case) > > ? > > > > My current (and I know, very poor) understanding is that .release() should > > roughly do the following: > > > > 1. Ensure that

Re: Can vhost translate to io_uring?

2023-06-14 Thread Michael S. Tsirkin
On Wed, Jun 14, 2023 at 01:02:58AM -0500, Eric W. Biederman wrote: > At a quick glance it looks like io_uring already supports the > functionality that vhost supports (which I think is networking and > scsi). There's vsock too. -- MST ___

Re: Can vhost translate to io_uring?

2023-06-14 Thread Jens Axboe
On 6/14/23 12:25?AM, michael.chris...@oracle.com wrote: > On 6/14/23 1:02 AM, Eric W. Biederman wrote: >> >> I am sad my idea for simplifying things did not work out. >> >> >> Let's try an even bigger idea to reduce maintenance and simplify things. >> >> Could vhost depend on io_uring? >> >> Could

Re: Can vhost translate to io_uring?

2023-06-14 Thread Michael S. Tsirkin
On Wed, Jun 14, 2023 at 01:02:58AM -0500, Eric W. Biederman wrote: > > I am sad my idea for simplifying things did not work out. > > > Let's try an even bigger idea to reduce maintenance and simplify things. > > Could vhost depend on io_uring? > > Could vhost just be a translation layer of

[PATCH] vduse: fix NULL pointer dereference

2023-06-14 Thread Maxime Coquelin
vduse_vdpa_set_vq_affinity callback can be called with NULL value as cpu_mask when deleting the vduse device. This patch clears virtqueue's IRQ affinity mask value instead of dereferencing NULL cpu_mask. [ 4760.952149] BUG: kernel NULL pointer dereference, address: [

Re: Can vhost translate to io_uring?

2023-06-14 Thread michael . christie
On 6/14/23 1:02 AM, Eric W. Biederman wrote: > > I am sad my idea for simplifying things did not work out. > > > Let's try an even bigger idea to reduce maintenance and simplify things. > > Could vhost depend on io_uring? > > Could vhost just be a translation layer of existing vhost requests

Can vhost translate to io_uring?

2023-06-14 Thread Eric W. Biederman
I am sad my idea for simplifying things did not work out. Let's try an even bigger idea to reduce maintenance and simplify things. Could vhost depend on io_uring? Could vhost just be a translation layer of existing vhost requests to io_uring requests? At a quick glance it looks like