Re: [V2 RFC net-next PATCH 2/2] virtio_net: export more statistics through ethtool

2012-06-07 Thread David Miller
From: Ben Hutchings Date: Thu, 7 Jun 2012 18:15:06 +0100 > I would really like to see some sort of convention for presenting > per-queue statistics through ethtool. At the moment we have a complete > mess of different formats: Indeed. Probably ${QUEUE_TYPE}-${INDEX}-${STATISTIC} is best. With

Re: [PATCH repost] virtio-net: remove useless disable on freeze

2012-05-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 30 May 2012 17:21:29 +0300 > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. > In particular it doesn't have any effect when > event index is on. > > Instead, detach, napi disable and reset on freeze ensure we don't ru

Re: [PATCH RESENT] xen: do not disable netfront in dom0

2012-05-22 Thread David Miller
From: Marek Marczykowski Date: Sun, 20 May 2012 13:45:10 +0200 > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > is the only way to get network access in dom0. > > Signed-off-by: Marek

Re: [Xen-devel] [PATCH] xen: do not disable netfront in dom0

2012-05-22 Thread David Miller
From: Ian Campbell Date: Tue, 22 May 2012 20:30:28 +0100 > On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote: >> From: Marek Marczykowski >> Date: Sun, 20 May 2012 13:45:10 +0200 >> >> > Netfront driver can be also useful in dom0, eg when all NICs are assigne

Re: [PATCH] xen: do not disable netfront in dom0

2012-05-22 Thread David Miller
From: Marek Marczykowski Date: Sun, 20 May 2012 13:45:10 +0200 > Netfront driver can be also useful in dom0, eg when all NICs are assigned to > some domU (aka driver domain). Then using netback in domU and netfront in dom0 > is the only way to get network access in dom0. > > Signed-off-by: Marek

Re: [PATCH] virtio_net: invoke softirqs after __napi_schedule

2012-05-16 Thread David Miller
From: Rusty Russell Date: Thu, 17 May 2012 13:02:53 +0930 > On Wed, 16 May 2012 10:57:13 +0300, "Michael S. Tsirkin" > wrote: >> __napi_schedule might raise softirq but nothing >> causes do_softirq to trigger, so it does not in fact >> run. As a result, >> the error message "NOHZ: local_softirq

Re: [net-next V7 PATCH] virtio-net: send gratuitous packets when needed

2012-04-15 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 15 Apr 2012 10:12:23 +0300 > On Thu, Apr 12, 2012 at 02:43:52PM +0800, Jason Wang wrote: >> As hypervior does not have the knowledge of guest network configuration, it's >> better to ask guest to send gratuitous packets when needed. >> >> This patch implemen

Re: [net-next V7 PATCH] virtio-net: send gratuitous packets when needed

2012-04-13 Thread David Miller
From: Jason Wang Date: Thu, 12 Apr 2012 14:43:52 +0800 > As hypervior does not have the knowledge of guest network configuration, it's > better to ask guest to send gratuitous packets when needed. > > This patch implements VIRTIO_NET_F_GUEST_ANNOUNCE feature: hypervisor would > notice the guest

Re: [PATCH] skbuff: struct ubuf_info callback type safety

2012-04-13 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 9 Apr 2012 13:24:02 +0300 > The skb struct ubuf_info callback gets passed struct ubuf_info > itself, not the arg value as the field name and the function signature > seem to imply. Rename the arg field to ctx to match usage, > add documentation and change the

Re: [V6 PATCH] virtio-net: send gratuitous packets when needed

2012-04-03 Thread David Miller
From: Jason Wang Date: Wed, 28 Mar 2012 13:44:28 +0800 > As hypervior does not have the knowledge of guest network configuration, it's > better to ask guest to send gratuitous packets when needed. > > Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when > it > is set, a

Re: [PATCH net-next] virtio_net: do not rate limit counter increments

2012-03-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 28 Mar 2012 10:30:46 +0200 > On Tue, Mar 27, 2012 at 10:28:09AM -0700, Rick Jones wrote: >> From: Rick Jones >> >> While it is desirable to rate limit certain messages, it is not >> desirable to rate limit the incrementing of counters associated >> with tho

Re: [V5 PATCH] virtio-net: send gratuitous packets when needed

2012-03-27 Thread David Miller
From: Jason Wang Date: Fri, 16 Mar 2012 17:01:01 +0800 > As hypervior does not have the knowledge of guest network configuration, it's > better to ask guest to send gratuitous packets when needed. > > Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when > it > is set, a

Re: [PATCH v2 1/2] net: replace random_ether_addr() with eth_hw_addr_random()

2012-02-15 Thread David Miller
From: Danny Kukawka Date: Wed, 15 Feb 2012 17:45:39 +0100 > Replace usage of random_ether_addr() with eth_hw_addr_random() > to set addr_assign_type correctly to NET_ADDR_RANDOM. > > Change the trivial cases. > > v2: adapt to renamed eth_hw_addr_random() > > Signed-off-by: Danny Kukawka Appl

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-16 Thread David Miller
From: Stephen Hemminger Date: Mon, 16 Jan 2012 07:52:36 -0800 > On Mon, 16 Jan 2012 12:26:45 + > Alan Cox wrote: > >> > > ACKs, NACKs? What is happening here? >> > >> > I would like an Ack from Alan Cox who switched vhost-net >> > to a dynamic minor in the first place, in commit >> > 7990

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-13 Thread David Miller
From: Kay Sievers Date: Fri, 13 Jan 2012 05:19:05 +0100 > On Fri, Jan 13, 2012 at 05:07, David Miller wrote: >> From: Stephen Hemminger >> Date: Wed, 11 Jan 2012 21:30:38 -0800 >> >>> Subject: vhost-net: add module alias (v2.1) >>> >>> By addin

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-12 Thread David Miller
From: Stephen Hemminger Date: Wed, 11 Jan 2012 21:30:38 -0800 > Subject: vhost-net: add module alias (v2.1) > > By adding some module aliases, programs (or users) won't have to explicitly > call modprobe. Vhost-net will always be available if built into the kernel. > It does require assigning a

Re: [RFC PATCH v1 1/2] virtio_net: Pass gfp flags when allocating rx buffers.

2012-01-05 Thread David Miller
From: Rusty Russell Date: Thu, 05 Jan 2012 10:40:02 +1030 > On Wed, 04 Jan 2012 14:52:32 -0800, Mike Waychison wrote: >> Currently, the refill path for RX buffers will always allocate the >> buffers as GFP_ATOMIC, even if we are in process context. This will >> fail to apply memory pressure as

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 20 Dec 2011 13:15:12 +0200 > On Wed, Dec 07, 2011 at 01:52:35PM -0500, David Miller wrote: >> Once you sort this out, reply with an Acked-by: for me, thanks. > > Acked-by: Mic

Re: [PATCH v3 REPOST] xen-netfront: delay gARP until backend switches to Connected

2011-12-09 Thread David Miller
From: Ian Campbell Date: Fri, 9 Dec 2011 21:23:00 + > On Fri, 2011-12-09 at 18:45 +0000, David Miller wrote: >> From: Laszlo Ersek >> Date: Fri, 9 Dec 2011 12:38:58 +0100 >> >> > These two together provide complete ordering. Sub-condition (1) is >> >

Re: [PATCH v3 REPOST] xen-netfront: delay gARP until backend switches to Connected

2011-12-09 Thread David Miller
From: Laszlo Ersek Date: Fri, 9 Dec 2011 12:38:58 +0100 > These two together provide complete ordering. Sub-condition (1) is > satisfied by pvops commit 43223efd9bfd. I don't see this commit in Linus's tree, so I doubt it's valid for me to apply this as a bug fix to my 'net' tree since the prec

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 7 Dec 2011 18:10:02 +0200 > On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: >> From: Krishna Kumar2 >> Date: Fri, 25 Nov 2011 09:39:11 +0530 >> >> > Jason Wang wrote on 11/25/2011 08:51:57 AM: >&

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2011-11-26 Thread David Miller
From: Sasha Levin Date: Fri, 18 Nov 2011 11:19:42 +0200 > Device lock should be held when releasing a device, and specifically > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: ... > Cc: "Michael S. Tsirkin" > Cc: k...@vger.kernel.org > Cc: virtualization@lists.linux-founda

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread David Miller
From: Krishna Kumar2 Date: Fri, 25 Nov 2011 09:39:11 +0530 > Jason Wang wrote on 11/25/2011 08:51:57 AM: >> >> My description is not clear again :( >> I mean the same vhost thead: >> >> vhost thread #0 transmits packets of flow A on processor M >> ... >> vhost thread #0 move to another process N

Re: [RFC PATCH net-next v2] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs

2011-11-16 Thread David Miller
From: r...@tardy.cup.hp.com (Rick Jones) Date: Mon, 14 Nov 2011 16:17:08 -0800 (PST) > From: Rick Jones > > Add a new .bus_name to virtio_config_ops then modify virtio_net to > call through to it in an ethtool .get_drvinfo routine to report > bus_info in ethtool -i output which is consistent wi

Re: [RFC 0/0] Introducing a generic socket offload framework

2011-08-18 Thread David Miller
I'm not reading any RFC without any example code, sorry. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PULL net (try 2)] vhost-net: zercopy mode fixes

2011-07-21 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 22 Jul 2011 09:32:38 +0300 > Fixing a corrupted pull request sent earlier. > Sorry about the noise! > > The following includes vhost-net fixes - both in the > experimental zero copy mode. > Please pull for 3.1. Pulled, thanks! __

Re: [PULL net] vhost-net: zercopy mode fixes

2011-07-21 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 22 Jul 2011 09:00:46 +0300 > The following includes vhost-net fixes - both in the > experimental zero copy mode. > Please pull for 3.1. > Thanks! > Where is this "the following"? I don't see any GIT url to pull from or anything :-)

Re: [PATCH repost] Fix panic in virtnet_remove

2011-07-21 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 20 Jul 2011 17:31:15 +0300 > On Wed, Jul 20, 2011 at 07:26:02PM +0530, Krishna Kumar wrote: >> Fix a panic in virtnet_remove. unregister_netdev has already >> freed up the netdev (and virtnet_info) due to dev->destructor >> being set, while virtnet_info is st

Re: [PATCHv11] vhost: vhost TX zero-copy support

2011-07-18 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 18 Jul 2011 16:48:46 +0300 >>From: Shirley Ma > > This adds experimental zero copy support in vhost-net, > disabled by default. To enable, set > experimental_zcopytx module option to 1. > > This patch maintains the outstanding userspace buffers in the > se

Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 17 Jul 2011 22:36:14 +0300 > The below is what I came up with. We add the feature enabled > by default ... s/enabled/disabled/ Well, at least you got it right in the commit message where it counts :-) ___ Virtuali

Re: Large Patch Series in Email

2011-07-15 Thread David Miller
From: Michael Witten Date: Fri, 15 Jul 2011 22:55:29 - > On Sat, 16 Jul 2011 00:09:03 +0300, Dan Carpenter wrote: > >> On Fri, Jul 15, 2011 at 06:25:55PM -, Michael Witten wrote: >>> Do not send more than 15 patches at once to the vger >>> mailing lists!!! >> >> ... Don't be a whinge

Re: [PATCH 4/4] xen/netback: Add module alias for autoloading

2011-06-30 Thread David Miller
From: Konrad Rzeszutek Wilk Date: Thu, 30 Jun 2011 12:39:54 -0400 > On Wed, Jun 29, 2011 at 02:41:32PM +0200, Bastian Blank wrote: >> Add xen-backend:vif module alias to the xen-netback module. This allows >> automatic loading of the module. > > Dave, > > Could you queue this up for 3.1 please?

Re: [PATCH] virtio-net: per cpu 64 bit stats (v2)

2011-06-17 Thread David Miller
From: Stephen Hemminger Date: Wed, 15 Jun 2011 12:36:29 -0400 > Use per-cpu variables to maintain 64 bit statistics. > > Signed-off-by: Stephen Hemminger I'll apply this, thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.o

Re: [PATCH] virtio_net: introduce VIRTIO_NET_HDR_F_DATA_VALID

2011-06-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 10 Jun 2011 14:28:28 +0300 > On Fri, Jun 10, 2011 at 06:56:17PM +0800, Jason Wang wrote: >> There's no need for the guest to validate the checksum if it have been >> validated by host nics. So this patch introduces a new flag - >> VIRTIO_NET_HDR_F_DATA_VALID

Re: [PATCHv2 00/14] virtio and vhost-net performance enhancements

2011-05-19 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 20 May 2011 02:10:07 +0300 > Rusty, I think it will be easier to merge vhost and virtio bits in one > go. Can it all go in through your tree (Dave in the past acked > sending a very similar patch through you so should not be a problem)? And in case you want

Re: [PATCH] xen: drop anti-dependency on X86_VISWS

2011-04-06 Thread David Miller
From: Ian Campbell Date: Mon, 4 Apr 2011 10:55:55 +0100 > You mean the "!X86_VISWS" I presume? It doesn't make sense to me either. No, I think 32-bit x86 allmodconfig elides XEN because of it's X86_TSC dependency. And, well, you could type "make allmodconfig" on your tree and see for yourself

Re: Signed bit field; int have_hotplug_status_watch:1

2011-04-06 Thread David Miller
From: Ian Campbell Date: Mon, 4 Apr 2011 09:26:24 +0100 > Subject: [PATCH] xen: netback: use unsigned type for one-bit bitfield. > > Fixes error from sparse: > CHECK drivers/net/xen-netback/xenbus.c > drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield > >

Re: [PATCH RESEND] net: convert xen-netfront to hw_features

2011-04-04 Thread David Miller
From: Ian Campbell Date: Mon, 4 Apr 2011 13:29:19 +0100 >>From 0b56469abe56efae415b4603ef508ce9aec0e4c1 Mon Sep 17 00:00:00 2001 > From: Ian Campbell > Date: Mon, 4 Apr 2011 10:58:50 +0100 > Subject: [PATCH] xen: netfront: assume all hw features are available until > backend connection setup >

Re: [PATCH] xen: netfront: fix declaration order

2011-04-03 Thread David Miller
From: Eric Dumazet Date: Sun, 03 Apr 2011 13:07:19 +0200 > [PATCH] xen: netfront: fix declaration order > > Must declare xennet_fix_features() and xennet_set_features() before > using them. > > Signed-off-by: Eric Dumazet > Cc: Michał Mirosław Ugh, it makes no sense that XEN won't make it in

Re: [PATCH] virtio_net: convert to hw_features

2011-04-01 Thread David Miller
From: Michał Mirosław Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST) > Signed-off-by: Michał Mirosław Applied. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH RESEND] net: convert xen-netfront to hw_features

2011-04-01 Thread David Miller
From: Michał Mirosław Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST) > Not tested in any way. The original code for offload setting seems broken > as it resets the features on every netback reconnect. > > This will set GSO_ROBUST at device creation time (earlier than connect time). > > RX checksu

Re: [PULL net-2.6] vhost: cleanups and fixes

2011-03-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 17 Mar 2011 16:04:04 +0200 > The following changes since commit 1fc050a13473348f5c439de2bb41c8e92dba5588: > > ipv4: Cache source address in nexthop entries. (2011-03-07 20:54:48 -0800) > > are available in the git repository at: > git://git.kernel.org/p

Re: [PATCH] vhost: copy_from_user -> __copy_from_user

2011-03-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 6 Mar 2011 13:33:49 +0200 > copy_from_user is pretty high on perf top profile, > replacing it with __copy_from_user helps. > It's also safe because we do access_ok checks during setup. > > Signed-off-by: Michael S. Tsirkin Is Rusty going to take this or sh

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: Rusty Russell Date: Thu, 10 Feb 2011 12:32:50 +1030 > From: "Bruce Rogers" > > Under harsh testing conditions, including low memory, the guest would > stop receiving packets. With this patch applied we no longer see any > problems in the driver while performing these tests for extended pe

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 10 Feb 2011 19:57:26 +0200 > On Thu, Feb 10, 2011 at 12:32:50PM +1030, Rusty Russell wrote: >> From: "Bruce Rogers" >> >> Under harsh testing conditions, including low memory, the guest would >> stop receiving packets. With this patch applied we no longer s

Re: [PULL] vhost-net: 2.6.38 - warning fix

2011-02-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 1 Feb 2011 17:44:40 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks Michael. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linu

Re: [PULL] vhost-net: 2.6.38 fix

2011-01-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 14 Jan 2011 11:33:02 +0200 > Please pull the following for 2.6.38. > Thanks! > > The following changes since commit 0c21e3aaf6ae85bee804a325aa29c325209180fd: > > Merge branch 'for-next' of > git://git.kernel.org/pub/scm/linux/kernel/git/hch/hfsplus (2011

Re: [GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 14 Dec 2010 14:23:26 +0200 > On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: >> Please merge the following tree for 2.6.38. >> Thanks! > > Rusty Acked it as is, so please pull the below. > Thanks very much! > >> The following changes sin

Re: [GIT PULL net-2.6] vhost-net: logging fixup

2010-12-12 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 12 Dec 2010 12:09:43 +0200 > Please merge the following fix for 2.6.37. > It is also applicable to -stable. > Thanks! > > The following changes since commit a19faf0250e09b16cac169354126404bc8aa342b: > > net: fix skb_defer_rx_timestamp() (2010-12-10 16:20:

Re: [GIT PULL net-2.6] vhost-net: rcu fixup

2010-11-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 25 Nov 2010 14:23:01 +0200 > Please merge the following fix for 2.6.36. > Thanks! > > The following changes since commit a27e13d370415add3487949c60810e36069a23a6: > > econet: fix CVE-2010-3848 (2010-11-24 11:51:47 -0800) > > are available in the git repo

Re: [GIT PULL net-2.6] vhost-net: access_ok fix

2010-10-21 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 19 Oct 2010 16:59:01 +0200 > David, > Not sure if it's too late for 2.6.36 - in case it's not, the following tree > includes a last minute bugfix for vhost-net, found by code inspection. > It is on top of net-2.6. > Thanks! > > The following changes since co

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.37

2010-10-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 5 Oct 2010 20:27:32 +0200 > It looks like it was a quiet cycle for vhost-net: > probably because most of energy was spent on bugfixes > that went in for 2.6.36. > People are working on multiqueue, tracing but I'm not > sure it'll get done in time for 2.6.37 -

Re: [GIT PULL net-2.6] vhost-net: last minute fix

2010-09-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 27 Sep 2010 15:34:13 +0200 > The following tree includes a last minute bugfix for vhost-net. > It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization mailing list Virtualiz

Re: [GIT PULL net-2.6] vhost-net: fix range checking

2010-09-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 20 Sep 2010 19:42:22 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks! ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-fou

Re: [GIT PULL net-2.6] vhost-net: 2.6.36 regression fixes

2010-09-09 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 6 Sep 2010 14:36:06 +0300 > The following tree includes more regression fixes for vhost-net > in 2.6.36. It is on top of net-2.6. > Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization mailing li

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.36

2010-08-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 28 Jul 2010 16:32:31 +0300 > The following changes since commit 4cfa580e7eebb8694b875d2caff3b989ada2efac: > > r6040: Fix args to phy_mii_ioctl(). (2010-07-21 21:10:49 -0700) > > are available in the git repository at: > git://git.kernel.org/pub/scm/linu

Re: [GIT PULL] vhost-net fixes

2010-07-16 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 16 Jul 2010 15:25:30 +0300 > David, please pull the following fixes for 2.6.35. > Thanks! > > The following changes since commit 91a72a70594e5212c97705ca6a694bd307f7a26b: > > net/core: neighbour update Oops (2010-07-14 18:02:16 -0700) > > are available i

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-07-14 Thread David Miller
From: Pankaj Thakkar Date: Wed, 14 Jul 2010 10:18:22 -0700 > The plugin is guest agnostic and hence we did not want to rely on > any kernel provided functions. While I disagree entirely with this kind of approach, even that doesn't justify what you're doing here. memcpy() and memset() are on a

Re: [GIT PULL net-2.6] vhost-net: more error handling fixes

2010-07-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 1 Jul 2010 19:41:27 +0300 > David, > The following tree includes more fixes dealing with > error handling in vhost-net. It is on top of net-2.6. > Please merge it for 2.6.35. > Thanks! > > The following changes since commit 38000a94a902e94ca8b5498f7871c6316d

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 29 Jun 2010 16:04:39 +0300 > Since using the module involves updating the management tools > as well, if we go down this route it will be much less painful > for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if he'll merg

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 28 Jun 2010 13:08:07 +0300 > Userspace virtio server has the following hack > so guests rely on it, and we have to replicate it, too: > > Use port number to detect incoming IPv4 DHCP response packets, > and fill in the checksum for these. > > The issue we a

Re: [GIT PULL net-2.6] vhost-net: error handling fixes

2010-05-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 27 May 2010 14:57:14 +0300 > David, > The following tree includes fixes dealing with error handling > in vhost-net. It is on top of net-2.6. > Please merge it for 2.6.35. > Thanks! > > The following changes since commit 8a74ad60a546b13bd1096b2a61a7a5c6fd9ae1

Re: [PATCH] [resend] fix non-mergeable buffers packet too large error handling

2010-05-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 18 May 2010 06:12:52 +0300 > DaveM, just to clarify, this patch is on top of the series > we are working on with David L Stevens. It's not for your net tree. Understood. ___ Virtualization mailing list Virtualizati

Re: [PATCH] vhost-net: utilize PUBLISH_USED_IDX feature

2010-05-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 18 May 2010 04:19:31 +0300 > With PUBLISH_USED_IDX, guest tells us which used entries > it has consumed. This can be used to reduce the number > of interrupts: after we write a used entry, if the guest has not yet > consumed the previous entry, or if the gues

Re: [GIT PULL] last minute vhost-net fix

2010-05-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 13 May 2010 11:44:34 +0300 > David, if it's not too late, please pull the following > last minute fix into 2.6.34. Pulled, thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://l

Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next

2010-05-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 4 May 2010 14:21:01 +0300 > This is an amended pull request: I have rebased the tree to the > correct patches. This has been through basic tests and seems > to work fine here. > > The following tree includes a couple of enhancements that help vhost-net. > Pl

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-04 Thread David Miller
From: Pankaj Thakkar Date: Tue, 4 May 2010 17:18:57 -0700 > The purpose of this email is to introduce the architecture and the > design principles. The overall project involves more than just > changes to vmxnet3 driver and hence we though an overview email > would be better. Once people agree to

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 4 May 2010 00:32:45 +0300 > The following tree includes a couple of enhancements that help vhost-net. > Please pull them for net-next. Another set of patches is under > debugging/testing and I hope to get them ready in time for 2.6.35, > so there may be anoth

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: David Miller Date: Mon, 03 May 2010 15:07:29 -0700 (PDT) > From: "Michael S. Tsirkin" > Date: Tue, 4 May 2010 00:32:45 +0300 > >> The following tree includes a couple of enhancements that help vhost-net. >> Please pull them for net-next. Another set o

Re: [GIT PULL] vhost-net fix for 2.6.34-rc3

2010-04-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 7 Apr 2010 20:35:02 +0300 > David, > The following tree includes a patch fixing an issue with vhost-net in > 2.6.34-rc3. Please pull for 2.6.34. Pulled, thanks Michael. ___ Virtualization mailing list Virtualizati

Re: [GIT PULL] vhost-net fixes for issues in 2.6.34-rc1

2010-03-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 18 Mar 2010 11:53:55 +0200 > The following tree includes patches fixing issues with vhost-net in > 2.6.34-rc1. Please pull them for 2.6.34. Pulled, thanks a lot. ___ Virtualization mailing list Virtualization@list

Re: [GIT PULL] vhost-net fixes for 2.6.34

2010-02-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 28 Feb 2010 20:44:40 +0200 > The following changes since commit 655ffee284dfcf9a24ac0343f3e5ee6db85b85c5: > Jiri Pirko (1): > wireless: convert to use netdev_for_each_mc_addr > > are available in the git repository at: > > git://git.kernel.org/p

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 09:34:25 +0200 > Implicitly, I guess. He said "if there's an issue Michael Tsirkin is the > best person to resolve it", this was wrt merging his virtio&lguest tree. > He didn't mention vhost, I wrote all of vhost though, there shouldn't be > an is

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 07:37:37 +0200 > Dave, so while Rusty's on vacation, what's the best way to get vhost > infrastructure fixes in? Are you ok with getting pull requests and > merging them into net-next? That should keep the clutter in your inbox > to the minimum.

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
Just for the record I'm generally not interested in vhost patches. If it's a specific network one that will be merged via the networking tree, yes please CC: me. But if it's a bunch of changes to vhost.c and other pieces of infrastructure, feel free to leave me out of it. It just clutters my al

Re: [PATCH] vhost-net: switch to smp barriers

2010-02-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Sat, 13 Feb 2010 19:39:11 +0200 > Dave, I see it's marked "not applicable": > http://patchwork.ozlabs.org/patch/44207/ > the patch applies to net-next as of > b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73. > Can this be queued up please? > Should I resubmit with Rusty'

Re: [PATCH 0/3 v4] macvtap driver

2010-02-03 Thread David Miller
From: Arnd Bergmann Date: Sat, 30 Jan 2010 23:22:15 +0100 > This is the fourth version of the macvtap driver, > based on the comments I got for the last version > I got a few days ago. Very few changes: > > * release netdev in chardev open function so > we can destroy it properly. > * Implemen

Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path Date: Wed, 13 Jan 2010 12:53:38 -0800

2010-02-02 Thread David Miller
From: Rusty Russell Date: Fri, 29 Jan 2010 23:50:04 +1030 > From: Shirley Ma > > virtio_net receives packets from its pre-allocated vring buffers, then it > delivers these packets to upper layer protocols as skb buffs. So it's not > necessary to pre-allocate skb for each mergable buffer, then

Re: [PATCH 1/2] virtio: Add ability to detach unused buffers from vrings

2010-02-02 Thread David Miller
From: Rusty Russell Date: Fri, 29 Jan 2010 23:49:05 +1030 > From: Shirley Ma > > There's currently no way for a virtio driver to ask for unused > buffers, so it has to keep a list itself to reclaim them at shutdown. > This is redundant, since virtio_ring stores that information. So > add a new

Re: [PATCH 0/2] virtio net improvements

2010-02-02 Thread David Miller
From: Rusty Russell Date: Wed, 3 Feb 2010 09:57:06 +1030 > On Fri, 29 Jan 2010 11:46:43 pm Rusty Russell wrote: >> Hi Dave, >> >>Nice driver optimization from Shirley, but requires a new virtio hook. >> Do you want to take both? I have nothing else overlapping it. > > Dave, any news on thi

Re: [RFC] macvlan: add tap device backend

2009-12-14 Thread David Miller
From: Arnd Bergmann Date: Mon, 14 Dec 2009 13:00:36 +0100 > c) prepare a combined patch for net-next.git, or This is probably fine. I'll be taking patches into net-next-2.6 right after Linus releases 2.6.33-rc1. ___ Virtualization mailing list Virtual

Re: [PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread David Miller
From: Patrick McHardy Date: Thu, 26 Nov 2009 17:26:17 +0100 > Arnd Bergmann wrote: >> Version 2 description: >> The patch to iproute2 has not changed, so I'm not including >> it this time. Patch 4/4 (the netlink interface) is basically >> unchanged as well but included for completeness. >> >> Th

Re: [PATCHv7 1/3] tun: export underlying socket

2009-11-04 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 3 Nov 2009 19:24:00 +0200 > Assuming it's okay with davem, I think it makes sense to merge this > patch through Rusty's tree because vhost is the first user of the new > interface. Posted here for completeness. I'm fine with that, please add my: Acked-by:

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 26 Oct 2009 11:07:13 +0200 > Another, and hopefully the last, note, is that > git-am can only handle Subject/From lines > at the beginning of the message. > So git style of the mail would be ... > I think it's weird. We could invent some kind of separator >

Re: [PATCH 2.6.32-rc4] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-13 Thread David Miller
From: Shreyas Bhatewara Date: Mon, 12 Oct 2009 15:18:42 -0700 (PDT) > > Ethernet NIC driver for VMware's vmxnet3 > > From: Shreyas Bhatewara > > This patch adds driver support for VMware's virtual Ethernet NIC: vmxnet3 > Guests running on VMware hypervisors supporting vmxnet3 device will thus

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-01 Thread David Miller
From: Shreyas Bhatewara Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > +{ > + struct vmxnet3_adapter *adapter = netdev_priv(netdev); > + u8 *base; > + int i; > + > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, > VMXNET3_CMD_GET_STATS); > + > + /* this does assume each counter

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread David Miller
From: Stephen Hemminger Date: Wed, 30 Sep 2009 17:39:23 -0700 > Why not use NETIF_F_LRO and ethtool to control LRO support? In fact, you must, in order to handle bridging and routing correctly. Bridging and routing is illegal with LRO enabled, so the kernel automatically issues the necessary et

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-29 Thread David Miller
From: Bhavesh Davda Date: Tue, 29 Sep 2009 12:52:05 -0700 >> One thing that should possibly be fixed is the naming of identifiers, >> e.g. >> 's/Vmxnet3_MiscConf/vmxnet3_misc_conf/g', unless these header files are >> shared with the host implementation. > > These header files are indeed shared w

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-28 Thread David Miller
From: Alok Kataria Date: Mon, 28 Sep 2009 17:51:39 -0700 > As a side note, were there any changes in the networking API's, that we > should look out for in the merge cycle ? > If not I think the rebase should be pretty trivial. Just off the top of my head, the return type of the driver transmit

Re: [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-28 Thread David Miller
From: Shreyas Bhatewara Date: Mon, 28 Sep 2009 16:56:45 -0700 > + uint32_t rxdIdx:12;/* Index of the RxDesc */ Don't use uint32_t et al. sized types, use "u32" and friends throughout. ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-08-18 Thread David Miller
From: Herbert Xu Date: Wed, 19 Aug 2009 13:19:26 +1000 > I'm in the process of repeating the same experiment with cxgb3 > which hopefully should let me turn interrupts off on descriptors > while still reporting completion status. Ok, I look forward to seeing your work however it turns out. Once

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-08-17 Thread David Miller
From: Herbert Xu Date: Sun, 5 Jul 2009 11:34:08 +0800 > Here's an even crazier idea that doesn't use dummy descriptors. > > xmit(skb) > > if (TX queue contains no interrupting descriptor && > qdisc is empty) > mark TX descriptor as interrupting > > if (TX qu

Re: [PATCH] net/bridge: Add 'hairpin' port forwarding mode

2009-08-13 Thread David Miller
From: "Fischer, Anna" Date: Thu, 13 Aug 2009 16:55:16 + > This patch adds a 'hairpin' (also called 'reflective relay') mode > port configuration to the Linux Ethernet bridge kernel module. > A bridge supporting hairpin forwarding mode can send frames back > out through the port the frame was

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu Date: Sat, 4 Jul 2009 11:08:30 +0800 > On Fri, Jul 03, 2009 at 08:02:54PM -0700, David Miller wrote: >> >> In particular the case of handling a device without usable TX >> completion event indications is still quite troublesome. > e > Which particular

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu Date: Fri, 3 Jul 2009 15:55:30 +0800 > Calling skb_orphan like this should be forbidden. Apart from the > problems already raised, it is a sign that the driver is trying to > paper over a more serious issue of not cleaning up skb's timely. > > Yes skb_orphan will work for the c

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-03 Thread David Miller
From: Eric Dumazet Date: Thu, 04 Jun 2009 06:54:24 +0200 > We also can avoid the sock_put()/sock_hold() pair for each tx packet, > to only touch sk_wmem_alloc (with appropriate atomic_sub_return() in > sock_wfree() > and atomic_dec_test in sk_free > > We could initialize sk->sk_wmem_alloc to on

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-03 Thread David Miller
From: Rusty Russell Date: Thu, 4 Jun 2009 13:24:57 +0930 > On Thu, 4 Jun 2009 06:32:53 am Eric Dumazet wrote: >> Also, taking a reference on socket for each xmit packet in flight is very >> expensive, since it slows down receiver in __udp4_lib_lookup(). Several >> cpus are fighting for sk->refcnt

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-02 Thread David Miller
From: Rusty Russell Date: Tue, 2 Jun 2009 23:38:29 +0930 > On Tue, 2 Jun 2009 04:55:53 pm David Miller wrote: >> From: Patrick Ohly >> Date: Mon, 01 Jun 2009 21:47:22 +0200 >> >> > On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote: >> >>

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-02 Thread David Miller
From: Patrick Ohly Date: Mon, 01 Jun 2009 21:47:22 +0200 > On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote: >> This patch adds skb_orphan to the start of dev_hard_start_xmit(): it >> can be premature in the NETDEV_TX_BUSY case, but that's uncommon. > > Would it be possible to make the new

Re: [RFC] virtio: orphan skbs if we're relying on timer to free them

2009-05-21 Thread David Miller
From: Rusty Russell Date: Thu, 21 May 2009 16:27:05 +0930 > On Tue, 19 May 2009 12:10:13 pm David Miller wrote: >> What you're doing by orphan'ing is creating a situation where a single >> UDP socket can loop doing sends and monopolize the TX queue of a >> device.

<    1   2   3   4   5   6   >