Make rx buf len configurable via sysfs
Signed-off-by: Jiang Wang
---
net/vmw_vsock/virtio_transport.c | 46 ++--
1 file changed, 44 insertions(+), 2 deletions(-)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 8d5bfcd79555
Added test cases for vsock dgram types.
Signed-off-by: Jiang Wang
---
tools/testing/vsock/util.c | 105 +
tools/testing/vsock/util.h | 4 +
tools/testing/vsock/vsock_test.c | 195 +++
3 files changed, 304 insertions(+)
diff --git
This patch supports dgram on vhost side, including
tx and rx. The vhost send packets asynchronously.
Also, ignore vq errors when vq number is larger than 2,
so it will be comptaible with old versions.
Signed-off-by: Jiang Wang
---
drivers/vhost/vsock.c | 217
for it.
Support for the host/device side is in another
patch.
Signed-off-by: Jiang Wang
---
include/net/af_vsock.h| 1 +
.../events/vsock_virtio_transport_common.h| 2 +
include/uapi/linux/virtio_vsock.h | 1 +
net/vmw_vsock/af_vsock.c | 12
When this feature is enabled, allocate 5 queues,
otherwise, allocate 3 queues to be compatible with
old QEMU versions.
Signed-off-by: Jiang Wang
---
drivers/vhost/vsock.c | 3 +-
include/linux/virtio_vsock.h | 9
include/uapi/linux/virtio_vsock.h | 2 +
net/vmw_vsock
ode in virtio-vsock
- use le_to_cpu16 in virtio-vsock
Jiang Wang (5):
virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit
virtio/vsock: add support for virtio datagram
vhost/vsock: add support for vhost dgram.
vsock_test: add tests for vsock dgram
virtio/vsock: add sysfs for rx buf len for dg
On Thu, Sep 2, 2021 at 7:07 AM Stefan Hajnoczi wrote:
>
> On Thu, Jun 10, 2021 at 06:12:03PM +, Jiang Wang wrote:
> > Add supports for datagram type for virtio-vsock. Datagram
> > sockets are connectionless and unreliable. To avoid contention
> > with stream and oth
On Tue, Aug 31, 2021 at 6:13 PM Michael S. Tsirkin wrote:
>
> On Thu, Jun 10, 2021 at 06:12:03PM +, Jiang Wang wrote:
> > Add supports for datagram type for virtio-vsock. Datagram
> > sockets are connectionless and unreliable. To avoid contention
> > with stream an
On Fri, Jun 18, 2021 at 3:14 AM Stefano Garzarella wrote:
>
> We should use le16_to_cpu when accessing pkt->hdr fields.
OK. Will do.
> On Wed, Jun 09, 2021 at 11:24:55PM +, Jiang Wang wrote:
> >This patch supports dgram on vhost side, including
> >tx and rx
On Fri, Jun 18, 2021 at 3:04 AM Stefano Garzarella wrote:
>
> On Wed, Jun 09, 2021 at 11:24:58PM +, Jiang Wang wrote:
> >Make rx buf len configurable via sysfs
> >
> >Signed-off-by: Jiang Wang
> >---
> > net/vmw_vsock/virtio_transport.c | 37
On Fri, Jun 18, 2021 at 2:54 AM Stefano Garzarella wrote:
>
> On Wed, Jun 09, 2021 at 11:24:57PM +, Jiang Wang wrote:
> >Also change number of vqs according to the config
> >
> >Signed-off-by: Jiang Wang
> >---
> > drivers/vhost/Kconfig | 8 +++
On Fri, Jun 18, 2021 at 2:40 AM Stefano Garzarella wrote:
>
> On Wed, Jun 09, 2021 at 11:24:53PM +, Jiang Wang wrote:
> >When this feature is enabled, allocate 5 queues,
> >otherwise, allocate 3 queues to be compatible with
> >old QEMU versions.
> >
On Fri, Jun 18, 2021 at 2:35 AM Stefano Garzarella wrote:
>
> On Wed, Jun 09, 2021 at 11:24:52PM +, Jiang Wang wrote:
> >This patchset implements support of SOCK_DGRAM for virtio
> >transport.
> >
> >Datagram sockets are connectionless and unreliable.
On Thu, Jun 10, 2021 at 11:17 PM Jason Wang wrote:
>
>
> 在 2021/6/11 上午2:39, Jiang Wang 写道:
> > Mergeable rx buffer is already supported by virtio-net, and
> > it can save memory for big packets. It will also be beneficial
> > for the vsock devices, so add
Mergeable rx buffer is already supported by virtio-net, and
it can save memory for big packets. It will also be beneficial
for the vsock devices, so add it to the spec.
---
V0 -> V1: I send similar patch with vsock dgram before and
already got some comments. This version fixed those,such as
use
of datagram, which
does not use the existing credit update mechanism associated with
stream sockets.
Signed-off-by: Jiang Wang
---
V2: addressed the comments for the previous version.
V3: add description for the mergeable receive buffer.
V4: add a feature bit for stream and reserver a bit
On Thu, Jun 10, 2021 at 2:52 AM Stefano Garzarella wrote:
>
> On Thu, Jun 10, 2021 at 03:46:55PM +0800, Jason Wang wrote:
> >
> >在 2021/6/10 下午3:23, Stefano Garzarella 写道:
> >>On Thu, Jun 10, 2021 at 12:02:35PM +0800, Jason Wang wrote:
> >>>
> >>>
On Wed, Jun 9, 2021 at 6:51 PM Jason Wang wrote:
>
>
> 在 2021/6/10 上午7:24, Jiang Wang 写道:
> > This patchset implements support of SOCK_DGRAM for virtio
> > transport.
> >
> > Datagram sockets are connectionless and unreliable. To avoid unfair
> > contention
On Wed, Jun 9, 2021 at 12:17 AM Stefano Garzarella wrote:
>
> On Tue, Jun 08, 2021 at 09:22:26PM -0700, Jiang Wang . wrote:
> >On Tue, Jun 8, 2021 at 6:46 AM Stefano Garzarella
> >wrote:
> >>
> >> On Fri, May 28, 2021 at 04:01:18AM +, Jiang
Make rx buf len configurable via sysfs
Signed-off-by: Jiang Wang
---
net/vmw_vsock/virtio_transport.c | 37 +++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index cf47aadb0c34
Also change number of vqs according to the config
Signed-off-by: Jiang Wang
---
drivers/vhost/Kconfig | 8
drivers/vhost/vsock.c | 11 ---
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
index 587fbae06182
Added test cases for vsock dgram types.
Signed-off-by: Jiang Wang
---
tools/testing/vsock/util.c | 105 +
tools/testing/vsock/util.h | 4 +
tools/testing/vsock/vsock_test.c | 195 +++
3 files changed, 304 insertions(+)
diff
This patch supports dgram on vhost side, including
tx and rx. The vhost send packets asynchronously.
Signed-off-by: Jiang Wang
---
drivers/vhost/vsock.c | 199 +++---
1 file changed, 173 insertions(+), 26 deletions(-)
diff --git a/drivers/vhost
for it.
Support for the host/device side is in another
patch.
Signed-off-by: Jiang Wang
---
include/net/af_vsock.h | 1 +
.../trace/events/vsock_virtio_transport_common.h | 5 +-
include/uapi/linux/virtio_vsock.h | 1 +
net/vmw_vsock/af_vsock.c
When this feature is enabled, allocate 5 queues,
otherwise, allocate 3 queues to be compatible with
old QEMU versions.
Signed-off-by: Jiang Wang
---
drivers/vhost/vsock.c | 3 +-
include/linux/virtio_vsock.h | 9 +
include/uapi/linux/virtio_vsock.h | 3 ++
net/vmw_vsock
/vsock-dgram-v1
To do:
1. use skb when receiving packets
2. support multiple transport
3. support mergeable rx buffer
Jiang Wang (6):
virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit
virtio/vsock: add support for virtio datagram
vhost/vsock: add support for vhost dgram.
vsock_test: add
On Tue, May 18, 2021 at 9:59 PM Jiang Wang . wrote:
>
> On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella
> wrote:
> >
> > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote:
> > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella
> > >wr
On Tue, Jun 8, 2021 at 6:46 AM Stefano Garzarella wrote:
>
> On Fri, May 28, 2021 at 04:01:18AM +, Jiang Wang wrote:
> >From: "jiang.wang"
> >
> >Add supports for datagram type for virtio-vsock. Datagram
> >sockets are connectionless and unreli
Any comments? Thanks.
On Thu, May 27, 2021 at 9:01 PM Jiang Wang wrote:
>
> From: "jiang.wang"
>
> Add supports for datagram type for virtio-vsock. Datagram
> sockets are connectionless and unreliable. To avoid contention
> with stream and other sockets, add two
scriptions for resource management of datagram, which
does not use the existing credit update mechanism associated with
stream sockets.
Signed-off-by: Jiang Wang
---
V2: addressed the comments for the previous version.
V3: add description for the mergeable receive buffer.
V4: add a feature bit
On Thu, May 27, 2021 at 6:21 AM Stefano Garzarella wrote:
>
> Re-send my thoughts on this new series...
>
> On Wed, May 26, 2021 at 05:50:35PM +, Jiang Wang wrote:
> >From: "jiang.wang"
> >
> >Add supports for datagram type for virtio-vsock
scriptions for resource management of datagram, which
does not use the existing credit update mechanism associated with
stream sockets.
Signed-off-by: Jiang Wang
---
V2: addressed the comments for the previous version.
V3: add description for the mergeable receive buffer.
btw: send the same patch again
scriptions for resource management of datagram, which
does not use the existing credit update mechanism associated with
stream sockets.
Signed-off-by: Jiang Wang
---
V2: addressed the comments for the previous version.
V3: add description for the mergeable receive buffer.
virtio-vsock
On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella wrote:
>
> On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote:
> >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella
> >wrote:
> >>
> >> On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote
On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote:
>
> On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote:
> >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella
> >wrote:
> >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote:
>
> [..
On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote:
>
> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote:
> >On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella
> >wrote:
> >> On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote:
>
>
On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella wrote:
>
> On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote:
> >Hi guys,
> >
> >I have one question about adding two new virtqueues for dgram. One new
> >thought is that we don't add two new virt
? I remember Stefano mentioned that we should add
two new virtqueues for dgram. Stefano, do you have some specific reasons
for that? Could we just keep using existing virtqueues? Thanks.
Regards,
Jiang
On Wed, May 5, 2021 at 9:58 AM Jiang Wang . wrote:
>
> On Wed, May 5, 2021 at 3:49 AM S
On Wed, May 5, 2021 at 3:49 AM Stefano Garzarella wrote:
>
> On Tue, May 04, 2021 at 10:06:02AM -0700, Jiang Wang . wrote:
> >On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella
> >wrote:
> >>
> >> Hi Jiang,
> >>
> >> On Mon, May 03, 2021 at
On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella wrote:
>
> Hi Jiang,
>
> On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote:
> >Hi Stefano,
> >
> >I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock
> >dgram can use that feature too
> > > > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote:
> >> > > > > > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella
> >> > > > > > wrote:
> >> > > > > > &
:
>
> On Tue, Apr 13, 2021 at 12:12:50PM +, Jorgen Hansen wrote:
> >
> >
> >On 12 Apr 2021, at 20:53, Jiang Wang .
> >mailto:jiang.w...@bytedance.com>> wrote:
> >
> >On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella
> >mailto:sgarz...
On Tue, Apr 13, 2021 at 2:02 AM Jorgen Hansen wrote:
>
>
>
> > On 7 Apr 2021, at 20:25, Jiang Wang . wrote:
> >
> > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote:
> >>
> >>
> >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote:
> &g
:
> > > > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote:
> > > > > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote:
> > > > > > On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote:
> > > >
gram, which
> >> does not use the existing credit update mechanism associated with
> >> stream sockets.
> >>
> >> Signed-off-by: Jiang Wang
> >> ---
> >> V2 addressed the comments for the previous version.
> >>
> >> virtio-vsock.tex
er sockets, add two more virtqueues and
> > a new feature bit to identify if those two new queues exist or not.
> >
> > Also add descriptions for resource management of datagram, which
> > does not use the existing credit update mechanism associated with
> > stream sock
On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella wrote:
>
> Hi Jiang,
> thanks for re-starting the multi-transport support for dgram!
No problem.
> On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote:
> >On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote:
> &g
On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote:
>
>
> > On 6 Apr 2021, at 20:31, Jiang Wang wrote:
> >
> > From: "jiang.wang"
> >
> > Currently, only VMCI supports dgram sockets. To supported
> > nested VM use case, this patc
s.
Signed-off-by: Jiang Wang
---
This patch is not tested. I don't have a VMWare testing
environment. Could someone help me to test it?
include/net/af_vsock.h | 2 --
net/vmw_vsock/af_vsock.c | 63 +-
net/vmw_vsock/vmci_transp
vsock.
Also, I don't think we need to put anything related to this multiple-
transport support in the spec. Let me know if otherwise.
Regards,
Jiang
On Tue, Mar 30, 2021 at 11:34 AM Jiang Wang . wrote:
>
> On Tue, Mar 30, 2021 at 8:32 AM Stefano Garzarella
> wrote:
> &g
On Tue, Mar 30, 2021 at 8:32 AM Stefano Garzarella wrote:
>
> Hi Jiang,
>
> On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote:
> >Hi Michael and Stefan,
> >
> >I thought about this and discussed it with my colleague Cong Wang.
> >One idea is to mak
On Tue, Mar 30, 2021 at 3:42 AM Stefan Hajnoczi wrote:
>
> On Mon, Mar 29, 2021 at 04:22:28PM -0700, Jiang Wang . wrote:
> > On Mon, Mar 29, 2021 at 2:26 AM Stefan Hajnoczi wrote:
> > >
> > > On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote:
> > &g
On Mon, Mar 29, 2021 at 2:26 AM Stefan Hajnoczi wrote:
>
> On Fri, Mar 26, 2021 at 04:40:09PM -0700, Jiang Wang . wrote:
> > I thought about this and discussed it with my colleague Cong Wang.
> > One idea is to make current asynchronous send_pkt flow to be synchronous,
> &g
at 1:53 AM Stefan Hajnoczi wrote:
>
> On Mon, Mar 22, 2021 at 07:23:14PM -0700, Jiang Wang . wrote:
> > Got it. Will do.
>
> You could look at udp_sendmsg() to see how sockets compete when
> transmitting to the same net device.
>
> I'm not very familiar with this but I
Got it. Will do.
On Mon, Mar 22, 2021 at 4:10 PM Michael S. Tsirkin wrote:
>
> On Mon, Mar 22, 2021 at 04:02:14PM -0700, Jiang Wang . wrote:
> > After dropping my additional accounting. I think there is still a question
> > about if we want to protect the shared dgram virtque
On Mon, Mar 22, 2021 at 9:51 AM Stefan Hajnoczi wrote:
>
> On Thu, Mar 18, 2021 at 10:59:20AM -0700, Jiang Wang . wrote:
> > On Wed, Mar 17, 2021 at 8:45 AM Stefan Hajnoczi wrote:
> > >
> > > On Tue, Mar 16, 2021 at 09:56:44PM +, jiang.wang wrote:
> >
er sockets, add two more virtqueues and
> > a new feature bit to identify if those two new queues exist or not.
> >
> > Also add descriptions for resouce management of datagram, which
> > does not use the existing credit update mechanism associated with
>
, 2021 at 1:53 AM Michael S. Tsirkin wrote:
>
> On Thu, Feb 11, 2021 at 10:04:34PM -0800, Jiang Wang . wrote:
> > Hi guys,
> >
> > I am working on supporting DGRAM type for virtio/vhost vsock. I
> > already did some work and a draft code is here (which passed my tests,
&
On Tue, Feb 16, 2021 at 12:50 AM Stefano Garzarella wrote:
>
> On Tue, Feb 16, 2021 at 12:23:19AM -0800, Jiang Wang . wrote:
> >On Tue, Feb 16, 2021 at 12:09 AM Stefano Garzarella
> >wrote:
> >>
> >> On Mon, Feb 15, 2021 at 08:50:36PM -0800, Jiang Wang . wro
On Tue, Feb 16, 2021 at 12:09 AM Stefano Garzarella wrote:
>
> On Mon, Feb 15, 2021 at 08:50:36PM -0800, Jiang Wang . wrote:
> >On Mon, Feb 15, 2021 at 12:31 AM Stefano Garzarella
> >wrote:
> >>
> >> On Sat, Feb 13, 2021 at 03:26:18PM -0800, Jiang Wang . wr
On Mon, Feb 15, 2021 at 12:53 AM Arseny Krasnov
wrote:
>
>
> On 14.02.2021 02:46, Jiang Wang . wrote:
> > On Fri, Feb 12, 2021 at 7:19 AM Arseny Krasnov
> > wrote:
> >>
> >> On 12.02.2021 12:02, Stefano Garzarella wrote:
> >>> Hi Jiang,
> &
On Mon, Feb 15, 2021 at 12:31 AM Stefano Garzarella wrote:
>
> On Sat, Feb 13, 2021 at 03:26:18PM -0800, Jiang Wang . wrote:
> >On Fri, Feb 12, 2021 at 1:02 AM Stefano Garzarella
> >wrote:
> >>
> >> Hi Jiang,
> >>
> >> CCing Arseny who
On Fri, Feb 12, 2021 at 7:19 AM Arseny Krasnov
wrote:
>
>
> On 12.02.2021 12:02, Stefano Garzarella wrote:
> > Hi Jiang,
> >
> > CCing Arseny who is working on SOCK_SEQPACKET support for virtio-vsock
> > [1].
> >
> > On Thu, Feb 11, 2021 at 10:04
On Fri, Feb 12, 2021 at 1:02 AM Stefano Garzarella wrote:
>
> Hi Jiang,
>
> CCing Arseny who is working on SOCK_SEQPACKET support for virtio-vsock
> [1].
>
> On Thu, Feb 11, 2021 at 10:04:34PM -0800, Jiang Wang . wrote:
> >Hi guys,
> >
> >I am working on
Hi guys,
I am working on supporting DGRAM type for virtio/vhost vsock. I
already did some work and a draft code is here (which passed my tests,
but still need some cleanup and only works from host to guest as of
now, will add host to guest soon):
65 matches
Mail list logo
