Re: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-24 Thread Jason Wang
On Sun, May 22, 2022 at 9:07 PM Christophe JAILLET wrote: > > Now that a private buffer is allocated (see commit in the Fixes tag), > it must be released in all error handling paths. > > Add the missing goto to avoid a leak in the error handling path. > > Fixes: 42e6ac99e417 ("virtio-crypto: use

RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-22 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] > Sent: Sunday, May 22, 2022 9:07 PM > To: dan.carpen...@oracle.com; Gonglei (Arei) ; > Michael S. Tsirkin ; Jason Wang ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc:

Re: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-22 Thread zhenwei pi
On 5/22/22 21:07, Christophe JAILLET wrote: Now that a private buffer is allocated (see commit in the Fixes tag), it must be released in all error handling paths. Add the missing goto to avoid a leak in the error handling path. Fixes: 42e6ac99e417 ("virtio-crypto: use private buffer for