Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order

2011-02-23 Thread Greg KH
On Wed, Feb 23, 2011 at 12:19:55PM -0800, Haiyang Zhang wrote: The patch fixed the code depending on the exact order of fields in the struct vmbus_driver_context, so the unused field drv_ctx can be removed, and drv_obj doesn't have to be the second field in this structure. Signed-off-by:

RE: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order

2011-02-23 Thread KY Srinivasan
; virtualizat...@lists.osdl.org Subject: Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order On Wed, Feb 23, 2011 at 12:19:55PM -0800, Haiyang Zhang wrote: The patch fixed the code depending on the exact order of fields in the struct vmbus_driver_context, so

RE: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order

2011-02-23 Thread Haiyang Zhang
From: Greg KH [mailto:g...@kroah.com] Sent: Wednesday, February 23, 2011 4:27 PM struct driver_context { struct hv_guid class_id; - struct device_driver driver; + struct hv_driver *hv_drv; If you have a pointer to hv_driver, why do you need a full 'struct device_driver'

Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order

2011-02-23 Thread Greg KH
...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order On Wed, Feb 23, 2011 at 12:19:55PM -0800, Haiyang Zhang wrote: The patch fixed the code

Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order

2011-02-23 Thread Greg KH
On Wed, Feb 23, 2011 at 10:55:12PM +, Haiyang Zhang wrote: From: Greg KH [mailto:g...@kroah.com] The layering is almost ok, there is still one more layer here than is needed, and it should be removed (I already removed lots of layers that were not needed, just didn't get to this one.)