Re: [PATCH 5/7] vhost_vsock: simplify vhost_vsock_flush()

2021-12-08 Thread Jason Wang
On Thu, Dec 9, 2021 at 1:35 AM wrote: > > On 12/7/21 9:53 PM, Jason Wang wrote: > > On Tue, Dec 7, 2021 at 10:45 AM Mike Christie > > wrote: > >> > >> From: Andrey Ryabinin > >> > >> vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) > >> before vhost_work_dev_flush(>dev).

Re: [PATCH 5/7] vhost_vsock: simplify vhost_vsock_flush()

2021-12-08 Thread michael . christie
On 12/7/21 9:53 PM, Jason Wang wrote: > On Tue, Dec 7, 2021 at 10:45 AM Mike Christie > wrote: >> >> From: Andrey Ryabinin >> >> vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) >> before vhost_work_dev_flush(>dev). This seems pointless >> as vsock->vqs[i].poll.dev is the

Re: [PATCH 5/7] vhost_vsock: simplify vhost_vsock_flush()

2021-12-07 Thread Jason Wang
On Tue, Dec 7, 2021 at 10:45 AM Mike Christie wrote: > > From: Andrey Ryabinin > > vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) > before vhost_work_dev_flush(>dev). This seems pointless > as vsock->vqs[i].poll.dev is the same as >dev and several flushes > in a row