Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Rusty Russell
On Wed, 13 May 2009 01:03:30 am Michael S. Tsirkin wrote: > On Wed, May 13, 2009 at 12:00:02AM +0930, Rusty Russell wrote > > and perhaps consider > > varargs for the callbacks (or would that be too horrible at the > > implementation end?) > > > > Thanks, > > Rusty. > > Ugh ... I think it will be.

Re: [PATCH] msi-x: let drivers retry when not enough vectors

2009-05-12 Thread Michael S. Tsirkin
On Fri, May 08, 2009 at 09:25:00AM +0930, Rusty Russell wrote: > On Thu, 7 May 2009 07:49:53 pm Sheng Yang wrote: > > On Thursday 07 May 2009 17:53:02 Matthew Wilcox wrote: > > > Here's a good example. Let's suppose you have a driver which supports > > > two different models of cards, one has 16 M

[PATCHv4] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Michael S. Tsirkin
This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, and updates all drivers. This is needed for MSI support, because MSI needs to know the total number of vectors upfront. Signed-off-by: Michael S. Tsirkin --- Untested - Rusty could you pls take a look before I go ahead and reb

Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Michael S. Tsirkin
On Wed, May 13, 2009 at 12:00:02AM +0930, Rusty Russell wrote: > On Tue, 12 May 2009 07:49:32 am Michael S. Tsirkin wrote: > > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, > > and updates all drivers. This is needed for MSI support, because MSI > > needs to know the total n

Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Rusty Russell
On Tue, 12 May 2009 07:49:32 am Michael S. Tsirkin wrote: > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, > and updates all drivers. This is needed for MSI support, because MSI > needs to know the total number of vectors upfront. Sorry, is this not on top of my virtio_devic

Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC)

2009-05-12 Thread Rusty Russell
On Tue, 12 May 2009 02:40:38 am Mark McLoughlin wrote: > > Blocked from doing the simpler thing, we've decided to go with a layer > > of indirection. But the patch is simple and clean, so there's nothing > > fundamental to object to. > > Still have one FIXME in the patch worth looking at - at what

Re: [PATCH RFC 0/2] qemu-kvm: MSI-X support

2009-05-12 Thread Michael S. Tsirkin
On Mon, May 11, 2009 at 05:24:25PM -0500, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> Here's a draft MSI-X support patch. Among missing features: >> save/load support, and command-line flag to control the >> feature. This is on top of qemu-kvm: msi-x is disabled >> without kvm interrupt i

Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Rusty Russell
On Sun, 10 May 2009 04:55:38 pm Michael S. Tsirkin wrote: > On Sun, May 10, 2009 at 01:37:06PM +0930, Rusty Russell wrote: > > Yes, and in fact a rough look at your patch reveals that we don't > > actually need del_vq: now we track them, we can just do that as part of > > vdev destruction, right? >

Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-12 Thread Christian Borntraeger
Am Tuesday 12 May 2009 00:19:32 schrieb Michael S. Tsirkin: > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, > and updates all drivers. This is needed for MSI support, because MSI > needs to know the total number of vectors upfront. [...] > diff --git a/drivers/s390/kvm/kvm_v