Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
> For many many years, you shipped closed source Linux kernel drivers > for > your products. Only recently has this changed. and > > all our Linux drivers, even if not all are upstream [yet], are GPL. > > That's nice to hear, although without proof of that, we have to take > your word :) The f

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 02:03:20 PM Greg KH wrote: > On Thu, Oct 25, 2012 at 01:43:50PM -0700, Bhavesh Davda wrote: > > Hi Greg, > > > > > You can't just say "general GPL issues aside". Honestly, given your > > > company's prior actions in regards to Linux kernel drivers and the > > > licen

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 02:04:48 PM Greg KH wrote: > On Thu, Oct 25, 2012 at 01:45:39PM -0700, Dmitry Torokhov wrote: > > On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: > > > On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: > > > > Hi Greg, > > > > > > > > > > +EXPORT_SYM

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Andy King
Hi Greg, > You can't just say "general GPL issues aside". Honestly, given your > company's prior actions in regards to Linux kernel drivers and the > licenses of them, I don't trust them at all. To help gain that trust > back, marking the exports in this manner will be a great improvement. > >

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:45:39PM -0700, Dmitry Torokhov wrote: > On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: > > On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: > > > Hi Greg, > > > > > > > > +EXPORT_SYMBOL(vmci_device_get); > > > > > > > > EXPORT_SYMBOL_GPL() for this,

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:43:50PM -0700, Bhavesh Davda wrote: > Hi Greg, > > > You can't just say "general GPL issues aside". Honestly, given your > > company's prior actions in regards to Linux kernel drivers and the > > licenses of them, I don't trust them at all. To help gain that trust > >

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: > On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: > > Hi Greg, > > > > > > +EXPORT_SYMBOL(vmci_device_get); > > > > > > EXPORT_SYMBOL_GPL() for this, and all other exports? > > > > We'd prefer to leave them as vanilla exports.

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
Hi Greg, > You can't just say "general GPL issues aside". Honestly, given your > company's prior actions in regards to Linux kernel drivers and the > licenses of them, I don't trust them at all. To help gain that trust > back, marking the exports in this manner will be a great improvement. > Yo

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: > Hi Greg, > > > > +EXPORT_SYMBOL(vmci_device_get); > > > > EXPORT_SYMBOL_GPL() for this, and all other exports? > > We'd prefer to leave them as vanilla exports. While we're committed > to open-sourcing everything, including our non-up

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Andy King
Hi Greg, > > +EXPORT_SYMBOL(vmci_device_get); > > EXPORT_SYMBOL_GPL() for this, and all other exports? We'd prefer to leave them as vanilla exports. While we're committed to open-sourcing everything, including our non-upstreamed drivers, we don't really have a strong opinion regarding consuming

Re: [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Mon, Oct 15, 2012 at 05:28:47PM -0700, George Zhang wrote: > +/* > + * vmci_device_get() - Checks for VMCI device. > + * @api_version:The API version to use > + * @device_shutdown_cb: Callback used when shutdown happens (Unused) > + * @user_data: Data to be passed to the callback (Unuse

Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)

2012-10-25 Thread gre...@linuxfoundation.org
On Thu, Oct 25, 2012 at 03:05:43PM +0100, Jan Beulich wrote: > >>> On 25.10.12 at 15:46, Konrad Rzeszutek Wilk > >>> wrote: > > On Thu, Oct 25, 2012 at 11:48:30AM +0100, Stefano Stabellini wrote: > >> On Thu, 25 Oct 2012, Jan Beulich wrote: > >> > >>> On 24.10.12 at 23:33, Randy Dunlap wrote: >

Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)

2012-10-25 Thread Konrad Rzeszutek Wilk
On Thu, Oct 25, 2012 at 11:48:30AM +0100, Stefano Stabellini wrote: > On Thu, 25 Oct 2012, Jan Beulich wrote: > > >>> On 24.10.12 at 23:33, Randy Dunlap wrote: > > > On 10/23/2012 09:19 PM, Stephen Rothwell wrote: > > > > > >> Hi all, > > >> > > >> Changes since 201201023: > > >> > > > > > > o

Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)

2012-10-25 Thread Jan Beulich
>>> On 25.10.12 at 15:46, Konrad Rzeszutek Wilk wrote: > On Thu, Oct 25, 2012 at 11:48:30AM +0100, Stefano Stabellini wrote: >> On Thu, 25 Oct 2012, Jan Beulich wrote: >> > >>> On 24.10.12 at 23:33, Randy Dunlap wrote: >> > > On 10/23/2012 09:19 PM, Stephen Rothwell wrote: >> > > >> > >> Hi all,

Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)

2012-10-25 Thread Stefano Stabellini
On Thu, 25 Oct 2012, Jan Beulich wrote: > >>> On 24.10.12 at 23:33, Randy Dunlap wrote: > > On 10/23/2012 09:19 PM, Stephen Rothwell wrote: > > > >> Hi all, > >> > >> Changes since 201201023: > >> > > > > on x86_64: > > > > drivers/built-in.o: In function `dbgp_reset_prep': > > (.text+0xb96b5

Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)

2012-10-25 Thread Jan Beulich
>>> On 24.10.12 at 23:33, Randy Dunlap wrote: > On 10/23/2012 09:19 PM, Stephen Rothwell wrote: > >> Hi all, >> >> Changes since 201201023: >> > > on x86_64: > > drivers/built-in.o: In function `dbgp_reset_prep': > (.text+0xb96b5): undefined reference to `xen_dbgp_reset_prep' > drivers/built-