Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread David Miller
From: Jason Wang Date: Fri, 14 Dec 2018 12:29:54 +0800 > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: >> On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: >>> Hi: >>> >>> This series tries to access virtqueue metadata through kernel virtual >>> address instead of copy_user() frien

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

2018-12-18 Thread David Miller
From: Pavel Tikhomirov Date: Thu, 13 Dec 2018 17:53:50 +0300 > We've failed to copy and process vhost_iotlb_msg so let userspace at > least know about it. For instance before these patch the code below runs > without any error: ... > Signed-off-by: Pavel Tikhomirov Michael, will you be taking

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-18 Thread David Miller
From: Jason Wang Date: Fri, 14 Dec 2018 11:57:35 +0800 > This is the price of all GUP users not only vhost itself. What's more > important, the goal is not to be left too much behind for other > backends like DPDK or AF_XDP (all of which are using GUP). +1 ___

Re: [PATCH] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread David Miller
From: Jorgen Hansen Date: Wed, 12 Dec 2018 01:38:59 -0800 > static int vmci_transport_send_reset_bh(struct sockaddr_vm *dst, > @@ -312,12 +328,29 @@ static int vmci_transport_send_reset_bh(struct > sockaddr_vm *dst, > static int vmci_transport_send_reset(struct sock *sk, >

Re: [PATCH v2] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread David Miller
From: Jorgen Hansen Date: Tue, 18 Dec 2018 00:34:06 -0800 > If a server side socket is bound to an address, but not in the listening > state yet, incoming connection requests should receive a reset control > packet in response. However, the function used to send the reset > silently drops the res

Re: [PATCH net-next] netdevice: document NETDEV_TX_BUSY deprecation.

2015-04-03 Thread David Miller
etdev/msg322350.html > > Inspired-by: David Miller > Signed-off-by: Rusty Russell Applied. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH net-next] virtio: document queue state logic

2015-04-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 2 Apr 2015 13:05:47 +0200 > commit d631b94e7a15277858ec5f88d674d93080506999 > virtio: change comment in transmit > > started clarifying the logic behind queue state management, > but introduced an inaccuracy: TX_BUSY does not cause > a BUG message. > >

Re: [PATCH v6 2/8] tun: add tun_is_little_endian() helper

2015-06-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 1 Jun 2015 12:29:43 +0200 > On Fri, Apr 24, 2015 at 02:24:38PM +0200, Greg Kurz wrote: >> Signed-off-by: Greg Kurz > > Dave, could you please ack merging this through > the virtio tree? Acked-by: David S. Miller ___

Re: [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper

2015-06-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 1 Jun 2015 12:30:16 +0200 > On Fri, Apr 24, 2015 at 02:24:48PM +0200, Greg Kurz wrote: >> Signed-off-by: Greg Kurz > > Dave, could you pls ack merging this through the virtio tree? Acked-by: David S. Miller ___

Re: [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1

2015-07-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 15 Jul 2015 15:26:19 +0300 > ANY_LAYOUT is a compatibility feature. It's implied > for VERSION_1 devices, and non-transitional devices > might not offer it. Change code to behave accordingly. > > Signed-off-by: Michael S. Tsirkin Applied. _

Re: [PATCH net-next] virtio_net: add gro capability

2015-07-31 Thread David Miller
From: Eric Dumazet Date: Fri, 31 Jul 2015 18:25:17 +0200 > From: Eric Dumazet > > Straightforward patch to add GRO processing to virtio_net. > ... > Signed-off-by: Eric Dumazet > Tested-by: Rick Jones > Cc: "Michael S. Tsirkin" Michael, please review :-) __

Re: [PATCH net-next] virtio_net: add gro capability

2015-08-03 Thread David Miller
From: Eric Dumazet Date: Fri, 31 Jul 2015 18:25:17 +0200 > From: Eric Dumazet > > Straightforward patch to add GRO processing to virtio_net. > > napi_complete_done() usage allows more aggressive aggregation, > opted-in by setting /sys/class/net/xxx/gro_flush_timeout > > Tested: > > Setting /

Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

2015-08-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 6 Aug 2015 16:13:11 +0300 > On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote: >> virtio declares support for NETIF_F_FRAGLIST, but assumes >> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't >> always true with a fraglist. >> >> A lon

Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

2015-08-07 Thread David Miller
From: Jason Wang Date: Wed, 5 Aug 2015 10:34:04 +0800 > virtio declares support for NETIF_F_FRAGLIST, but assumes > that there are at most MAX_SKB_FRAGS + 2 fragments which isn't > always true with a fraglist. > > A longer fraglist in the skb will make the call to skb_to_sgvec overflow > the sg

Re: [PATCH net-next] virtio-net: avoid unnecessary sg initialzation

2015-08-27 Thread David Miller
From: Jason Wang Date: Thu, 27 Aug 2015 14:53:06 +0800 > Usually an skb does not have up to MAX_SKB_FRAGS frags. So no need to > initialize the unuse part of sg. This patch initialize the sg based on > the real number it will used: > > - during xmit, it could be inferred from nr_frags and can_pu

Re: [PATCH] Fix AF_PACKET ABI breakage in 4.2

2015-09-23 Thread David Miller
From: David Woodhouse Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too. ___ Virtualization mailing list Virtu

Re: [PATCH] VSOCK: sock_put wasn't safe to call in interrupt context

2015-10-22 Thread David Miller
From: Jorgen Hansen Date: Wed, 21 Oct 2015 04:53:56 -0700 > In the vsock vmci_transport driver, sock_put wasn't safe to call > in interrupt context, since that may call the vsock destructor > which in turn calls several functions that should only be called > from process context. This change defe

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian is > checking is_le

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian is > checking is_le

Re: [PATCH] VSOCK: define VSOCK_SS_LISTEN once only

2015-11-01 Thread David Miller
From: Stefan Hajnoczi Date: Thu, 29 Oct 2015 11:57:42 + > The SS_LISTEN socket state is defined by both af_vsock.c and > vmci_transport.c. This is risky since the value could be changed in one > file and the other would be out of sync. > > Rename from SS_LISTEN to VSOCK_SS_LISTEN since the

Re: [PATCH] vhost: move is_le setup to the backend

2015-11-02 Thread David Miller
From: Greg Kurz Date: Fri, 30 Oct 2015 12:42:35 +0100 > The vq->is_le field is used to fix endianness when accessing the vring via > the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases: > > 1) host is big endian and device is modern virtio > > 2) host has cross-endian suppo

Re: [PATCH net-next 0/3] basic busy polling support for vhost_net

2015-11-29 Thread David Miller
From: Jason Wang Date: Wed, 25 Nov 2015 15:11:26 +0800 > This series tries to add basic busy polling for vhost net. The idea is > simple: at the end of tx/rx processing, busy polling for new tx added > descriptor and rx receive socket for a while. The maximum number of > time (in us) could be spe

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 10:34:07 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/

Re: [PATCH v2] vhost: replace % with & on data path

2015-11-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 11:15:23 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin Acked-by: David S. Miller ___ Virtualization mailing list Virtualization@li

Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-03 Thread David Miller
From: Stefan Hajnoczi Date: Wed, 2 Dec 2015 14:43:58 +0800 > This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). Series applied, thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

2015-12-06 Thread David Miller
From: Julia Lawall Date: Sun, 6 Dec 2015 06:56:23 +0100 (CET) > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > CC: Asias He > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall Applied to net-next, thanks. __

Re: [PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

2015-12-08 Thread David Miller
From: Stefan Hajnoczi Date: Tue, 8 Dec 2015 19:57:30 +0800 > Please revert for now. Please don't revert it piece by piece like this. Instead, send me one big revert commit that undoes the whole thing. There is even a merge commit that you can use to create that revert cleanly. Thanks. __

Re: [PATCH] vhost: vsock: select CONFIG_VHOST

2015-12-08 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 8 Dec 2015 18:09:44 +0200 > On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote: >> When building the new vsock code without vhost, we get a build error: >> >> drivers/built-in.o: In function `vhost_vsock_flush': >> :(.text+0x24d29c): undefined ref

Re: [PATCH v2] Revert "Merge branch 'vsock-virtio'"

2015-12-08 Thread David Miller
From: Stefan Hajnoczi Date: Wed, 9 Dec 2015 10:51:12 +0800 > This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421 and merge > commit c402293bd76fbc93e52ef8c0947ab81eea3ae019, reversing changes made > to c89359a42e2a49656451569c382eed63e781153c. > > The virtio-vsock device specification

Re: [PATCH 07/34] sparc: reuse asm-generic/barrier.h

2015-12-30 Thread David Miller
I find it a little bit irritating when I receive a patch directly addressed to me to review, but I don't see the "00/34" cover letter. I want to see what this series is about, and what the motiviation for this change is. I'm also highly frustrated, in general, with mix-and-match CC: lists for pa

Re: [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt

2015-12-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 30 Dec 2015 14:58:19 +0200 > -. Patch 1 documents the __smp APIs, and explains why they are >useful for virt If virt is doing things like interacting with descriptors that are shared with a (potentially SMP) host, why don't we just annotate those specifi

Re: [PATCH 07/34] sparc: reuse asm-generic/barrier.h

2015-12-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 30 Dec 2015 21:55:33 +0200 > The problem I had in the past is that vger rejects email with > too many CC addresses. I can't think of a patch set where a > 1024 character CC: list is legitimate anyways, even if all interested parties are included. > I'll loo

Re: [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt

2015-12-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 30 Dec 2015 23:36:29 +0200 > On Wed, Dec 30, 2015 at 03:46:46PM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Wed, 30 Dec 2015 14:58:19 +0200 >> >> > -. Patch 1 documents the __smp APIs,

Re: [PATCH v2 07/32] sparc: reuse asm-generic/barrier.h

2015-12-31 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 31 Dec 2015 21:06:38 +0200 > On sparc 64 bit dma_rmb, dma_wmb, smp_store_mb, smp_mb, smp_rmb, > smp_wmb, read_barrier_depends and smp_read_barrier_depends match the > asm-generic variants exactly. Drop the local definitions and pull in > asm-generic/barrier.h

Re: [PATCH v2 24/32] sparc: define __smp_xxx

2015-12-31 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 31 Dec 2015 21:08:53 +0200 > This defines __smp_xxx barriers for sparc, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > Signed-off-by: Michael S. Tsirkin > Acked-by: Arnd Bergmann

Re: bonding (IEEE 802.3ad) not working with qemu/virtio

2016-01-29 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 29 Jan 2016 22:48:26 +0100 > On 01/29/2016 10:45 PM, Jay Vosburgh wrote: >> Nikolay Aleksandrov wrote: >> >>> On 01/25/2016 05:24 PM, Bjørnar Ness wrote: As subject says, 802.3ad bonding is not working with virtio network model. The only error

Re: [PATCH V3 0/3] basic busy polling support for vhost_net

2016-02-26 Thread David Miller
From: Jason Wang Date: Fri, 26 Feb 2016 16:42:41 +0800 > This series tries to add basic busy polling for vhost net. The idea is > simple: at the end of tx/rx processing, busy polling for new tx added > descriptor and rx receive socket for a while. The maximum number of > time (in us) could be spe

Re: [PATCH] VSOCK: Only check error on skb_recv_datagram when skb is NULL

2016-04-19 Thread David Miller
From: Jorgen Hansen Date: Mon, 18 Apr 2016 23:58:52 -0700 > If skb_recv_datagram returns an skb, we should ignore the err > value returned. Otherwise, datagram receives will return EAGAIN > when they have to wait for a datagram. > > Acked-by: Adit Ranadive > Signed-off-by: Jorgen Hansen Appli

Re: [PATCH V3 0/2] vhost_net polling optimization

2016-06-02 Thread David Miller
From: Jason Wang Date: Wed, 1 Jun 2016 01:56:32 -0400 > This series tries to optimize vhost_net polling at two points: > > - Stop rx polling for reduicng the unnecessary wakeups during > handle_rx(). > - Conditonally enable tx polling for reducing the unnecessary > traversing and spinlock t

Re: [PATCH v3] virtio-net: Add initial MTU advice feature

2016-06-06 Thread David Miller
From: Aaron Conole Date: Fri, 3 Jun 2016 16:57:12 -0400 > This commit adds the feature bit and associated mtu device entry for the > virtio network device. When a virtio device comes up, it checks the > feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is > enabled, the driver

Re: [PATCH V3 1/2] vhost_net: stop polling socket during rx processing

2016-06-07 Thread David Miller
From: Jason Wang Date: Wed, 1 Jun 2016 01:56:33 -0400 > We don't stop rx polling socket during rx processing, this will lead > unnecessary wakeups from under layer net devices (E.g > sock_def_readable() form tun). Rx will be slowed down in this > way. This patch avoids this by stop polling socke

Re: [PATCH] macvtap: fix bugon.cocci warnings

2016-06-08 Thread David Miller
From: Julia Lawall Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST) > Use BUG_ON instead of a if condition followed by BUG. > > Generated by: scripts/coccinelle/misc/bugon.cocci > > CC: Mike Rapoport > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu This doesn't apply cleanly to any o

Re: [PATCH -next] virtio_net: Update the feature bit to comply with spec

2016-06-09 Thread David Miller
From: Aaron Conole Date: Thu, 9 Jun 2016 13:41:15 -0400 > A draft version of the MTU Advice feature bit was specified as 25. This > bit is not within the allowed range for network device feature bits, and > should be changed to be feature bit 3 to fully comply with the spec. > > Fixes 14de9d11

Re: [PATCH 0/6] virtio_net: use common code for virtio_net_hdr and skb GSO conversion

2016-06-10 Thread David Miller
From: Mike Rapoport Date: Wed, 8 Jun 2016 16:09:16 +0300 > This patches introduce virtio_net_hdr_{from,to}_skb functions for > conversion of GSO information between skb and virtio_net_hdr. Looks like a nice cleanup to me, series applied, thanks Mike.

Re: [PATCH net-next V2] tun: introduce tx skb ring

2016-06-16 Thread David Miller
From: Jason Wang Date: Wed, 15 Jun 2016 16:38:17 +0800 > We used to queue tx packets in sk_receive_queue, this is less > efficient since it requires spinlocks to synchronize between producer > and consumer. > > This patch tries to address this by: > > - introduce a new mode which will be only e

Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun

2016-07-01 Thread David Miller
From: Jason Wang Date: Thu, 30 Jun 2016 14:45:30 +0800 > This series tries to switch to use skb array in tun. This is used to > eliminate the spinlock contention between producer and consumer. The > conversion was straightforward: just introdce a tx skb array and use > it instead of sk_receive_qu

Re: [PATCH] VSOCK: Don't dec ack backlog twice for rejected connections

2016-09-27 Thread David Miller
From: Jorgen Hansen Date: Mon, 26 Sep 2016 23:59:53 -0700 > If a pending socket is marked as rejected, we will decrease the > sk_ack_backlog twice. So don't decrement it for rejected sockets > in vsock_pending_work(). > > Testing of the rejected socket path was done through code > modifications.

Re: [PATCH/RFC 0/5] cpu_relax: introduce yield, remove lowlatency

2016-10-21 Thread David Miller
From: Christian Borntraeger Date: Fri, 21 Oct 2016 17:08:54 +0200 > On 10/21/2016 04:57 PM, David Miller wrote: >> From: Christian Borntraeger >> Date: Fri, 21 Oct 2016 13:58:53 +0200 >> >>> For spinning loops people did often use barrier() or cpu_relax(). >&g

Re: [PATCH v2 net-next] virtio-net: Update the mtu code to match virtio spec

2016-10-29 Thread David Miller
From: Aaron Conole Date: Tue, 25 Oct 2016 16:12:12 -0400 > The virtio committee recently ratified a change, VIRTIO-152, which > defines the mtu field to be 'max' MTU, not simply desired MTU. > > This commit brings the virtio-net device in compliance with VIRTIO-152. > > Additionally, drop the m

Re: [PATCH] virtio-net: drop legacy features in virtio 1 mode

2016-11-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 4 Nov 2016 12:55:36 +0200 > Virtio 1.0 spec says VIRTIO_F_ANY_LAYOUT and VIRTIO_NET_F_GSO are > legacy-only feature bits. Do not negotiate them in virtio 1 mode. Note > this is a spec violation so we need to backport it to stable/downstream > kernels. > > C

Re: [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-28 Thread David Miller
From: Shreyas Bhatewara Date: Mon, 28 Sep 2009 16:56:45 -0700 > + uint32_t rxdIdx:12;/* Index of the RxDesc */ Don't use uint32_t et al. sized types, use "u32" and friends throughout. ___ Virtualization mailing list Virtualization@lists.linux

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-28 Thread David Miller
From: Alok Kataria Date: Mon, 28 Sep 2009 17:51:39 -0700 > As a side note, were there any changes in the networking API's, that we > should look out for in the merge cycle ? > If not I think the rebase should be pretty trivial. Just off the top of my head, the return type of the driver transmit

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-29 Thread David Miller
From: Bhavesh Davda Date: Tue, 29 Sep 2009 12:52:05 -0700 >> One thing that should possibly be fixed is the naming of identifiers, >> e.g. >> 's/Vmxnet3_MiscConf/vmxnet3_misc_conf/g', unless these header files are >> shared with the host implementation. > > These header files are indeed shared w

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread David Miller
From: Stephen Hemminger Date: Wed, 30 Sep 2009 17:39:23 -0700 > Why not use NETIF_F_LRO and ethtool to control LRO support? In fact, you must, in order to handle bridging and routing correctly. Bridging and routing is illegal with LRO enabled, so the kernel automatically issues the necessary et

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-01 Thread David Miller
From: Shreyas Bhatewara Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > +{ > + struct vmxnet3_adapter *adapter = netdev_priv(netdev); > + u8 *base; > + int i; > + > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, > VMXNET3_CMD_GET_STATS); > + > + /* this does assume each counter

Re: [PATCH 2.6.32-rc4] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-13 Thread David Miller
From: Shreyas Bhatewara Date: Mon, 12 Oct 2009 15:18:42 -0700 (PDT) > > Ethernet NIC driver for VMware's vmxnet3 > > From: Shreyas Bhatewara > > This patch adds driver support for VMware's virtual Ethernet NIC: vmxnet3 > Guests running on VMware hypervisors supporting vmxnet3 device will thus

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 26 Oct 2009 11:07:13 +0200 > Another, and hopefully the last, note, is that > git-am can only handle Subject/From lines > at the beginning of the message. > So git style of the mail would be ... > I think it's weird. We could invent some kind of separator >

Re: [PATCHv7 1/3] tun: export underlying socket

2009-11-04 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 3 Nov 2009 19:24:00 +0200 > Assuming it's okay with davem, I think it makes sense to merge this > patch through Rusty's tree because vhost is the first user of the new > interface. Posted here for completeness. I'm fine with that, please add my: Acked-by:

Re: [PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread David Miller
From: Patrick McHardy Date: Thu, 26 Nov 2009 17:26:17 +0100 > Arnd Bergmann wrote: >> Version 2 description: >> The patch to iproute2 has not changed, so I'm not including >> it this time. Patch 4/4 (the netlink interface) is basically >> unchanged as well but included for completeness. >> >> Th

Re: [RFC] macvlan: add tap device backend

2009-12-14 Thread David Miller
From: Arnd Bergmann Date: Mon, 14 Dec 2009 13:00:36 +0100 > c) prepare a combined patch for net-next.git, or This is probably fine. I'll be taking patches into net-next-2.6 right after Linus releases 2.6.33-rc1. ___ Virtualization mailing list Virtual

Re: [PATCH 0/2] virtio net improvements

2010-02-02 Thread David Miller
From: Rusty Russell Date: Wed, 3 Feb 2010 09:57:06 +1030 > On Fri, 29 Jan 2010 11:46:43 pm Rusty Russell wrote: >> Hi Dave, >> >>Nice driver optimization from Shirley, but requires a new virtio hook. >> Do you want to take both? I have nothing else overlapping it. > > Dave, any news on thi

Re: [PATCH 1/2] virtio: Add ability to detach unused buffers from vrings

2010-02-02 Thread David Miller
From: Rusty Russell Date: Fri, 29 Jan 2010 23:49:05 +1030 > From: Shirley Ma > > There's currently no way for a virtio driver to ask for unused > buffers, so it has to keep a list itself to reclaim them at shutdown. > This is redundant, since virtio_ring stores that information. So > add a new

Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path Date: Wed, 13 Jan 2010 12:53:38 -0800

2010-02-02 Thread David Miller
From: Rusty Russell Date: Fri, 29 Jan 2010 23:50:04 +1030 > From: Shirley Ma > > virtio_net receives packets from its pre-allocated vring buffers, then it > delivers these packets to upper layer protocols as skb buffs. So it's not > necessary to pre-allocate skb for each mergable buffer, then

Re: [PATCH 0/3 v4] macvtap driver

2010-02-03 Thread David Miller
From: Arnd Bergmann Date: Sat, 30 Jan 2010 23:22:15 +0100 > This is the fourth version of the macvtap driver, > based on the comments I got for the last version > I got a few days ago. Very few changes: > > * release netdev in chardev open function so > we can destroy it properly. > * Implemen

Re: [PATCH] vhost-net: switch to smp barriers

2010-02-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Sat, 13 Feb 2010 19:39:11 +0200 > Dave, I see it's marked "not applicable": > http://patchwork.ozlabs.org/patch/44207/ > the patch applies to net-next as of > b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73. > Can this be queued up please? > Should I resubmit with Rusty'

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
Just for the record I'm generally not interested in vhost patches. If it's a specific network one that will be merged via the networking tree, yes please CC: me. But if it's a bunch of changes to vhost.c and other pieces of infrastructure, feel free to leave me out of it. It just clutters my al

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 07:37:37 +0200 > Dave, so while Rusty's on vacation, what's the best way to get vhost > infrastructure fixes in? Are you ok with getting pull requests and > merging them into net-next? That should keep the clutter in your inbox > to the minimum.

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 09:34:25 +0200 > Implicitly, I guess. He said "if there's an issue Michael Tsirkin is the > best person to resolve it", this was wrt merging his virtio&lguest tree. > He didn't mention vhost, I wrote all of vhost though, there shouldn't be > an is

Re: [GIT PULL] vhost-net fixes for 2.6.34

2010-02-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 28 Feb 2010 20:44:40 +0200 > The following changes since commit 655ffee284dfcf9a24ac0343f3e5ee6db85b85c5: > Jiri Pirko (1): > wireless: convert to use netdev_for_each_mc_addr > > are available in the git repository at: > > git://git.kernel.org/p

Re: [GIT PULL] vhost-net fixes for issues in 2.6.34-rc1

2010-03-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 18 Mar 2010 11:53:55 +0200 > The following tree includes patches fixing issues with vhost-net in > 2.6.34-rc1. Please pull them for 2.6.34. Pulled, thanks a lot. ___ Virtualization mailing list Virtualization@list

Re: [GIT PULL] vhost-net fix for 2.6.34-rc3

2010-04-07 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 7 Apr 2010 20:35:02 +0300 > David, > The following tree includes a patch fixing an issue with vhost-net in > 2.6.34-rc3. Please pull for 2.6.34. Pulled, thanks Michael. ___ Virtualization mailing list Virtualizati

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: David Miller Date: Mon, 03 May 2010 15:07:29 -0700 (PDT) > From: "Michael S. Tsirkin" > Date: Tue, 4 May 2010 00:32:45 +0300 > >> The following tree includes a couple of enhancements that help vhost-net. >> Please pull them for net-next. Another set o

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 4 May 2010 00:32:45 +0300 > The following tree includes a couple of enhancements that help vhost-net. > Please pull them for net-next. Another set of patches is under > debugging/testing and I hope to get them ready in time for 2.6.35, > so there may be anoth

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-04 Thread David Miller
From: Pankaj Thakkar Date: Tue, 4 May 2010 17:18:57 -0700 > The purpose of this email is to introduce the architecture and the > design principles. The overall project involves more than just > changes to vmxnet3 driver and hence we though an overview email > would be better. Once people agree to

Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next

2010-05-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 4 May 2010 14:21:01 +0300 > This is an amended pull request: I have rebased the tree to the > correct patches. This has been through basic tests and seems > to work fine here. > > The following tree includes a couple of enhancements that help vhost-net. > Pl

Re: [GIT PULL] last minute vhost-net fix

2010-05-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 13 May 2010 11:44:34 +0300 > David, if it's not too late, please pull the following > last minute fix into 2.6.34. Pulled, thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://l

Re: [PATCH] vhost-net: utilize PUBLISH_USED_IDX feature

2010-05-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 18 May 2010 04:19:31 +0300 > With PUBLISH_USED_IDX, guest tells us which used entries > it has consumed. This can be used to reduce the number > of interrupts: after we write a used entry, if the guest has not yet > consumed the previous entry, or if the gues

Re: [PATCH] [resend] fix non-mergeable buffers packet too large error handling

2010-05-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 18 May 2010 06:12:52 +0300 > DaveM, just to clarify, this patch is on top of the series > we are working on with David L Stevens. It's not for your net tree. Understood. ___ Virtualization mailing list Virtualizati

Re: [GIT PULL net-2.6] vhost-net: error handling fixes

2010-05-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 27 May 2010 14:57:14 +0300 > David, > The following tree includes fixes dealing with error handling > in vhost-net. It is on top of net-2.6. > Please merge it for 2.6.35. > Thanks! > > The following changes since commit 8a74ad60a546b13bd1096b2a61a7a5c6fd9ae1

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 28 Jun 2010 13:08:07 +0300 > Userspace virtio server has the following hack > so guests rely on it, and we have to replicate it, too: > > Use port number to detect incoming IPv4 DHCP response packets, > and fill in the checksum for these. > > The issue we a

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 29 Jun 2010 16:04:39 +0300 > Since using the module involves updating the management tools > as well, if we go down this route it will be much less painful > for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if he'll merg

Re: [GIT PULL net-2.6] vhost-net: more error handling fixes

2010-07-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 1 Jul 2010 19:41:27 +0300 > David, > The following tree includes more fixes dealing with > error handling in vhost-net. It is on top of net-2.6. > Please merge it for 2.6.35. > Thanks! > > The following changes since commit 38000a94a902e94ca8b5498f7871c6316d

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-07-14 Thread David Miller
From: Pankaj Thakkar Date: Wed, 14 Jul 2010 10:18:22 -0700 > The plugin is guest agnostic and hence we did not want to rely on > any kernel provided functions. While I disagree entirely with this kind of approach, even that doesn't justify what you're doing here. memcpy() and memset() are on a

Re: [GIT PULL] vhost-net fixes

2010-07-16 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 16 Jul 2010 15:25:30 +0300 > David, please pull the following fixes for 2.6.35. > Thanks! > > The following changes since commit 91a72a70594e5212c97705ca6a694bd307f7a26b: > > net/core: neighbour update Oops (2010-07-14 18:02:16 -0700) > > are available i

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.36

2010-08-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 28 Jul 2010 16:32:31 +0300 > The following changes since commit 4cfa580e7eebb8694b875d2caff3b989ada2efac: > > r6040: Fix args to phy_mii_ioctl(). (2010-07-21 21:10:49 -0700) > > are available in the git repository at: > git://git.kernel.org/pub/scm/linu

Re: [GIT PULL net-2.6] vhost-net: 2.6.36 regression fixes

2010-09-09 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 6 Sep 2010 14:36:06 +0300 > The following tree includes more regression fixes for vhost-net > in 2.6.36. It is on top of net-2.6. > Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization mailing li

Re: [GIT PULL net-2.6] vhost-net: fix range checking

2010-09-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 20 Sep 2010 19:42:22 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks! ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-fou

Re: [GIT PULL net-2.6] vhost-net: last minute fix

2010-09-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 27 Sep 2010 15:34:13 +0200 > The following tree includes a last minute bugfix for vhost-net. > It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization mailing list Virtualiz

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.37

2010-10-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 5 Oct 2010 20:27:32 +0200 > It looks like it was a quiet cycle for vhost-net: > probably because most of energy was spent on bugfixes > that went in for 2.6.36. > People are working on multiqueue, tracing but I'm not > sure it'll get done in time for 2.6.37 -

Re: [GIT PULL net-2.6] vhost-net: access_ok fix

2010-10-21 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 19 Oct 2010 16:59:01 +0200 > David, > Not sure if it's too late for 2.6.36 - in case it's not, the following tree > includes a last minute bugfix for vhost-net, found by code inspection. > It is on top of net-2.6. > Thanks! > > The following changes since co

Re: [GIT PULL net-2.6] vhost-net: rcu fixup

2010-11-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 25 Nov 2010 14:23:01 +0200 > Please merge the following fix for 2.6.36. > Thanks! > > The following changes since commit a27e13d370415add3487949c60810e36069a23a6: > > econet: fix CVE-2010-3848 (2010-11-24 11:51:47 -0800) > > are available in the git repo

Re: [GIT PULL net-2.6] vhost-net: logging fixup

2010-12-12 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 12 Dec 2010 12:09:43 +0200 > Please merge the following fix for 2.6.37. > It is also applicable to -stable. > Thanks! > > The following changes since commit a19faf0250e09b16cac169354126404bc8aa342b: > > net: fix skb_defer_rx_timestamp() (2010-12-10 16:20:

Re: [GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 14 Dec 2010 14:23:26 +0200 > On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: >> Please merge the following tree for 2.6.38. >> Thanks! > > Rusty Acked it as is, so please pull the below. > Thanks very much! > >> The following changes sin

Re: [PULL] vhost-net: 2.6.38 fix

2011-01-14 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 14 Jan 2011 11:33:02 +0200 > Please pull the following for 2.6.38. > Thanks! > > The following changes since commit 0c21e3aaf6ae85bee804a325aa29c325209180fd: > > Merge branch 'for-next' of > git://git.kernel.org/pub/scm/linux/kernel/git/hch/hfsplus (2011

Re: [PULL] vhost-net: 2.6.38 - warning fix

2011-02-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 1 Feb 2011 17:44:40 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks Michael. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linu

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 10 Feb 2011 19:57:26 +0200 > On Thu, Feb 10, 2011 at 12:32:50PM +1030, Rusty Russell wrote: >> From: "Bruce Rogers" >> >> Under harsh testing conditions, including low memory, the guest would >> stop receiving packets. With this patch applied we no longer s

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: Rusty Russell Date: Thu, 10 Feb 2011 12:32:50 +1030 > From: "Bruce Rogers" > > Under harsh testing conditions, including low memory, the guest would > stop receiving packets. With this patch applied we no longer see any > problems in the driver while performing these tests for extended pe

Re: [PATCH] vhost: copy_from_user -> __copy_from_user

2011-03-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 6 Mar 2011 13:33:49 +0200 > copy_from_user is pretty high on perf top profile, > replacing it with __copy_from_user helps. > It's also safe because we do access_ok checks during setup. > > Signed-off-by: Michael S. Tsirkin Is Rusty going to take this or sh

Re: [PULL net-2.6] vhost: cleanups and fixes

2011-03-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 17 Mar 2011 16:04:04 +0200 > The following changes since commit 1fc050a13473348f5c439de2bb41c8e92dba5588: > > ipv4: Cache source address in nexthop entries. (2011-03-07 20:54:48 -0800) > > are available in the git repository at: > git://git.kernel.org/p

Re: [PATCH] virtio_net: convert to hw_features

2011-04-01 Thread David Miller
From: Michał Mirosław Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST) > Signed-off-by: Michał Mirosław Applied. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

<    1   2   3   4   5   6   >