[PATCH] vhost-scsi: Spelling s/preceeding/preceding/g

2023-09-28 Thread Geert Uytterhoeven
Fix a misspelling of "preceding". Signed-off-by: Geert Uytterhoeven --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index abef0619c7901af0..2d689181bafef241 100644 --- a/drivers/vhost/scsi.c +++

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Geert Uytterhoeven
uot; | sort | uniq -c | sort -rn | > head -20 > 38494 struct device *dev > 16388 struct net_device *dev >4184 struct drm_device *dev >2780 struct pci_dev *dev >1916 struct comedi_device *dev >1510 struct mlx5_core_dev *dev > 1057 struct mlx4_dev *dev

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-12 Thread Geert Uytterhoeven
in the shmob_drm-specific subclasses of drm_{crtc,connector,plane} to "base". https://lore.kernel.org/dri-devel/b3daca80f82625ba14e3aeaf2fca6dcefa056e47.1687423204.git.geert+rene...@glider.be > Also the functions that deal with both a struct device and a struct > drm_device ofte

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-27 Thread Geert Uytterhoeven
Hi Dmitry, On Mon, Jun 26, 2023 at 6:11 PM Dmitry Osipenko wrote: > On 6/25/23 18:36, Geert Uytterhoeven wrote: > > On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko > > wrote: > >> On 6/25/23 11:47, Geert Uytterhoeven wrote: > >>> On Sun, Apr 16, 2023 at

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-25 Thread Geert Uytterhoeven
Hi Dmitry, On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko wrote: > On 6/25/23 11:47, Geert Uytterhoeven wrote: > > On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko > > wrote: > >> Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects > >> support i

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-25 Thread Geert Uytterhoeven
= 0; i < num_in_syncobjs; i++) { > + u64 address = exbuf->in_syncobjs + i * syncobj_stride; > + struct dma_fence *fence; > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In persona

Re: [PATCH] gpio: aggregator: Add interrupt support

2023-04-13 Thread Geert Uytterhoeven
Hi Kamel, On Thu, Apr 13, 2023 at 9:48 AM wrote: > Le 2021-10-04 14:44, Geert Uytterhoeven a écrit : > What is the status for this patch, is there any remaining > changes to be made ? You mean commit a00128dfc8fc0cc8 ("gpio: aggregator: Add interrupt support") in v5.17?

Re: [PATCH v2 7/9] dt-bindings: drop redundant part of title (beginning)

2022-11-21 Thread Geert Uytterhoeven
/title: \u\2/' {} \; > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Alexandre Belloni > Reviewed-by: Jonathan Cameron > .../devicetree/bindings/interrupt-controller/renesas,irqc.yaml | 2 +- Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 19/36] objtool/idle: Validate __cpuidle code as noinstr

2022-07-06 Thread Geert Uytterhoeven
inux-std.lds |1 - > arch/m68k/kernel/vmlinux-sun3.lds | 1 - FWIW Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peop

Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

2022-06-28 Thread Geert Uytterhoeven
d for compiling userspace. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "prog

[PATCH resend] gpio: aggregator: Add interrupt support

2021-12-03 Thread Geert Uytterhoeven
GPIO controller. Note that this does not implement full interrupt controller (irq_chip) support, so using e.g. gpio-keys with "interrupts" instead of "gpios" still does not work. Signed-off-by: Geert Uytterhoeven --- I would prefer to avoid implementing irq_chip support, u

Re: [PATCH V5 02/10] fork/vm: Move common PF_IO_WORKER behavior to new flag

2021-11-22 Thread Geert Uytterhoeven
t. > > The common behavior PF_USER_WORKER covers is the initial frame and fpu > setup and the vm reclaim handling. > > Signed-off-by: Mike Christie > arch/m68k/kernel/process.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Ge

Re: [PATCH V6] gpio: virtio: Add IRQ support

2021-10-21 Thread Geert Uytterhoeven
Hi Viresh, On Thu, Oct 21, 2021 at 12:49 PM Viresh Kumar wrote: > On 21-10-21, 12:07, Geert Uytterhoeven wrote: > > On Thu, Oct 21, 2021 at 11:52 AM Viresh Kumar > > wrote: > > > The structure will get aligned to the size of largest element and each > > > ele

Re: [PATCH V6] gpio: virtio: Add IRQ support

2021-10-21 Thread Geert Uytterhoeven
he size of the largest element, but to the largest alignment needed for each member. This can be smaller than the size of the largest element. E.g. alignof(long long) might be 4, not 8. And m68k aligns to two bytes at most. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -

Re: [PATCH V4 2/8] fork: move PF_IO_WORKER's kernel frame setup to new flag

2021-10-08 Thread Geert Uytterhoeven
KER into a new PF flag PF_USER_WORKER. > > Signed-off-by: Mike Christie > arch/m68k/kernel/process.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k

Re: [PATCH] gpio: aggregator: Add interrupt support

2021-10-04 Thread Geert Uytterhoeven
Hi Viresh, On Tue, Oct 5, 2021 at 7:50 AM Viresh Kumar wrote: > On 04-10-21, 14:44, Geert Uytterhoeven wrote: > > Currently the GPIO Aggregator does not support interrupts. This means > > that kernel drivers going from a GPIO to an IRQ using gpiod_to_irq(), > > and userspa

Re: [PATCH] gpio: aggregator: Add interrupt support

2021-10-04 Thread Geert Uytterhoeven
Hi Andy, On Mon, Oct 4, 2021 at 3:21 PM Andy Shevchenko wrote: > On Mon, Oct 4, 2021 at 3:45 PM Geert Uytterhoeven > wrote: > > Currently the GPIO Aggregator does not support interrupts. This means > > that kernel drivers going from a GPIO to an IRQ using gpiod_to_irq(),

[PATCH] gpio: aggregator: Add interrupt support

2021-10-04 Thread Geert Uytterhoeven
GPIO controller. Note that this does not implement full interrupt controller (irq_chip) support, so using e.g. gpio-keys with "interrupts" instead of "gpios" still does not work. Signed-off-by: Geert Uytterhoeven --- I would prefer to avoid implementing irq_chip support, u

Re: [PATCH V2 2/9] fork: pass worker_flags to copy_thread

2021-09-22 Thread Geert Uytterhoeven
ker_flags to copy_thread, so in the next patch we can add new worker > flags that function can see. > > Signed-off-by: Mike Christie > arch/m68k/kernel/process.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There

Re: [PATCH V2 3/9] fork: move PF_IO_WORKER's kernel frame setup to new flag

2021-09-22 Thread Geert Uytterhoeven
t wouldn't hurt to add parentheses to improve readability: if (unlikely((p->flags & (PF_KTHREAD)) || (worker_flags & KERN_WORKER_USER))) { > /* kernel thread */ > memset(frame, 0, sizeof(struct fork_frame)); >

Re: [PATCH v4 5/5] bus: Make remove callback return void

2021-07-14 Thread Geert Uytterhoeven
; implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There&#

Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver

2021-06-15 Thread Geert Uytterhoeven
Hi Viresh, On Tue, Jun 15, 2021 at 1:15 PM Viresh Kumar wrote: > On 11-06-21, 10:22, Geert Uytterhoeven wrote: > > The same reasoning can apply to your backend daemon, so when using > > the GPIO aggregator, you can just control a full gpiochip, without > > having to implem

Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver

2021-06-11 Thread Geert Uytterhoeven
Hi Viresh, On Fri, Jun 11, 2021 at 10:01 AM Viresh Kumar wrote: > On 11-06-21, 09:42, Geert Uytterhoeven wrote: > > On Fri, Jun 11, 2021 at 5:56 AM Viresh Kumar > > wrote: > > > On 10-06-21, 22:46, Linus Walleij wrote: > > > > thanks for working on th

Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver

2021-06-11 Thread Geert Uytterhoeven
Aggregator"[2]. [1] https://lore.kernel.org/linux-gpio/20200423090118.11199-1-geert+rene...@glider.be [2] https://lore.kernel.org/linux-doc/20200511145257.22970-1-geert+rene...@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Apr 26, 2021 at 2:22 PM Thomas Zimmermann wrote: > Am 20.04.21 um 11:27 schrieb Geert Uytterhoeven: > > On Tue, Apr 20, 2021 at 11:22 AM Gerd Hoffmann wrote: > >>>>> Patches 4 to 8 add the simpledrm driver. It's build on simple DRM >

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-20 Thread Geert Uytterhoeven
88 or rgb565 > (depending on display resolution). We could pull off the same trick > here and convert to rgb332 (assuming we can program the palette with the > color cube needed for that). Wouldn't look pretty, but would probably > work better than expecting userspace know what co

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-20 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Apr 20, 2021 at 10:46 AM Daniel Vetter wrote: > On Mon, Apr 19, 2021 at 10:00:56AM +0200, Geert Uytterhoeven wrote: > > On Fri, Apr 16, 2021 at 11:00 AM Thomas Zimmermann > > wrote: > > > This patchset adds support for simple-framebuffer platform devi

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-19 Thread Geert Uytterhoeven
d as a replacement for offb, too... > Patches 4 to 8 add the simpledrm driver. It's build on simple DRM helpers > and SHMEM. It supports 16-bit, 24-bit and 32-bit RGB framebuffers. During if support for 8-bit frame buffers would be added? Gr{oetje,eeting}s, Ge

Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node

2021-03-18 Thread Geert Uytterhoeven
sdev->clks[i] = clock; > + } of_clk_bulk_get_all() + clk_bulk_prepare_enable()? There's also devm_clk_bulk_get_all(), but not for the OF variant. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge..

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Geert Uytterhoeven
sed uninitialized" warnings thrown up by gcc-4.1, until (a bit later than) support for that compiler was removed... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal con

Re: [PATCH v4] vhost: disable for OABI

2020-04-26 Thread Geert Uytterhoeven
Ard Biesheuvel > Suggested-by: Richard Earnshaw > Signed-off-by: Michael S. Tsirkin Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call my

Re: [PATCH V2] vhost: do not enable VHOST_MENU by default

2020-04-17 Thread Geert Uytterhoeven
> > > > not set". So this patch tries to enable CONFIG_VHOST > > > > > > > > > > explicitly in > > > > > > > > > > defconfigs that enables CONFIG_VHOST_NET and > > > > > > > > > > CON

Re: Build regressions/improvements in v5.7-rc1

2020-04-13 Thread Geert Uytterhoeven
On Mon, 13 Apr 2020, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.7-rc1[1] compared to v5.6[2]. Summarized: - build errors: +132/-3 - build warnings: +257/-79 Happy fixing! ;-) Thanks to the linux-next team for providing the build service

Re: [PATCH] vdpa-sim: depend on HAS_DMA

2020-04-10 Thread Geert Uytterhoeven
f-by: Michael S. Tsirkin As this fixes the Sun-3 all{mod,yes}-config build, which has NO_DMA=y: Acked-by: Geert Uytterhoeven However, you may want to follow Christoph's suggestion instead. > --- a/drivers/vdpa/Kconfig > +++ b/drivers/vdpa/Kconfig > @@ -14,7 +14,7 @@ if VDPA_

Re: vhost: refine vhost and vringh kconfig

2020-04-10 Thread Geert Uytterhoeven
Hi Jason, On Fri, Apr 10, 2020 at 10:33 AM Jason Wang wrote: > On 2020/4/10 下午3:53, Geert Uytterhoeven wrote: > > On Thu, Apr 9, 2020 at 6:04 AM Linux Kernel Mailing List > > wrote: > >> Commit: 20c384f1ea1a0bc7320bc445c72d

Re: vhost: refine vhost and vringh kconfig

2020-04-10 Thread Geert Uytterhoeven
I think this deserves a help text, so users know if they want to enable this option or not. Thanks! > +if VHOST_MENU > + > config VHOST_NET > tristate "Host kernel accelerator for virtio net" > depends on NET && EVENTFD && (TUN || !TU

Re: [PATCH V9 8/9] vdpasim: vDPA device simulator

2020-04-10 Thread Geert Uytterhoeven
hich loop TX traffic back > + to RX. This device is used for testing, prototyping and > + development of vDPA. > + > +endif # VDPA_MENU Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Geert Uytterhoeven
t > > bring except longer code to read? > > Because the argument is an int: > > drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’: > drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of > ‘ioread32’ makes pointer from integer without a cast

Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-09 Thread Geert Uytterhoeven
emory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven Reviewed

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Christophe, On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy wrote: > Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : > > On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven > > wrote: > >> On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven > >> wrote: >

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Krzysztof, On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven wrote: > On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > > The ioread8/16/32() and others have inconsistent interface among the > > architectures: some taking address as const, some not. > >

Re: [RFT 02/13] alpha: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-08 Thread Geert Uytterhoeven
adw, const volatile) > REMAP1(u32, readl, const volatile) Same for REMAP2() macro below, for iowrite*(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people,

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
hed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux

Re: [PATCH RFC net-next v8 1/3] netdev: pass the stuck queue to the timeout handler

2019-12-08 Thread Geert Uytterhoeven
rs] Error 2 > make: *** [Makefile:179: sub-make] Error 2 Looks like you forgot to update the forward declaration in drivers/net/ethernet/8390/8390.h There may be others... http://kisskb.ellerman.id.au/kisskb/head/6cf8298daad041cd15dc514d8a4f93ca3636c84e/ Gr{oetje,eeting}s,

Re: [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-07 Thread Geert Uytterhoeven
ig.bus | 2 +- > arch/m68k/Kconfig.debug| 16 > arch/m68k/Kconfig.machine | 8 ++++ For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Li

[PATCH trivial] mm/balloon_compaction: Grammar s/the its/its/

2019-07-24 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index ba739b76e6c52e55..17ac81d8d26bcb50 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -60,7

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-17 Thread Geert Uytterhoeven
y about asking if that has been asked already. > > Wouldn't it be slightly less intrusive to simply redefined > pr_warning() as a synonym for pr_warn()? That's already the case. This series cleans up the cruft, so we can catch all users with "git grep -w pr_warn". G

Re: Build regressions/improvements in v4.7-rc6

2016-07-04 Thread Geert Uytterhoeven
On Mon, Jul 4, 2016 at 10:12 AM, Geert Uytterhoeven wrote: > JFYI, when comparing v4.7-rc6[1] to v4.7-rc5[3], the summaries are: > - build errors: +3/-2 + /home/kisskb/slave/src/drivers/vhost/vhost.c: error: call to '__compiletime_assert_844' declared with attribute err

[PATCH 50/54] MAINTAINERS: Add file patterns for virtio device tree bindings

2016-05-22 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven Cc: Michael S. Tsirkin Cc: virtualization@lists.linux-foundation.org --- Please apply this patch directly if you want to be involved in device tree

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-19 Thread Geert Uytterhoeven
On Mon, Oct 19, 2015 at 12:11 PM, Arnd Bergmann wrote: > On Monday 19 October 2015 09:34:15 Geert Uytterhoeven wrote: >> On Wed, Oct 7, 2015 at 1:23 PM, Arnd Bergmann wrote: >> > static __inline__ int atomic64_add_unless(atomic64_t *v, long a, long u) >> > >> &

Re: [PATCH] drm/virtio: use %llu format string form atomic64_t

2015-10-19 Thread Geert Uytterhoeven
-bit ones just #define atomic64_t atomic_long_t, so they don't have >> to provide three sets of functions. > > scratch that, I just looked at all the architectures and found that it's > just completely arbitrary, even within one architecture you get a mix > of 'long' an

Re: [PATCH v3 04/41] virtio: memory access APIs

2014-11-24 Thread Geert Uytterhoeven
On Mon, Nov 24, 2014 at 1:15 PM, Michael S. Tsirkin wrote: > On Mon, Nov 24, 2014 at 01:03:24PM +0100, Geert Uytterhoeven wrote: >> On Mon, Nov 24, 2014 at 12:52 PM, Michael S. Tsirkin wrote: >> > virtio 1.0 makes all memory structures LE, so >> > we need APIs to con

Re: [PATCH v3 04/41] virtio: memory access APIs

2014-11-24 Thread Geert Uytterhoeven
ot;. > */ > struct vring_desc { > /* Address (guest-physical). */ > - __u64 addr; > + __virtio64 addr; ... and __le64? There's already lots of precedence or this, even in include/uapi/. Gr{oetje,eeting}s, Geert -- Geert Uytterhoe

Re: [PATCH stable-only] virtio-net: fix build on m68k and sparc64

2014-01-15 Thread Geert Uytterhoeven
On Wed, Jan 15, 2014 at 9:46 AM, Michael S. Tsirkin wrote: > On Wed, Jan 15, 2014 at 09:36:13AM +0100, Geert Uytterhoeven wrote: >> On Wed, Jan 15, 2014 at 9:26 AM, Michael S. Tsirkin wrote: >> > As a result of backporting a bugfix, virtio_net started passing void * &g

Re: [PATCH stable-only] virtio-net: fix build on m68k and sparc64

2014-01-15 Thread Geert Uytterhoeven
a macro, the result is build failure as the macro tries to dereference > void*. > > Fix by reordering code slightly, so we always pass > struct page * to page_address. Thanks for the clue! I was just investigating a similar failure in -next. Gr{oetje,eeting}s,

Re: [PATCH -tip RFC v2 01/22] kprobes: Prohibit probing on .entry.text code

2013-11-15 Thread Geert Uytterhoeven
Error 2 X86 is the sole architecture that has ENTRY_TEXT in its arch/*/kernel/vmlinux.lds.S. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call my

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

2013-07-11 Thread Geert Uytterhoeven
perhaps based on the theory of regular languages? grep -E "(pat1|pat2|pat3|...)"? Or am I missing something? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with

Re: [PATCH v2, part1 01/29] mm: introduce common help functions to deal with reserved/managed pages

2013-03-10 Thread Geert Uytterhoeven
am_pages and zone->managed_pages, which makes the code > much more clear. > > Signed-off-by: Jiang Liu I have a few minor comments (see below), but apart from that: Acked-by: Geert Uytterhoeven > --- > include/linux/mm.h | 48 +++

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-24 Thread Geert Uytterhoeven
ex_trylock(struct mutex *lock); So that's why the return value was inverted (when treating it as a boolean). I can understand that. However: +/** + * console_trylock - try to lock the console system for exclusive use. + * + * Tried to acquire a lock which guarantees that the caller has + * e