[PATCH] VMCI: Update maintainers for VMCI

2022-02-27 Thread Jorgen Hansen
Remove myself as maintainer for the VMCI driver, and add Bryan and Rajesh. Acked-by: Rajesh Jalisatgi Acked-by: Bryan Tan Acked-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v3 8/8] VMCI: dma dg: add support for DMA datagrams receive

2022-02-07 Thread Jorgen Hansen
opposed to IO port datagrams, where they can start on any page boundary Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 103 ++--- 1 file changed, 79 insertions(+), 24 deletions(-) diff --git a/drivers/misc/vmw_vmci

[PATCH v3 7/8] VMCI: dma dg: add support for DMA datagrams sends

2022-02-07 Thread Jorgen Hansen
plete. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 45 -- include/linux/vmw_vmci_defs.h | 34 ++ 2 files changed, 77 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_guest

[PATCH v3 5/8] VMCI: dma dg: register dummy IRQ handlers for DMA datagrams

2022-02-07 Thread Jorgen Hansen
Register dummy interrupt handlers for DMA datagrams in preparation for DMA datagram receive operations. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 42 +++--- include/linux/vmw_vmci_defs.h | 14 -- 2 files

[PATCH v3 4/8] VMCI: dma dg: set OS page size

2022-02-07 Thread Jorgen Hansen
Tell the device the page size used by the OS. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 4 include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc

[PATCH v3 3/8] VMCI: dma dg: detect DMA datagram capability

2022-02-07 Thread Jorgen Hansen
Detect the VMCI DMA datagram capability, and if present, ack it to the device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 11 +++ include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/misc

[PATCH v3 6/8] VMCI: dma dg: allocate send and receive buffers for DMA datagrams

2022-02-07 Thread Jorgen Hansen
If DMA datagrams are used, allocate send and receive buffers in coherent DMA memory. This is done in preparation for the send and receive datagram operations, where the buffers are used for the exchange of data between driver and device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH v3 2/8] VMCI: dma dg: add MMIO access to registers

2022-02-07 Thread Jorgen Hansen
for accessing 32 bit register accesses through either MMIO or IO ports based on device configuration. Sending and receiving datagrams through iowrite8_rep/ioread8_rep is left unchanged for now, and will be addressed in a later change. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH v3 1/8] VMCI: dma dg: whitespace formatting change for vmci register defines

2022-02-07 Thread Jorgen Hansen
Update formatting of existing register defines in preparation for adding additional register definitions for the VMCI device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- include/linux/vmw_vmci_defs.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PATCH v3 0/8] VMCI: dma dg: Add support for DMA datagrams

2022-02-07 Thread Jorgen Hansen
this happens. v2 (fixes issues flagged by kernel test robot ): - changed type of mmio_base to void __iomem * - made vmci_read_reg, vmci_write_reg and vmci_write_data static functions v3: - removed log messages for page size and BAR resources Jorgen Hansen (8): VMCI: dma dg: whitespace formatting

Re: [PATCH v2 2/8] VMCI: dma dg: add MMIO access to registers

2022-02-07 Thread Jorgen Hansen
> On 4 Feb 2022, at 16.12, Greg KH wrote: > > On Thu, Feb 03, 2022 at 05:12:31AM -0800, Jorgen Hansen wrote: >> Detect the support for MMIO access through examination of the length >> of the region requested in BAR1. If it is 256KB, the VMCI device >> suppor

Re: [PATCH v2 4/8] VMCI: dma dg: set OS page size

2022-02-07 Thread Jorgen Hansen
> On 4 Feb 2022, at 16.12, Greg KH wrote: > > On Thu, Feb 03, 2022 at 05:12:33AM -0800, Jorgen Hansen wrote: >> Tell the device the page size used by the OS. >> >> Reviewed-by: Vishnu Dasa >> Signed-off-by: Jorgen Hansen >> --- >> drivers/misc/v

[PATCH v2 7/8] VMCI: dma dg: add support for DMA datagrams sends

2022-02-03 Thread Jorgen Hansen
plete. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 45 -- include/linux/vmw_vmci_defs.h | 34 ++ 2 files changed, 77 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_guest

[PATCH v2 4/8] VMCI: dma dg: set OS page size

2022-02-03 Thread Jorgen Hansen
Tell the device the page size used by the OS. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 9 + include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc

[PATCH v2 8/8] VMCI: dma dg: add support for DMA datagrams receive

2022-02-03 Thread Jorgen Hansen
opposed to IO port datagrams, where they can start on any page boundary Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 103 ++--- 1 file changed, 79 insertions(+), 24 deletions(-) diff --git a/drivers/misc/vmw_vmci

[PATCH v2 3/8] VMCI: dma dg: detect DMA datagram capability

2022-02-03 Thread Jorgen Hansen
Detect the VMCI DMA datagram capability, and if present, ack it to the device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 11 +++ include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/misc

[PATCH v2 6/8] VMCI: dma dg: allocate send and receive buffers for DMA datagrams

2022-02-03 Thread Jorgen Hansen
If DMA datagrams are used, allocate send and receive buffers in coherent DMA memory. This is done in preparation for the send and receive datagram operations, where the buffers are used for the exchange of data between driver and device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH v2 5/8] VMCI: dma dg: register dummy IRQ handlers for DMA datagrams

2022-02-03 Thread Jorgen Hansen
Register dummy interrupt handlers for DMA datagrams in preparation for DMA datagram receive operations. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 42 +++--- include/linux/vmw_vmci_defs.h | 14 -- 2 files

[PATCH v2 1/8] VMCI: dma dg: whitespace formatting change for vmci register defines

2022-02-03 Thread Jorgen Hansen
Update formatting of existing register defines in preparation for adding additional register definitions for the VMCI device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- include/linux/vmw_vmci_defs.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PATCH v2 2/8] VMCI: dma dg: add MMIO access to registers

2022-02-03 Thread Jorgen Hansen
for accessing 32 bit register accesses through either MMIO or IO ports based on device configuration. Sending and receiving datagrams through iowrite8_rep/ioread8_rep is left unchanged for now, and will be addressed in a later change. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH v2 0/8] VMCI: dma dg: Add support for DMA datagrams

2022-02-03 Thread Jorgen Hansen
this happens. v2 (fixes issues flagged by kernel test robot ): - changed type of mmio_base to void __iomem * - made vmci_read_reg, vmci_write_reg and vmci_write_data static functions Jorgen Hansen (8): VMCI: dma dg: whitespace formatting change for vmci register defines VMCI: dma dg: add MMIO

[PATCH 8/8] VMCI: dma dg: add support for DMA datagrams receive

2022-02-02 Thread Jorgen Hansen
opposed to IO port datagrams, where they can start on any page boundary Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 103 ++--- 1 file changed, 79 insertions(+), 24 deletions(-) diff --git a/drivers/misc/vmw_vmci

[PATCH 6/8] VMCI: dma dg: allocate send and receive buffers for DMA datagrams

2022-02-02 Thread Jorgen Hansen
If DMA datagrams are used, allocate send and receive buffers in coherent DMA memory. This is done in preparation for the send and receive datagram operations, where the buffers are used for the exchange of data between driver and device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH 7/8] VMCI: dma dg: add support for DMA datagrams sends

2022-02-02 Thread Jorgen Hansen
plete. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 44 -- include/linux/vmw_vmci_defs.h | 34 +++ 2 files changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_guest

[PATCH 5/8] VMCI: dma dg: register dummy IRQ handlers for DMA datagrams

2022-02-02 Thread Jorgen Hansen
Register dummy interrupt handlers for DMA datagrams in preparation for DMA datagram receive operations. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 42 +++--- include/linux/vmw_vmci_defs.h | 14 -- 2 files

[PATCH 3/8] VMCI: dma dg: detect DMA datagram capability

2022-02-02 Thread Jorgen Hansen
Detect the VMCI DMA datagram capability, and if present, ack it to the device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 11 +++ include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/misc

[PATCH 4/8] VMCI: dma dg: set OS page size

2022-02-02 Thread Jorgen Hansen
Tell the device the page size used by the OS. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_guest.c | 9 + include/linux/vmw_vmci_defs.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc

[PATCH 1/8] VMCI: dma dg: whitespace formatting change for vmci register defines

2022-02-02 Thread Jorgen Hansen
Update formatting of existing register defines in preparation for adding additional register definitions for the VMCI device. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- include/linux/vmw_vmci_defs.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PATCH 2/8] VMCI: dma dg: add MMIO access to registers

2022-02-02 Thread Jorgen Hansen
for accessing 32 bit register accesses through either MMIO or IO ports based on device configuration. Sending and receiving datagrams through iowrite8_rep/ioread8_rep is left unchanged for now, and will be addressed in a later change. Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen

[PATCH 0/8] VMCI: dma dg: Add support for DMA datagrams

2022-02-02 Thread Jorgen Hansen
this happens. Jorgen Hansen (8): VMCI: dma dg: whitespace formatting change for vmci register defines VMCI: dma dg: add MMIO access to registers VMCI: dma dg: detect DMA datagram capability VMCI: dma dg: set OS page size VMCI: dma dg: register dummy IRQ handlers for DMA datagrams VMCI: dma

Re: [PATCH] MAINTAINERS: add VM SOCKETS (AF_VSOCK) entry

2021-09-06 Thread Jorgen Hansen
g and contributing for the last few years, > so I'm available to help maintain this code. > > Cc: Dexuan Cui > Cc: Jorgen Hansen > Cc: Stefan Hajnoczi > Suggested-by: Michael S. Tsirkin > Signed-off-by: Stefano Garzarella > --- > > Dexuan, Jorgen, Stefan, w

[PATCH v2] MAINTAINERS: Update for VMCI driver

2021-07-21 Thread Jorgen Hansen
Add maintainer info for the VMware VMCI driver. v2: moved pv-drivers to L: as private list Acked-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a61f4f3..969a67a 100644 --- a/MAINTAINERS

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-21 Thread Jorgen Hansen
> On 21 Jul 2021, at 11:00, Greg KH wrote: > > On Wed, Jul 21, 2021 at 08:46:15AM +0000, Jorgen Hansen wrote: >> >> >>> On 20 Jul 2021, at 12:39, Greg KH wrote: >>> >>> On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote: >

Re: [PATCH] MAINTAINERS: Update for VMCI driver

2021-07-21 Thread Jorgen Hansen
> On 20 Jul 2021, at 12:39, Greg KH wrote: > > On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote: >> Add maintainer info for the VMware VMCI driver. >> >> Signed-off-by: Jorgen Hansen >> --- >> MAINTAINERS | 8 >> 1 file

[PATCH] MAINTAINERS: Update for VMCI driver

2021-07-20 Thread Jorgen Hansen
Add maintainer info for the VMware VMCI driver. Signed-off-by: Jorgen Hansen --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a61f4f3..7e7c6fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19792,6 +19792,14 @@ L: net

Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jorgen Hansen
t 11:25:36AM -0700, Jiang Wang . wrote: On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen mailto:jhan...@vmware.com>> wrote: On 6 Apr 2021, at 20:31, Jiang Wang mailto:jiang.w...@bytedance.com>> wrote: From: "jiang.wang<http://jiang.wang>" mailto:jiang.w...@bytedance.co

Re: [External] [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jorgen Hansen
> On 7 Apr 2021, at 20:25, Jiang Wang . wrote: > > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: >> >> >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote: >>> >>> From: "jiang.wang" >>> >>> Currently, only

Re: [RFC] vsock: add multiple transports support for dgram

2021-04-07 Thread Jorgen Hansen
> On 6 Apr 2021, at 20:31, Jiang Wang wrote: > > From: "jiang.wang" > > Currently, only VMCI supports dgram sockets. To supported > nested VM use case, this patch removes transport_dgram and > uses transport_g2h and transport_h2g for dgram too. Could you provide some background for introducin

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

2021-02-25 Thread Jorgen Hansen
> On 18 Feb 2021, at 06:36, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 155 +-- > 1 file

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

2021-02-25 Thread Jorgen Hansen
On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: > > This adds receive loop for SEQPACKET. It looks like receive loop for > STREAM, but there is a little bit difference: > 1) It doesn't call notify callbacks. > 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is n

Re: [RFC PATCH v4 02/17] af_vsock: separate wait data loop

2021-02-11 Thread Jorgen Hansen
> On 7 Feb 2021, at 16:14, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 158 +-- > 1 file c

[PATCH v2 3/3] VMCI: Enforce queuepair max size for IOCTL_VMCI_QUEUEPAIR_ALLOC

2021-01-20 Thread Jorgen Hansen
x.net. The check in qp_host_alloc_queue has also been updated to enforce the maximum queue pair size as defined by VMCI_MAX_GUEST_QP_MEMORY. The fix has been verified using sample code supplied by nslusa...@gmx.net. Reported-by: nslusa...@gmx.net Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen H

[PATCH v2 2/3] VMCI: Use set_page_dirty_lock() when unregistering guest memory

2021-01-20 Thread Jorgen Hansen
this fix, no warning was observed. Ran various vSocket tests without issues. Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.") Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible

2021-01-20 Thread Jorgen Hansen
Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c index c490658..a3691c1 100644 --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c

[PATCH v2 0/3] VMCI: Queue pair bug fixes

2021-01-20 Thread Jorgen Hansen
This series contains three bug fixes for the queue pair implementation in the VMCI driver. v1 -> v2: - format patches as a series - use min_t instead of min to ensure size_t comparison (issue pointed out by kernel test robot ) Jorgen Hansen (3): VMCI: Stop log spew when qp allocat

Re: [PATCH] VMCI: Enforce queuepair max size for IOCTL_VMCI_QUEUEPAIR_ALLOC

2021-01-11 Thread Jorgen Hansen
On 11 Jan 2021, at 13:46, Greg KH wrote: > > On Mon, Jan 11, 2021 at 04:18:53AM -0800, Jorgen Hansen wrote: >> When create the VMCI queue pair tracking data structures on the host >> side, the IOCTL for creating the VMCI queue pair didn't validate >> the queue pair

[PATCH] VMCI: Use set_page_dirty_lock() when unregistering guest memory

2021-01-11 Thread Jorgen Hansen
this fix, no warning was observed. Ran various vSocket tests without issues. Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.") Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH] VMCI: Stop log spew when qp allocation isn't possible

2021-01-11 Thread Jorgen Hansen
Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c index c490658..a3691c1 100644 --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c

[PATCH] VMCI: Enforce queuepair max size for IOCTL_VMCI_QUEUEPAIR_ALLOC

2021-01-11 Thread Jorgen Hansen
x.net. The check in qp_host_alloc_queue has also been updated to enforce the maximum queue pair size as defined by VMCI_MAX_GUEST_QP_MEMORY. The fix has been verified using sample code supplied by nslusa...@gmx.net. Reported-by: nslusa...@gmx.net Reviewed-by: Vishnu Dasa Signed-off-by: Jorgen H

RE: [PATCH net-next 3/6] vsock: add local transport support in the vsock core

2019-11-21 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Thursday, November 21, 2019 5:13 PM > > On Thu, Nov 21, 2019 at 03:53:47PM +0000, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > > Sent: Thursday, November 21, 2

RE: [PATCH net-next 3/6] vsock: add local transport support in the vsock core

2019-11-21 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Thursday, November 21, 2019 4:22 PM > > On Thu, Nov 21, 2019 at 03:04:18PM +0000, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > > Sent: Tuesday, November 1

RE: [PATCH net-next 2/6] vsock: add VMADDR_CID_LOCAL definition

2019-11-21 Thread Jorgen Hansen via Virtualization
CID_LOCAL. > > Cc: Jorgen Hansen > Signed-off-by: Stefano Garzarella > --- > include/uapi/linux/vm_sockets.h | 8 +--- > net/vmw_vsock/vmci_transport.c | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/uapi/linux/vm_sockets.

RE: [PATCH net-next 0/6] vsock: add local transport support

2019-11-21 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Tuesday, November 19, 2019 12:01 PM > This series introduces a new transport (vsock_loopback) to handle > local communication. > This could be useful to test vsock core itself and to allow developers > to test their applications withou

RE: [PATCH net-next 3/6] vsock: add local transport support in the vsock core

2019-11-21 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Tuesday, November 19, 2019 12:01 PM > To: net...@vger.kernel.org > > This patch allows to register a transport able to handle > local communication (loopback). > > Signed-off-by: Stefano Garzarella > --- > include/net/af_vsock.h |

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-13 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Tuesday, November 12, 2019 11:37 AM > > > > You already mentioned that you are working on a fix for loopback > > > > here for the guest, but presumably a host could also do loopback. > > > > > > IIUC we don't support loopback in the h

RE: [PATCH net-next 12/14] vsock/vmci: register vmci_transport only when VMCI guest/host are active

2019-11-12 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, November 11, 2019 6:31 PM > On Mon, Nov 11, 2019 at 04:27:28PM +0000, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > > Sent: Wednesday, October 23, 2019 11:56 AM

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-12 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, November 11, 2019 6:18 PM > To: Jorgen Hansen > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > On Mon, Nov 11, 2019 at 01:53:39PM +0000, Jorgen Hansen wrote: > > &g

RE: [PATCH net-next 14/14] vsock: fix bind() behaviour taking care of CID

2019-11-11 Thread Jorgen Hansen via Virtualization
++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Jorgen Hansen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: [PATCH net-next 13/14] vsock: prevent transport modules unloading

2019-11-11 Thread Jorgen Hansen via Virtualization
ock/virtio_transport.c | 2 ++ > net/vmw_vsock/vmci_transport.c | 1 + > 6 files changed, 25 insertions(+), 4 deletions(-) Reviewed-by: Jorgen Hansen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: [PATCH net-next 12/14] vsock/vmci: register vmci_transport only when VMCI guest/host are active

2019-11-11 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Wednesday, October 23, 2019 11:56 AM > > To allow other transports to be loaded with vmci_transport, > we register the vmci_transport as G2H or H2G only when a VMCI guest > or host is active. > > To do that, this patch adds a callbac

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-11 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Wednesday, October 23, 2019 11:56 AM Thanks a lot for working on this! > With the multi-transports support, we can use vsock with nested VMs (using > also different hypervisors) loading both guest->host and > host->guest transports a

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-10-30 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > +/* Assign a transport to a socket and call the .init transport callback. > > + * > > + * Note: for stream socket this must be called when vsk->remote_addr > > +is set > > + * (e.g. during the connect() or when a connection request on a >

RE: [PATCH net-next 09/14] vsock: move vsock_insert_unbound() in the vsock_create()

2019-10-30 Thread Jorgen Hansen via Virtualization
Stefan Hajnoczi > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/af_vsock.c | 13 + Reviewed-by: Jorgen Hansen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: [PATCH net-next 08/14] vsock: add vsock_create_connected() called by transports

2019-10-30 Thread Jorgen Hansen via Virtualization
sport_common.c | 3 +-- > net/vmw_vsock/vmci_transport.c | 3 +-- > 5 files changed, 17 insertions(+), 17 deletions(-) Reviewed-by: Jorgen Hansen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: [PATCH net-next 07/14] vsock: handle buffer_size sockopts in the core

2019-10-30 Thread Jorgen Hansen via Virtualization
r_size(struct vsock_sock *vsk) -{ > - return vmci_trans(vsk)->queue_pair_max_size; > -} > - > -static void vmci_transport_set_buffer_size(struct vsock_sock *vsk, u64 val) > -{ > - if (val < vmci_trans(vsk)->queue_pair_min_size) > - vmci_trans(vsk)->queue_

RE: [PATCH net-next 06/14] vsock: add 'struct vsock_sock *' param to vsock_core_get_transport()

2019-10-30 Thread Jorgen Hansen via Virtualization
) { > dst_cid = vsk->remote_addr.svm_cid; > @@ -201,7 +202,7 @@ static int virtio_transport_send_pkt_info(struct > vsock_sock *vsk, > > virtio_transport_inc_tx_pkt(vvs, pkt); > > - return virtio_transport_get_ops()->send_pkt(pkt); > + return

RE: [PATCH net-next 04/14] vsock: add 'transport' member in the struct vsock_sock

2019-10-30 Thread Jorgen Hansen via Virtualization
nsport_single) { > err = -EBUSY; > goto err_busy; > } > @@ -1928,7 +1948,7 @@ int __vsock_core_init(const struct vsock_transport > *t, struct module *owner) > * unload while there are open sockets. >*/ > vsock_proto.own

RE: [PATCH net-next 02/14] vsock: remove vm_sockets_get_local_cid()

2019-10-30 Thread Jorgen Hansen via Virtualization
t_common.c > @@ -168,7 +168,7 @@ static int virtio_transport_send_pkt_info(struct > vsock_sock *vsk, > struct virtio_vsock_pkt *pkt; > u32 pkt_len = info->pkt_len; > > - src_cid = vm_sockets_get_local_cid(); > + src_cid = virtio_transport_get_ops()->

RE: [PATCH net-next 03/14] vsock: remove include/linux/vm_sockets.h file

2019-10-30 Thread Jorgen Hansen via Virtualization
h > b/net/vmw_vsock/vmci_transport_notify.h > index 7843f08d4290..a1aa5a998c0e 100644 > --- a/net/vmw_vsock/vmci_transport_notify.h > +++ b/net/vmw_vsock/vmci_transport_notify.h > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > > #include "vmci_transport.h" > > -- > 2.21.0 Reviewed-by: Jorgen Hansen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: [PATCH net-next 01/14] vsock/vmci: remove unused VSOCK_DEFAULT_CONNECT_TIMEOUT

2019-10-30 Thread Jorgen Hansen via Virtualization
d021c344051af ("VSOCK: Introduce VM Sockets"), but it is never used > in the net/vmw_vsock/vmci_transport.c. > > VSOCK_DEFAULT_CONNECT_TIMEOUT is used and defined in > net/vmw_vsock/af_vsock.c > > Cc: Jorgen Hansen > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Stef

[PATCH] VMCI/VSOCK: Add maintainers for VMCI, AF_VSOCK and VMCI transport

2019-03-21 Thread Jorgen Hansen via Virtualization
Update the maintainers file to include maintainers for the VMware vmci driver, af_vsock, and the vsock vmci transport. Signed-off-by: Jorgen Hansen --- MAINTAINERS | 20 1 file changed, 20 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf7..b9714fc 100644

[PATCH] VMCI: Verify PPNs before sending to device

2019-01-16 Thread Jorgen Hansen via Virtualization
observed that failure was reported. Fixes: 1f166439917b ("VMCI: guest side driver implementation.") Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.") Signed-off-by: Jorgen Hansen Reviewed-by: Adit Ranadive Reviewed-by: Vishnu Dasa --- drivers/misc/vmw_vmci/vm

[PATCH v2] VSOCK: Send reset control packet when socket is partially bound

2018-12-19 Thread Jorgen Hansen
Signed-off-by: Jorgen Hansen --- v1 -> v2: - Changed order of local variables net/vmw_vsock/vmci_transport.c | 67 +++--- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c inde

[PATCH] VSOCK: Send reset control packet when socket is partially bound

2018-12-13 Thread Jorgen Hansen
Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 67 +++--- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 0ae3614..402d84e 100644 --- a/net/vmw_vsock/vmci_tr

[PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

2017-11-27 Thread Jorgen Hansen
hat function. Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 56573dc..a7a73ff 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vs

[PATCH v2] VSOCK: Don't call vsock_stream_has_data in atomic context

2017-11-24 Thread Jorgen Hansen
lling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. v2: Rebased on top of recent change to sk_state values Reviewed-by: Adit Ranadive Reviewed-by: Aditya Sarwade Reviewed-by: Stefan Hajnoczi Signed-off-by: Jorgen Hansen --- net/vmw_

[PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

2017-11-21 Thread Jorgen Hansen
lling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. Reviewed-by: Adit Ranadive Reviewed-by: Aditya Sarwade Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 10 +++--- 1 files changed, 7 insertions(+), 3 dele

[PATCH] VMCI: Doorbell create and destroy fixes

2016-10-06 Thread Jorgen Hansen
-by: Adit Ranadive Signed-off-by: Jorgen Hansen --- drivers/misc/vmw_vmci/vmci_doorbell.c |8 +++- drivers/misc/vmw_vmci/vmci_driver.c |2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_doorbell.c b/drivers/misc/vmw_vmci/vmci_doorbell.c

[PATCH] VSOCK: Don't dec ack backlog twice for rejected connections

2016-09-27 Thread Jorgen Hansen
If a pending socket is marked as rejected, we will decrease the sk_ack_backlog twice. So don't decrement it for rejected sockets in vsock_pending_work(). Testing of the rejected socket path was done through code modifications. Reported-by: Stefan Hajnoczi Signed-off-by: Jorgen Hansen Rev

[PATCH] VSOCK: Only check error on skb_recv_datagram when skb is NULL

2016-04-18 Thread Jorgen Hansen
If skb_recv_datagram returns an skb, we should ignore the err value returned. Otherwise, datagram receives will return EAGAIN when they have to wait for a datagram. Acked-by: Adit Ranadive Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c |7 ++- 1 files changed, 2

[PATCH] VSOCK: Detach QP check should filter out non matching QPs.

2016-04-05 Thread Jorgen Hansen
Zhang Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 0a369bb..662bdd2 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock

[PATCH] VMCI: Use 32bit atomics for queue headers on X86_32

2015-11-12 Thread Jorgen Hansen
being overwritten. On MP systems, there is no such correctness issue, but using 32bit atomics avoids the overhead of the locked 64bit operation. All this is safe because the queue size on 32bit systems will never exceed a 32bit value. Reviewed-by: Thomas Hellstrom Signed-off-by: Jorgen Hansen

[PATCH] VSOCK: sock_put wasn't safe to call in interrupt context

2015-10-21 Thread Jorgen Hansen
from 1.0.2.0-k since up until now it appears that this module was sharing version with vsock that is currently at 1.0.1.0-k). Reviewed-by: Aditya Asarwade Reviewed-by: Thomas Hellstrom Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 173 +++-