Correct issue with not checking kmalloc return value.
This fix now only uses one receive buffer for all hv_utils
channels, and will do only one kmalloc on init and will return
with a -ENOMEM if kmalloc fails on initialize.
Thanks to Evgeniy Polyakov z...@ioremap.net for pointing this out.
And
On Mon, 13 Dec 2010, Hank Janssen wrote:
Correct issue with not checking kmalloc return value.
This fix now only uses one receive buffer for all hv_utils
channels, and will do only one kmalloc on init and will return
with a -ENOMEM if kmalloc fails on initialize.
Thanks to Evgeniy
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Monday, December 13, 2010 12:48 PM
You are leaking memory in the failure path. If for example one or two
allocations succeed but one or two fail, then you'll leak the two successful
allocations.
I believe
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Monday, December 13, 2010 1:06 PM
On Mon, 13 Dec 2010, Hank Janssen wrote:
...
Oops, you are correct. Resubmitting the patch in a few minutes.
Ohh and another little detail; shouldn't this log message
On Mon, 13 Dec 2010, Hank Janssen wrote:
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Monday, December 13, 2010 12:48 PM
You are leaking memory in the failure path. If for example one or two
allocations succeed but one or two fail, then you'll leak
On 12/13/2010 at 3:34 PM, in message
1292272498-29483-1-git-send-email-hjans...@microsoft.com, Hank Janssen
hjans...@microsoft.com wrote:
Correct issue with not checking kmalloc return value.
This fix now only uses one receive buffer for all hv_utils
channels, and will do only one kmalloc
On 12/13/2010 at 3:34 PM, in message
1292272498-29483-1-git-send-email-hjans...@microsoft.com, Hank Janssen
hjans...@microsoft.com wrote:
Correct issue with not checking kmalloc return value.
This fix now only uses one receive buffer for all hv_utils
channels, and will do only one kmalloc
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Monday, December 13, 2010 3:51 PM
To: Ky Srinivasan
+ shut_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);
+ time_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);
+ hbeat_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);