Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Pierre Morel
On 2020-07-06 16:33, Cornelia Huck wrote: On Mon, 6 Jul 2020 15:37:37 +0200 Pierre Morel wrote: On 2020-07-02 15:03, Pierre Morel wrote: On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200,

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Cornelia Huck
On Mon, 6 Jul 2020 15:37:37 +0200 Pierre Morel wrote: > On 2020-07-02 15:03, Pierre Morel wrote: > > > > > > On 2020-06-29 18:05, Cornelia Huck wrote: > >> On Mon, 29 Jun 2020 11:57:14 -0400 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Pierre Morel
On 2020-07-02 15:03, Pierre Morel wrote: On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-02 Thread Pierre Morel
On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protecti

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-30 Thread Cornelia Huck
On Mon, 29 Jun 2020 17:18:09 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jun 29, 2020 at 06:48:28PM +0200, Pierre Morel wrote: > > > > > > On 2020-06-29 18:09, Michael S. Tsirkin wrote: > > > On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > > > > An architecture protecting th

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Michael S. Tsirkin
On Mon, Jun 29, 2020 at 06:48:28PM +0200, Pierre Morel wrote: > > > On 2020-06-29 18:09, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > > > An architecture protecting the guest memory against unauthorized host > > > access may want to enforce VIRTIO

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 18:09, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a c

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 15:44, Cornelia Huck wrote: On Mon, 29 Jun 2020 15:14:04 +0200 Pierre Morel wrote: On 2020-06-19 11:20, Cornelia Huck wrote: On Thu, 18 Jun 2020 00:29:56 +0200 Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: @@ -179,6 +194,13 @@ int virtio_

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 17:57, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > An architecture protecting the guest memory against unauthorized host > access may want to enforce VIRTIO I/O device protection through the > use of VIRTIO_F_IOMMU_PLATFORM. > Let's give a chance to the architecture to accept or not de

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Cornelia Huck
On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > > An architecture protecting the guest memory against unauthorized host > > access may want to enforce VIRTIO I/O device protection through the > > use of VIRTIO_F_IOMM

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > An architecture protecting the guest memory against unauthorized host > access may want to enforce VIRTIO I/O device protection through the > use of VIRTIO_F_IOMMU_PLATFORM. > > Let's give a chance to the architecture to accept or not

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Cornelia Huck
On Mon, 29 Jun 2020 15:14:04 +0200 Pierre Morel wrote: > On 2020-06-19 11:20, Cornelia Huck wrote: > > On Thu, 18 Jun 2020 00:29:56 +0200 > > Halil Pasic wrote: > > > >> On Wed, 17 Jun 2020 12:43:57 +0200 > >> Pierre Morel wrote: > >>> @@ -179,6 +194,13 @@ int virtio_finalize_features(str

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-18 00:29, Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to th

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-19 14:02, Halil Pasic wrote: On Fri, 19 Jun 2020 11:20:51 +0200 Cornelia Huck wrote: + if (arch_needs_virtio_iommu_platform(dev) && + !virtio_has_feature(dev, VIRTIO_F_IOMMU_PLATFORM)) { + dev_warn(&dev->dev, +"virtio: dev

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-19 11:20, Cornelia Huck wrote: On Thu, 18 Jun 2020 00:29:56 +0200 Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: ... But since this can be rewritten any time, let's go with the option people already agree with, instead of more discussion. Yes, the

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-19 Thread Halil Pasic
On Fri, 19 Jun 2020 11:20:51 +0200 Cornelia Huck wrote: > > > + if (arch_needs_virtio_iommu_platform(dev) && > > > + !virtio_has_feature(dev, VIRTIO_F_IOMMU_PLATFORM)) { > > > + dev_warn(&dev->dev, > > > + "virtio: device must provide > > > VIRTIO_F_IOMMU_PLATFOR

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-19 Thread Cornelia Huck
On Thu, 18 Jun 2020 00:29:56 +0200 Halil Pasic wrote: > On Wed, 17 Jun 2020 12:43:57 +0200 > Pierre Morel wrote: > > > An architecture protecting the guest memory against unauthorized host > > access may want to enforce VIRTIO I/O device protection through the > > use of VIRTIO_F_IOMMU_PLATFORM

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Halil Pasic
On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: > An architecture protecting the guest memory against unauthorized host > access may want to enforce VIRTIO I/O device protection through the > use of VIRTIO_F_IOMMU_PLATFORM. > > Let's give a chance to the architecture to accept or not devi

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Tom Lendacky
On 6/17/20 5:43 AM, Pierre Morel wrote: > An architecture protecting the guest memory against unauthorized host > access may want to enforce VIRTIO I/O device protection through the > use of VIRTIO_F_IOMMU_PLATFORM. > > Let's give a chance to the architecture to accept or not devices > without VIR

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
On 2020-06-17 15:36, Tom Lendacky wrote: On 6/17/20 5:43 AM, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture t

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Heiko Carstens
On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: > An architecture protecting the guest memory against unauthorized host > access may want to enforce VIRTIO I/O device protection through the > use of VIRTIO_F_IOMMU_PLATFORM. > > Let's give a chance to the architecture to accept or not

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
On 2020-06-17 13:22, Heiko Carstens wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chan

[PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture to accept or not devices without VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Pierre Morel