Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-18 Thread Michael S. Tsirkin
On Sun, Jul 17, 2011 at 10:01:41PM +0200, Jesper Juhl wrote: > > @@ -28,10 +29,18 @@ > > > > #include "vhost.h" > > > > +static int zcopytx; > > +module_param(zcopytx, int, 0444); > > Should everyone be able to read this? How about "0440" just to be > paranoid? or? I find it very helpful to

Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread Jesper Juhl
On Sun, 17 Jul 2011, Michael S. Tsirkin wrote: > From: Shirley Ma > > This adds experimental zero copy support in vhost-net, > disabled by default. To enable, set the zerocopytx > module option to 1. > > This patch maintains the outstanding userspace buffers in the > sequence it is delivered to

Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 17 Jul 2011 22:36:14 +0300 > The below is what I came up with. We add the feature enabled > by default ... s/enabled/disabled/ Well, at least you got it right in the commit message where it counts :-) ___ Virtuali

[PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread Michael S. Tsirkin
From: Shirley Ma This adds experimental zero copy support in vhost-net, disabled by default. To enable, set the zerocopytx module option to 1. This patch maintains the outstanding userspace buffers in the sequence it is delivered to vhost. The outstanding userspace buffers will be marked as done