Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-10-26 Thread Cornelia Huck
On Wed, 23 Aug 2017 18:33:02 +0200 Pierre Morel wrote: > Reseting a device can sometime fail, even a virtual device. > If the device is not reseted after a while the driver should > abandon the retries. > This is the change proposed for the modern virtio_pci. > > More

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Michael S. Tsirkin
On Fri, Aug 25, 2017 at 10:33:57AM +0200, Pierre Morel wrote: > On 24/08/2017 23:23, Michael S. Tsirkin wrote: > > On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: > > > On 24/08/2017 16:19, Michael S. Tsirkin wrote: > > > > On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Michael S. Tsirkin
On Fri, Aug 25, 2017 at 10:26:12AM +0200, Cornelia Huck wrote: > On Fri, 25 Aug 2017 00:16:05 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Aug 24, 2017 at 07:07:42PM +0200, Pierre Morel wrote: > > > > - we'll have to spread these tests all over the place. > > > > > > I

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 25/08/2017 10:26, Cornelia Huck wrote: On Fri, 25 Aug 2017 00:16:05 +0300 "Michael S. Tsirkin" wrote: On Thu, Aug 24, 2017 at 07:07:42PM +0200, Pierre Morel wrote: - we'll have to spread these tests all over the place. I counted 19 places where to check if the reset

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 24/08/2017 23:23, Michael S. Tsirkin wrote: On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: On 24/08/2017 16:19, Michael S. Tsirkin wrote: On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Michael S. Tsirkin
On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: > On 24/08/2017 16:19, Michael S. Tsirkin wrote: > > On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: > > > Reseting a device can sometime fail, even a virtual device. > > > If the device is not reseted after a while the

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 16:19, Michael S. Tsirkin wrote: On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device is not reseted after a while the driver should abandon the retries. This is the change proposed for the modern

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 16:12, Michael S. Tsirkin wrote: On Thu, Aug 24, 2017 at 02:16:11PM +0200, Pierre Morel wrote: On 24/08/2017 13:07, Cornelia Huck wrote: On Wed, 23 Aug 2017 18:33:02 +0200 Pierre Morel wrote: Reseting a device can sometime fail, even a virtual

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Michael S. Tsirkin
On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: > Reseting a device can sometime fail, even a virtual device. > If the device is not reseted after a while the driver should > abandon the retries. > This is the change proposed for the modern virtio_pci. > > More generally, when this

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Michael S. Tsirkin
On Thu, Aug 24, 2017 at 02:16:11PM +0200, Pierre Morel wrote: > On 24/08/2017 13:07, Cornelia Huck wrote: > > On Wed, 23 Aug 2017 18:33:02 +0200 > > Pierre Morel wrote: > > > > > Reseting a device can sometime fail, even a virtual device. > > > If the device is not

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 13:07, Cornelia Huck wrote: On Wed, 23 Aug 2017 18:33:02 +0200 Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device is not reseted after a while the driver should abandon the retries. This is the change proposed