Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Halil Pasic
On Thu, 9 Jul 2020 16:51:04 +0200 Pierre Morel wrote: > > > On 2020-07-09 16:47, Halil Pasic wrote: > > On Thu, 9 Jul 2020 12:51:58 +0200 > > Pierre Morel wrote: > > > +int arch_validate_virtio_features(struct virtio_device *dev) > +{ > +if (!is_prot_virt_guest()) >

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 16:47, Halil Pasic wrote: On Thu, 9 Jul 2020 12:51:58 +0200 Pierre Morel wrote: +int arch_validate_virtio_features(struct virtio_device *dev) +{ + if (!is_prot_virt_guest()) + return 0; + + if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) { +

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Halil Pasic
On Thu, 9 Jul 2020 12:51:58 +0200 Pierre Morel wrote: > >> +int arch_validate_virtio_features(struct virtio_device *dev) > >> +{ > >> + if (!is_prot_virt_guest()) > >> + return 0; > >> + > >> + if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) { > >> + dev_warn(>dev, "device

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 11:55, Halil Pasic wrote: On Thu, 9 Jul 2020 10:57:33 +0200 Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 10:57, Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features()

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Halil Pasic
On Thu, 9 Jul 2020 10:57:33 +0200 Cornelia Huck wrote: > On Thu, 9 Jul 2020 10:39:19 +0200 > Pierre Morel wrote: > > > If protected virtualization is active on s390, the virtio queues are > > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > > negotiated. Use the new

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Cornelia Huck
On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not