[patch@35055] vms feature setting fixes

2008-12-07 Thread John E. Malmberg
This patch addresses two issues: 1. The setting for features should be case-insensitive. 2. The enabling of sys$posix_root was not working on threaded perl. -John [EMAIL PROTECTED] personal opinion only --- /ref1_root/perl/vms/vms.c Sun Dec 7 07:59:24 2008 +++ vms/vms.c Sun Dec 7 08:25:58

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread John E. Malmberg
John E. Malmberg wrote: The mp_do_pathify_dirspec needed enhancements to more accurately parse VMS file specifications, and also to handle UNIX file specifications the same way that mp_do_tovmspath() does. It was simpler to replace than to try to modify the existing routine. In addition this

[patch@35055] VMS parsing not handling no-priv cases

2008-12-07 Thread John E. Malmberg
The VMS parsing routines were failing on files that the process currently did not have access to, instead of falling back to a syntax only check. We may want to consider always falling back to a syntax only check as there may be more non-fatal return codes of these type. -John [EMAIL PROTECT

[patch@35055] vms.c unixify refactor

2008-12-07 Thread John E. Malmberg
This patch makes a version of unixify available for calling with out an implicit context, which is needed for threaded perl as several routines do not have a thread context. This is the second of a multi-part conversion to remove access violations when internal perl warning and error routines,

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread Craig A. Berry
On Dec 7, 2008, at 8:46 AM, John E. Malmberg wrote: John E. Malmberg wrote: The mp_do_pathify_dirspec needed enhancements to more accurately parse VMS file specifications, and also to handle UNIX file specifications the same way that mp_do_tovmspath() does. It was simpler to replace than t

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread Nicholas Clark
On Sun, Dec 07, 2008 at 08:46:52AM -0600, John E. Malmberg wrote: > An additional note, this patch may cause some tests in vmsfspec.t to > fail. That is because the old behavior of pathfiy_dirspec() was > inconsistent with vmsify(). On Sun, Dec 07, 2008 at 10:15:39AM -0600, John E. Malmberg wr

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread John E. Malmberg
Craig A. Berry wrote: On Dec 7, 2008, at 8:46 AM, John E. Malmberg wrote: An additional note, this patch may cause some tests in vmsfspec.t to fail. That is because the old behavior of pathfiy_dirspec() was inconsistent with vmsify(). Specifically: not ok 92 - pathify('/__down_/__the_/_

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread John E. Malmberg
Nicholas Clark wrote: On Sun, Dec 07, 2008 at 08:46:52AM -0600, John E. Malmberg wrote: An additional note, this patch may cause some tests in vmsfspec.t to fail. That is because the old behavior of pathfiy_dirspec() was inconsistent with vmsify(). On Sun, Dec 07, 2008 at 10:15:39AM -0600

[patch@35055] vms.c unixpath refactor

2008-12-07 Thread John E. Malmberg
This patch makes a version of unixpath available for calling without an implicit context, which is needed for threaded perl as several routines currently calling it do not have a or should not need a thread context. This is the third part of a multi-part conversion to remove access violations

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread Craig A. Berry
On Dec 7, 2008, at 12:46 PM, John E. Malmberg wrote: Nicholas Clark wrote: On Sun, Dec 07, 2008 at 08:46:52AM -0600, John E. Malmberg wrote: An additional note, this patch may cause some tests in vmsfspec.t to fail. That is because the old behavior of pathfiy_dirspec() was inconsistent wi

Re: [patch@35050] replace pathify_dirspec in VMS with new version

2008-12-07 Thread John E. Malmberg
Craig A. Berry wrote: On Dec 7, 2008, at 12:46 PM, John E. Malmberg wrote: Point taken, Attached is vms/ext/filespec.t that changes those tests to be passing. The documentation for VMS::Filespec::pathify says, "the file type and version, if specified, must be .DIR;1. For compatibility with

[patch@35055] vms.c vmsify refactor

2008-12-07 Thread John E. Malmberg
This patch makes a version of vmsify and vmspath available for calling with out an implicit context, which is needed for threaded perl as several routines do not have or need an implicit context. This is the fourth of a multi-part conversion to remove access violations when internal perl warni

[patch@35055] vms.c fileify refactor

2008-12-07 Thread John E. Malmberg
This patch makes a version of fileify available for calling with out an implicit context, which is needed for threaded perl as several routines do not have or need an implicit context. This is the fifth of a multi-part conversion to remove access violations when internal perl warning and error

[patch@35055] vms.c rmsexpand refactor

2008-12-07 Thread John E. Malmberg
This patch makes a version of rmsexpand available for calling with out an implicit context, which is needed for threaded perl as several routines do not have or need an implicit context. This is the sixth of a multi-part conversion to remove access violations when internal perl warning and err

Re: [patch@35055] vms.c rmsexpand refactor

2008-12-07 Thread Craig A. Berry
On Dec 7, 2008, at 6:44 PM, John E. Malmberg wrote: This patch makes a version of rmsexpand available for calling with out an implicit context, which is needed for threaded perl as several routines do not have or need an implicit context. This is the sixth of a multi-part conversion to rem

Re: [patch@35055] vms.c rmsexpand refactor

2008-12-07 Thread John E. Malmberg
Craig A. Berry wrote: I will look at these, test them, and -- if all goes well -- apply them, but it's likely to take me a while to get to them. In general I agree with the principle that routines that can be called very early in start-up before thread context is initialized do need to be ca