Re: [vpp-dev] [QUESTION] How to add virtual interfaces on ARM board

2023-03-22 Thread Xiaodong Xu
Maybe you can try host interface in this case, since you are going to share the control traffic and the user traffic on the only NIC. Check https://s3-docs.fd.io/vpp/23.06/gettingstarted/progressivevpp/interface.html#create-vpp-host-interface for more details. Regards, Xiaodong On Wed, Mar 22,

[vpp-dev] [QUESTION] How to add virtual interfaces on ARM board

2023-03-22 Thread dorian_lau
Hi, I'm a newbie and study vpp recently. I succeed cross compiling vpp (including my own plugin) , and it can be started up on my arm64 board (aarch64 ubuntu 18.04).  But there is only one physical NIC (eth1)  which I can use on the board, and I don't need dpdk, so there is only local0 when I

Re: [vpp-dev] #vnet A bug which may cause assertion error in vnet/session

2023-03-22 Thread Chen Weihao
Thank you for your reply. I did use a VMware virtual machine before, I switched to a physical NIC for testing and now there is no problem setting rx-num to 5. Also, I tested redis using redis-benchmark, the specific command is as follows: sudo taskset -c 9 bash -c

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread filvarga
If you decide to split the patch and do a second version. I would like to see the first version set as deprecated. So when removed we can put it again in without having to have _v2 _v3 etc. Best regards, Filip Varga st 22. 3. 2023 o 15:33 Daniel Béreš napísal(a): > Thanks for the reasonable

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Daniel Béreš
Thanks for the reasonable explanations. So the option could be splitting it into two patches. The first could fix replies and the second could contain a new experimental API nat44_ed_vrf_tables_send_details_v2. I think it might be okay after that. Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Andrew Yourtchenko
Some more context: after discussion with Ole: I think I might have overstepped the authority in terms of "-2" - it is component maintainers' decision if they want to put even completely breaking change into their component that sets the world on fire - if the CI lets that through - it is their

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread filvarga
Hi, Yes I fully agree with Andrew on changing APIs. Though the api was broken in the first place. If used incorrect message is returned. Because of that I am not even sure if it is functional at all. It is more likely that nobody before addressed this issue because this feature is not used. So I

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Andrew Yourtchenko
Hey Daniel,I had a quick look and it looks like the APIs in question are also not marked as experimental ?If I am right, then to me seems like a silent behavior change to a production API - something we have heard repeated complaints from the downstream consumers for….I had -2’d it for now - we

[vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Daniel Béreš
Hello Guys, I wrote a short patch to fix a couple api handlers for nat44ed [1] . ( https://gerrit.fd.io/r/c/vpp/+/38459 ) It was probably forgotten, so I'm reminding myself. I still have a question about whether it is possible to cherry-pick the patch to vpp v23.02 and 22.10. [1] 

Re: [vpp-dev] #vnet A bug which may cause assertion error in vnet/session

2023-03-22 Thread Chen Weihao
Thank you for you reply. I did use a VMware virtual machine before, I switched to a physical NIC for testing and now there is no problem setting rx-num to 5. Also, I tested redis using redis-benchmark, the specific command is as follows: sudo taskset -c 9 bash -c