Re: [vpp-dev] Manual patch verify request: gerrit 13769

2018-07-30 Thread Zhiyong Yang
in ip4_header_checksum https://gerrit.fd.io/r/13803 Thanks Zhiyong From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Saturday, July 28, 2018 7:39 PM To: Dave Barach Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Manual patch verify request: gerrit

Re: [vpp-dev] Manual patch verify request: gerrit 13769

2018-07-28 Thread Damjan Marion via Lists.Fd.Io
Is incremental checksum really needed here, or we can just move to new vectorized checksum calculation (already used in ip-input)? -- Damjan > On 27 Jul 2018, at 22:17, Dave Barach via Lists.Fd.Io > wrote: > > Thanks very much... Dave > > From: Tina Tsou mailto:tina.t...@arm.com>> >

Re: [vpp-dev] Manual patch verify request: gerrit 13769

2018-07-27 Thread Dave Barach via Lists.Fd.Io
Thanks very much... Dave From: Tina Tsou Sent: Friday, July 27, 2018 1:51 PM To: Dave Barach (dbarach) Cc: Brian Brooks ; vpp-dev@lists.fd.io Subject: Re: Manual patch verify request: gerrit 13769 Dear Dave, Looking into it... Thank you, Tina On Jul 27, 2018, at 7:23 AM, Dave Barach

Re: [vpp-dev] Manual patch verify request: gerrit 13769

2018-07-27 Thread Sirshak Das
patch verify request: gerrit 13769 Folks, Would it be possible for someone to download and manually verify that https://gerrit.fd.io/r/#/c/13769 is functionally correct, and that the proposed change isn't a performance disaster on aarch64? Thanks... Dave IMPORTANT NOTICE: The contents

Re: [vpp-dev] Manual patch verify request: gerrit 13769

2018-07-27 Thread Tina Tsou
Dear Dave, Looking into it... Thank you, Tina On Jul 27, 2018, at 7:23 AM, Dave Barach (dbarach) mailto:dbar...@cisco.com>> wrote: Folks, Would it be possible for someone to download and manually verify that https://gerrit.fd.io/r/#/c/13769 is functionally correct, and that the proposed

[vpp-dev] Manual patch verify request: gerrit 13769

2018-07-27 Thread Dave Barach via Lists.Fd.Io
Folks, Would it be possible for someone to download and manually verify that https://gerrit.fd.io/r/#/c/13769 is functionally correct, and that the proposed change isn't a performance disaster on aarch64? Thanks... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this