Re: [vpp-dev] PPPOE

2018-11-27 Thread Zhang Dongya
Hi, We have put our pppoe client implementation on our github, I have synced our latest commit from our internal branch. If you want to have a try, you can compile that branch and refer to commands of plugin/pppox and plugin/pppoeclient. The github link is:

Re: [vpp-dev] deadloop in internal_mallinfo

2022-07-07 Thread Zhang Dongya
Hi list, It seems there is memory overwrite in our plugin which corrupts the memory, after fix that, the deadloop vanished. Zhang Dongya via lists.fd.io 于2022年7月6日周三 15:52写道: > Hi list, > > Recently I encountered a deadloop in 1 master + 1 worker mode of vpp(also > happens i

[vpp-dev] deadloop in internal_mallinfo

2022-07-06 Thread Zhang Dongya
Hi list, Recently I encountered a deadloop in 1 master + 1 worker mode of vpp(also happens in 1 master 0 worker mode) when I do some vpp (based on vpp 21.10) configuration through govpp. The thread stats in gdb is: (gdb) info threads Id Target Id

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-24 Thread Zhang Dongya
1 in the patch? > > Regards, > Florin > > On Oct 24, 2022, at 12:23 AM, Zhang Dongya > wrote: > > Hi list, > > Recently I am testing my TCP application in a plugin, what I did is to > initiate a TCP client in my plugin, however, when I build the debug image > and

[vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-24 Thread Zhang Dongya
Hi list, Recently I am testing my TCP application in a plugin, what I did is to initiate a TCP client in my plugin, however, when I build the debug image and test, the vpp will crash and complaint about out of memory. After doing some research, it seems the following code may cause the crash:

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

2022-10-12 Thread Zhang Dongya
t; does timeout and cleanups those stuck half-open sessions, but we should > allow the app to cleanup as well. > > Let me know if you plan to push a patch or I should do it. > > Regards, > Florin > > On Oct 12, 2022, at 12:44 AM, Zhang Dongya > wrote: > > Hi, > &

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

2022-10-12 Thread Zhang Dongya
tity.linuxfoundation.org/ > [2] > https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pulling_code_via_ssh > > > On Oct 12, 2022, at 6:21 PM, Zhang Dongya > wrote: > > Thanks a lot,I just add a check for tx_fifo there locally and it seems &g

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

2022-10-13 Thread Zhang Dongya
l/2/create/37 > > On Oct 12, 2022, at 10:42 PM, Zhang Dongya > wrote: > > Yes, I can login to link [1] and can see my account have been registered > in LF 5 years, however, when I login the gerrit web ui, it still reports > Forbidden error, my account username is ZhangDongya. &g

[vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

2022-10-12 Thread Zhang Dongya
Hi, I am now trying to use vpp host-stack to negotiate a valid TCP session, however, I found if I call vnet_disconnect_session when the TCP stuck in syn-sent state (this may be caused by I have shutdown the remove side). Vpp will crash in the following code which call svm_fifo_clear_deq_ntf

Re: [vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-12-13 Thread Zhang Dongya
alid fib index and there is not check in the following ip4_fib_forwarding_lookup, so it crash with abort. I don't think a api barrier in step 2 can solve this, since the pkt is already in the pending frame. Zhang Dongya via lists.fd.io 于2022年12月8日周四 00:17写道: > The crash have not been found

Re: [vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-12-07 Thread Zhang Dongya
The crash have not been found anymore. Does this fix make any sense? it it does, I will submit a patch later. Zhang Dongya via lists.fd.io 于 2022年11月29日周二 22:51写道: > Hi ben, > > In the beginning I also think it should be a barrier issue, however it > turned out not the case. >

Re: [vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-12-13 Thread Zhang Dongya
. > vlib_worker_thread_barrier_sync (vm); > vlib_worker_thread_barrier_release (vm); > } > } > Zhang Dongya via lists.fd.io 于2022年12月14日周三 11:52写道: > Hi list, > > During the test, when l3sub if is deleted, I got a new abort in interface > drop node, seems th

Re: [vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-11-28 Thread Zhang Dongya
I have found a solution and it can solve the crash issue. In ip4_sw_interface_add_del which is a callback for interface deletion, we may set the fib index of the removed interface to 0 (default fib) instead of ~0. This behavior is same with interface creation. Zhang Dongya via lists.fd.io 于

Re: [vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-11-29 Thread Zhang Dongya
ex, but fib_index might be different. > > Best > ben > > > -Original Message----- > > From: vpp-dev@lists.fd.io On Behalf Of Zhang > Dongya > > Sent: Tuesday, November 29, 2022 3:45 > > To: vpp-dev@lists.fd.io > > Subject: Re: [vpp-dev] possible u

[vpp-dev] possible use deleted sw if index in ip4-lookup and cause crash

2022-11-28 Thread Zhang Dongya
Hi list, Recently I encountered a vpp crash with my plugin enabled, after some investigation I find it may related with l3 sub interface delete while my process node add work to ip4-lookup node. Intuitively I think it may related to a barrier usage but I tried to fix by add some check in my

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-11-03 Thread Zhang Dongya
sion_index + 1. > > Regards, > Florin > > On Oct 24, 2022, at 9:11 PM, Zhang Dongya > wrote: > > Hi, > > Can you elaborate a bit on that, If session index is 64, if we do not > increase by 1, it will only make one 64B vec for the bitmap, which may not > hold the se

Re: [vpp-dev] can't establish tcp connection with new introduced transport_endpoint_freelist

2023-03-16 Thread Zhang Dongya
gt; Don’t think we explicitly supported this before but here’s a patch [1]. > > Regards, > Florin > > [1] https://gerrit.fd.io/r/c/vpp/+/38486 > > > On Mar 14, 2023, at 12:56 AM, Zhang Dongya > wrote: > > Just use this patch and the connection can be reconnected aft

[vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-19 Thread Zhang Dongya
Hi list, recently in our application, we constantly triggered such abrt issue which make our connectivity interrupt for a while: Mar 19 16:11:26 ubuntu vnet[2565933]: received signal SIGABRT, PC 0x7fefd3b2000b Mar 19 16:11:26 ubuntu vnet[2565933]:

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-19 Thread Zhang Dongya
rely only on C > apis to interact with host stack? > - on what thread (main or first worker) do you call vnet_connect? > - what api do you use to close the session? > - what version of vpp is this because lines don’t match vpp latest? > > Regards, > Florin > > > On M

Re: [vpp-dev] can't establish tcp connection with new introduced transport_endpoint_freelist

2023-03-14 Thread Zhang Dongya
0; > } > Florin Coras 于2023年3月14日周二 11:38写道: > Hi, > > Could you try this out [1]? I’ve hit this issue myself today but with udp > sessions. Unfortunately, as you’ve correctly pointed out, we were forcing a > cleanup only on the non-fixed local port branch. > > Regard

[vpp-dev] can't establish tcp connection with new introduced transport_endpoint_freelist

2023-03-13 Thread Zhang Dongya
Hi list, We have update coded from the upstream session changes to our code base and find a possible bug which cause tcp connection can't be established anymore. Our scenario is that we will connect to a remote tcp server with specified local port and local ip, however, new vpp code have

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-23 Thread Zhang Dongya
Hi, The new patch works as expected, no assert triggered abort anymore. Really appreciate your help and thanks a lot. Florin Coras 于2023年3月22日周三 11:54写道: > Hi Zhang, > > Awesome! Thanks! > > Regards, > Florin > > On Mar 21, 2023, at 7:41 PM, Zhang Dongya > wrote

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-20 Thread Zhang Dongya
//gerrit.fd.io/r/c/vpp/+/38507 > > On Mar 20, 2023, at 6:52 PM, Zhang Dongya > wrote: > > Hi, > > After merge this patch and update the test environment, the issue still > persists. > > Let me clear my client app config: > 1. register a reset callback, which will call v

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-20 Thread Zhang Dongya
20日周一 23:29写道: > Hi, > > Understood and yes, connect will synchronously fail if port is not > available, so you should be able to retry it later. > > Regards, > Florin > > On Mar 20, 2023, at 1:58 AM, Zhang Dongya > wrote: > > Hi, > > It seems the iss

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-20 Thread Zhang Dongya
and will provide feedback later. Florin Coras 于2023年3月20日周一 13:09写道: > Hi, > > Inline. > > On Mar 19, 2023, at 6:47 PM, Zhang Dongya > wrote: > > Hi, > > It can be aborted both in established state or half open state because I > will do timeout in our app lay

Re: [vpp-dev] Sigabrt in tcp46_input_inline for tcp_lookup_is_valid

2023-03-21 Thread Zhang Dongya
I updated the > patch to just clean them up on forced reset, without sending a reset to > make sure session lookup table cleanup still happens. > > Regards, > Florin > > On Mar 20, 2023, at 9:13 PM, Zhang Dongya > wrote: > > Hi, > > After r

[vpp-dev] possible bug in sparse_vec_index2

2023-02-06 Thread Zhang Dongya
Hi list, Recently I found a weird bug when there is only 1 UDP local port registered due to our vpp application have special initialize sequence, the sparse_vec_index2 will trigger vpp crash. By comparing sparse_vec_index2 and sparse_vec_index_internal, it seems sparse_vec_index2 does not